From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 382D0C4321E for ; Thu, 27 Jan 2022 20:03:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240392AbiA0UDC (ORCPT ); Thu, 27 Jan 2022 15:03:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343895AbiA0UCm (ORCPT ); Thu, 27 Jan 2022 15:02:42 -0500 Received: from smtp.domeneshop.no (smtp.domeneshop.no [IPv6:2a01:5b40:0:3005::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B175C06177E for ; Thu, 27 Jan 2022 12:02:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tronnes.org ; s=ds202112; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=c0zwNtR9SaqZUtE2VSeLImNsuYYf9Ru2jvQ3WRs6pZ4=; b=JK8DCtH5DW4pWaHH84cN6Qhv8u b8d2aAHP6G48V+J+Il8N5V/M6dMABM44YycU+U5i7punR6sxXU2yEJIAIkK319aO+ved6CdmlBwq9 2TBb/JDckGZjGcqLNXbm7ltuhT87ypCp6CJGrTMFOhBA7QEfU1xqhElwUWuZYnA+/Vo/yMeCu+S4N OtalCqFCgwFUetLdQfUPIBYf23FvsyfdTGfIsLAeUeUN117ZuoVBx3hOYWp1602T68wJGsyw6drul PEXf50P8Y5hMkmgGvpF7CA8pX0Boac7W8Su1B3ISXnuxWPzNu1Y1zYr38Hl4CUy0a2JfLqZVbzHsP YmWFOETQ==; Received: from 211.81-166-168.customer.lyse.net ([81.166.168.211]:62402 helo=[192.168.10.61]) by smtp.domeneshop.no with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nDAyZ-0007Fw-8k; Thu, 27 Jan 2022 21:02:35 +0100 Message-ID: <82008ca7-9c67-d618-2110-6a8de8fa1d7f@tronnes.org> Date: Thu, 27 Jan 2022 21:02:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 0/3] drm/panel: Add MIPI DBI compatible SPI driver To: David Lechner , robh+dt@kernel.org, thierry.reding@gmail.com Cc: sam@ravnborg.org, maxime@cerno.tech, dave.stevenson@raspberrypi.com, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20220125175700.37408-1-noralf@tronnes.org> From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Den 27.01.2022 18.13, skrev David Lechner: > On 1/25/22 11:56 AM, Noralf Trønnes wrote: >> Hi, >> >> This patchset adds a driver that will work with most MIPI DBI compatible >> SPI panels out there. >> >> It's a follow up on 'drm/tiny/st7735r: Match up with staging/fbtft >> driver'[1] which aimed at making the st7735r driver work with all panels >> adding DT properties. >> >> Maxime gave[2] a good overview of the situation with these displays and >> proposed to make a driver that works with all MIPI DBI compatible >> controllers and use a firmware file to provide the controller setup for >> a particular panel. >> >> Main change since previous version: >> - Drop model property and use the compatible property instead (Rob) >> >> Noralf. >> >> [1] >> https://lore.kernel.org/dri-devel/20211124150757.17929-1-noralf@tronnes.org/ >> >> [2] >> https://lore.kernel.org/dri-devel/20211129093946.xhp22mvdut3m67sc@houat/ >> >> >> Noralf Trønnes (3): >>    dt-bindings: display: add bindings for MIPI DBI compatible SPI panels >>    drm/mipi-dbi: Add driver_private member to struct mipi_dbi_dev >>    drm/panel: Add MIPI DBI compatible SPI driver >> >>   .../display/panel/panel-mipi-dbi-spi.yaml     |  59 +++ >>   MAINTAINERS                                   |   8 + >>   drivers/gpu/drm/panel/Kconfig                 |  11 + >>   drivers/gpu/drm/panel/Makefile                |   1 + >>   drivers/gpu/drm/panel/panel-mipi-dbi.c        | 394 ++++++++++++++++++ >>   include/drm/drm_mipi_dbi.h                    |   2 + >>   6 files changed, 475 insertions(+) >>   create mode 100644 >> Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml >>   create mode 100644 drivers/gpu/drm/panel/panel-mipi-dbi.c >> > > It would be useful to also include a patch for a tool to create > these "firmware" files. For example a Python script that takes > a more human-readable input and generates a .bin file. I will put a script on the github repo that holds the wiki for the driver. I haven't made the script yet, just using a hack for now until the format is decided upon. Noralf.