From: Ming-Jen Chen <mjchen0829@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, peng.fan@nxp.com,
arnd@arndb.de, sudeep.holla@arm.com, conor+dt@kernel.org,
krzk+dt@kernel.org, robh@kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH v5 1/2] dt-bindings: input: Add Nuvoton MA35D1 keypad
Date: Wed, 8 Jan 2025 16:42:05 +0800 [thread overview]
Message-ID: <820def99-4990-4391-a45a-0d3908d3306b@gmail.com> (raw)
In-Reply-To: <ux55pgpmkngxjsl4semw2cfiljbszvotaydrxrihdu3zphsfqc@vsk72c3wqorc>
Krzysztof Kozlowski 於 2025/1/8 16:13 寫道:
> On Wed, Jan 08, 2025 at 01:18:11AM +0000, Ming-Jen wrote:
>> From: Ming-jen Chen <mjchen0829@gmail.com>
>>
>> Add YAML bindings for MA35D1 SoC keypad.
>>
>> Signed-off-by: Ming-jen Chen <mjchen0829@gmail.com>
>> ---
>> .../bindings/input/nuvoton,ma35d1-keypad.yaml | 82 +++++++++++++++++++
>> 1 file changed, 82 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml b/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml
>> new file mode 100644
>> index 000000000000..889f253b3bc2
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml
> I don't see changes.
>
> I already raised concern that you sent new versions without implementing
> or responding to comments. So the fourth (!!!) time: Filename matching
> compatible.
>
> Best regards,
> Krzysztof
Thank you for your feedback! I now understand the changes I need to make.
I will modify it as blow:
compatible:
const: nuvoton,ma35d1-keypad
next prev parent reply other threads:[~2025-01-08 8:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 1:18 [PATCH v5 0/2] Add support for nuvoton ma35d1 keypad controller Ming-Jen
2025-01-08 1:18 ` [PATCH v5 1/2] dt-bindings: input: Add Nuvoton MA35D1 keypad Ming-Jen
2025-01-08 8:13 ` Krzysztof Kozlowski
2025-01-08 8:42 ` Ming-Jen Chen [this message]
2025-01-08 8:55 ` Krzysztof Kozlowski
2025-01-08 1:18 ` [PATCH v5 2/2] input: keypad: add new keypad driver for MA35D1 Ming-Jen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=820def99-4990-4391-a45a-0d3908d3306b@gmail.com \
--to=mjchen0829@gmail.com \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).