From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bough Chen <haibo.chen@nxp.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
Cc: "kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: imx6sll-evk: add eMMC node support
Date: Tue, 30 May 2023 12:39:11 +0200 [thread overview]
Message-ID: <821eff3e-67e1-6398-b9a0-0de7cd149e36@linaro.org> (raw)
In-Reply-To: <DB7PR04MB4010031616E89061103CF5B9907C9@DB7PR04MB4010.eurprd04.prod.outlook.com>
On 19/05/2023 08:07, Bough Chen wrote:
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Sent: 2023年5月18日 20:10
>> To: Bough Chen <haibo.chen@nxp.com>; robh+dt@kernel.org;
>> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org;
>> shawnguo@kernel.org; s.hauer@pengutronix.de
>> Cc: kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx
>> <linux-imx@nxp.com>; devicetree@vger.kernel.org
>> Subject: Re: [PATCH] ARM: dts: imx6sll-evk: add eMMC node support
>>
>> On 18/05/2023 10:47, haibo.chen@nxp.com wrote:
>>> From: Haibo Chen <haibo.chen@nxp.com>
>>>
>>> On imx6sll-evk board, eMMC is connect on the usdhc2.
>>
>>
>>> + pinctrl_usdhc2: usdhc2grp {
>>> + fsl,pins = <
>>> + MX6SLL_PAD_SD2_CMD__SD2_CMD 0x17059
>>> + MX6SLL_PAD_SD2_CLK__SD2_CLK 0x13059
>>> + MX6SLL_PAD_SD2_DATA0__SD2_DATA0 0x17059
>>> + MX6SLL_PAD_SD2_DATA1__SD2_DATA1 0x17059
>>> + MX6SLL_PAD_SD2_DATA2__SD2_DATA2 0x17059
>>> + MX6SLL_PAD_SD2_DATA3__SD2_DATA3 0x17059
>>> + MX6SLL_PAD_SD2_DATA4__SD2_DATA4 0x17059
>>> + MX6SLL_PAD_SD2_DATA5__SD2_DATA5 0x17059
>>> + MX6SLL_PAD_SD2_DATA6__SD2_DATA6 0x17059
>>> + MX6SLL_PAD_SD2_DATA7__SD2_DATA7 0x17059
>>> + MX6SLL_PAD_GPIO4_IO21__SD2_STROBE 0x13059
>>> + >;
>>> + };
>>> +
>>> + pinctrl_usdhc2_100mhz: usdhc2grp_100mhz {
>>
>> No underscores in node names. Schema expects certain pattern, so be sure to
>> test it. Please run `make dtbs_check` (see
>> Documentation/devicetree/bindings/writing-schema.rst for instructions).
>
> Hi Krzvsztof,
>
> Thanks for point that out. I will change this.
> But when I use 'make dtbs_check' to check the imx6sll-evk.dtb, though there is some issue shows up, but do not find any message point the rules "no underscores in node names".
> Anything I missing? Or this is just an implied rule？
underscores is explicit. dtc (make dtbs) with W=2 already complains
about it.
Maybe your bindings for pinctrl were not converted to DT schema? But in
such case anyway we want the same pattern for this as for other iMX schemas.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-05-30 10:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 8:47 [PATCH] ARM: dts: imx6sll-evk: add eMMC node support haibo.chen
2023-05-18 12:10 ` Krzysztof Kozlowski
2023-05-19 6:07 ` Bough Chen
2023-05-30 10:39 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=821eff3e-67e1-6398-b9a0-0de7cd149e36@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-imx@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).