From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B76FEB64DC for ; Sun, 25 Jun 2023 08:27:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231583AbjFYI1O (ORCPT ); Sun, 25 Jun 2023 04:27:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231236AbjFYI1N (ORCPT ); Sun, 25 Jun 2023 04:27:13 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D89DCE78 for ; Sun, 25 Jun 2023 01:27:11 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-98e25fa6f5bso114580166b.3 for ; Sun, 25 Jun 2023 01:27:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687681630; x=1690273630; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3iw/v8umO+caWbs4H0rT0+eQa7evscUpRFDX+BprkPc=; b=obllu29YFPFgRGd6jTkAI61xOl8UfC1YZR8FWbjOumrHWcO635wtrPIz+tiHqkpLqM +qWDbqikupQ4sSAKW79Q6GoNygV18Me4IIJJeivsLmkA8PQaUSinwO/PxJWkjcVMqPLe 0fU5ja86BkihhYN/wNcB9wqfWjKmLarHarSlPhcxklvQd6Z3GGBmFA0U4rudiHroVHlv mMmWQ8XLmK03Rn1K7sj1sd4CSblHvwRKAlie3aW3fI2E95qKVP6I30c+D/1nHDlSmYnq fLTUOogedjlI1+PXompRIBQBJam0qpEu6K8Jy8dk4AOCJwr3oSrPYHIDxpKbfxEl5DBF RveQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687681630; x=1690273630; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3iw/v8umO+caWbs4H0rT0+eQa7evscUpRFDX+BprkPc=; b=XsIiIADR7gpQWSM3WLy4Tok2Neto3eRfEWmSvcTitQpVjzUfQkAOaUsTD9MpfhzNmq +3ts+XXG7ChUIUHyQIiURXNBLYd6uyOsgbPF8E7KuYqrCTr14b3v9zs4/JyuZ6FChvxz H3iutZuTaEYWb8aAGdHTNJm20WQ6N6YeMHepPcFrgdJkQ8hcxH4T61YG27/wzVZTU1AV /2HWRKmvCi7aAG7s6Feh0ZfxPESmB67teere6fVCHJ5g3sw0HM5coYqCtSdqEKjqclO2 khiBmH+hVZxz7TWu8mbS95QsDWpDyC/3OXVL9JJgY6Y7ucexH3bPRZoIbouhlbdMcU66 OiZg== X-Gm-Message-State: AC+VfDzdOEoQU69mLVEa8s9Dnuzz8Vp2GNMlU9peJWi9+jBkWpPaz46i yTVQT6mqLmWC/6wnTbqMj7tykw== X-Google-Smtp-Source: ACHHUZ7qDM8zax2Ul6fbWYLOrxbrpdkywZBXzL9L3rr1frSL7KkwkMS2Aq5PJWKW6AttjOb3M1DTDA== X-Received: by 2002:a17:907:9303:b0:988:6bd2:b0bc with SMTP id bu3-20020a170907930300b009886bd2b0bcmr19432058ejc.2.1687681630313; Sun, 25 Jun 2023 01:27:10 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id i15-20020a17090685cf00b0098d66d03b80sm1806719ejy.212.2023.06.25.01.27.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 Jun 2023 01:27:09 -0700 (PDT) Message-ID: <82371522-c062-6fb4-7449-96edeae33a09@linaro.org> Date: Sun, 25 Jun 2023 10:27:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 3/4] media: dt-bindings: media: nxp,imx-isi: i.MX93 support Content-Language: en-US From: Krzysztof Kozlowski To: guoniu.zhou@oss.nxp.com, linux-media@vger.kernel.org, linux-imx@nxp.com, devicetree@vger.kernel.org Cc: laurent.pinchart@ideasonboard.com, mchehab@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, xavier.roumegue@oss.nxp.com, kernel@pengutronix.de, jacopo.mondi@ideasonboard.com, sakari.ailus@linux.intel.com, Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team References: <20230625080916.3553621-1-guoniu.zhou@oss.nxp.com> <20230625080916.3553621-4-guoniu.zhou@oss.nxp.com> <63eb8605-fa23-fe13-e635-1cfdbcafb5c7@linaro.org> In-Reply-To: <63eb8605-fa23-fe13-e635-1cfdbcafb5c7@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 25/06/2023 10:22, Krzysztof Kozlowski wrote: > On 25/06/2023 10:09, guoniu.zhou@oss.nxp.com wrote: >> From: "Guoniu.zhou" >> >> Add i.MX93 support since it reuse ISI which used in i.MX8M family. >> >> Signed-off-by: Guoniu.zhou > > Subject: Drop duplicated "media:" > >> --- >> Documentation/devicetree/bindings/media/nxp,imx-isi.yaml | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/media/nxp,imx-isi.yaml b/Documentation/devicetree/bindings/media/nxp,imx-isi.yaml >> index 1ce9440bde32..ddad1d8778f3 100644 >> --- a/Documentation/devicetree/bindings/media/nxp,imx-isi.yaml >> +++ b/Documentation/devicetree/bindings/media/nxp,imx-isi.yaml >> @@ -21,6 +21,7 @@ properties: >> enum: >> - fsl,imx8mn-isi >> - fsl,imx8mp-isi >> + - fsl,imx93-isi > > Imx93 is a family of devices, not specific device, so I hope you > understand that it is a bit against the recommendation of specific > compatibles and you guarantee that all devices within family will be > identical. And looking more this won't be true. There are significant differences between devices in the "imx93" family: 1. number of A55 cores and their frequency 2. Presence or not of NPU 3. MIPI-CSI or Parallel camera 4. MIPI-DSI, LVDS or Parallel display 5. 1 or 2 Gigabit Ethernet Why NXP just cannot follow standard rules here? https://elixir.bootlin.com/linux/v6.1-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst#L42 Best regards, Krzysztof