From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DB591B4F0A; Tue, 15 Oct 2024 08:12:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728979926; cv=none; b=JZ5vsoEbmMbp/9vqKcrqFqhjKBNoYP5w+QLMws3FcviixzHEupI0L2Wj1qtRdTXEi60o7I+tvYQf2w2cqFqx7YV0yzfOVY58LED6T0aTFOlWee2KkRJtGYV76VGWs0lFTUmmNRU1PO43hcaqaVvkdtYs7nkAy6/CMR1IHFiOlQE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728979926; c=relaxed/simple; bh=YKZVkzYXS0uSyFZXdKd/pqercB3r2WXi4jqpBrkhMjg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=U2rB5qTFieDc4n5QKP1+Gz5mCCFmlj4bw5fs+kt8jr9JaxUugzJhRq7Abrdlv6PtajxUez1nFkx/UrjOnISqkHqOsZFzKKqzdJoMHjJ92CkUmROIUH4cs0EV7rFBMRX6BR31pe3W6QS0XVzgLsZE+WbPyNG1SaDPP+/b3FLHUYY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lHXcpaKr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lHXcpaKr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0DFEC4CECD; Tue, 15 Oct 2024 08:11:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728979925; bh=YKZVkzYXS0uSyFZXdKd/pqercB3r2WXi4jqpBrkhMjg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=lHXcpaKrsOni6D4LKCyEP1nKmKLagR0ZbOQcquOdMCYn5IZWNfFbind+SzaX0Jnn9 L3gqnDciJlpzRoASecIPfMDKNKq2qBjLp8N5W3o4DRZHSWrIlyoecEuEFsJh3AJUDd CrICl+j+TKq7Fj9L9d9h2mcbyz1A5eH5GJqK0FoV2rGal3QI2BShREGjJQqHJwuexk lFXCxbC14BhE26CHnE1AaMj9aU8Zvk46nKh6iSdoXaziPXNR3A7QHhd+C54XURBUvz Z5UrfEZDtZc1fbLhk48jtKgSFedD+fuuuCTAvJ3Y7MI9TgErZ5h3vN6QZumopYrbo0 kgxr2cdop99Zg== Message-ID: <823f7e19-4815-44f7-aa7c-818c29892bfa@kernel.org> Date: Tue, 15 Oct 2024 10:11:56 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] pinctrl: meson: Add driver support for Amlogic A4 SoCs To: Xianwei Zhao Cc: Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Bartosz Golaszewski , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20241014-a4_pinctrl-v2-0-3e74a65c285e@amlogic.com> <20241014-a4_pinctrl-v2-2-3e74a65c285e@amlogic.com> <1c054eb4-9ac1-4965-8847-d851b9fb1131@amlogic.com> <9c7f0c20-aafe-45b2-aa3e-c2c21e3a5b71@kernel.org> <6ef6bd97-571e-4243-951f-c6704cdb2b57@amlogic.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <6ef6bd97-571e-4243-951f-c6704cdb2b57@amlogic.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 15/10/2024 10:08, Xianwei Zhao wrote: > Hi Krzysztof, > Thanks for your quick reply. > > On 2024/10/15 15:59, Krzysztof Kozlowski wrote: >> [ EXTERNAL EMAIL ] >> >> On 15/10/2024 09:54, Xianwei Zhao wrote: >>> Hi Krzysztof, >>> Thanks for your reply. >>> >>> On 2024/10/15 14:01, Krzysztof Kozlowski wrote: >>>> [ EXTERNAL EMAIL ] >>>> >>>> On Mon, Oct 14, 2024 at 05:05:52PM +0800, Xianwei Zhao wrote: >>>>> Add a new pinctrl driver for Amlogic A4 SoCs which share >>>>> the same register layout as the previous Amlogic S4. >>>>> >>>>> Signed-off-by: Xianwei Zhao >>>>> --- >>>>> drivers/pinctrl/meson/Kconfig | 6 + >>>>> drivers/pinctrl/meson/Makefile | 1 + >>>>> drivers/pinctrl/meson/pinctrl-amlogic-a4.c | 1176 ++++++++++++++++++++++++++++ >>>>> 3 files changed, 1183 insertions(+) >>>>> >>>>> diff --git a/drivers/pinctrl/meson/Kconfig b/drivers/pinctrl/meson/Kconfig >>>>> index cc397896762c..3e90bb5ec442 100644 >>>>> --- a/drivers/pinctrl/meson/Kconfig >>>>> +++ b/drivers/pinctrl/meson/Kconfig >>>>> @@ -67,6 +67,12 @@ config PINCTRL_MESON_S4 >>>>> select PINCTRL_MESON_AXG_PMX >>>>> default y >>>>> >>>>> +config PINCTRL_AMLOGIC_A4 >>>>> + tristate "Amlogic A4 SoC pinctrl driver" >>>>> + depends on ARM64 >>>>> + select PINCTRL_MESON_AXG_PMX >>>>> + default y >>>>> + >>>>> config PINCTRL_AMLOGIC_C3 >>>>> tristate "Amlogic C3 SoC pinctrl driver" >>>>> depends on ARM64 >>>>> diff --git a/drivers/pinctrl/meson/Makefile b/drivers/pinctrl/meson/Makefile >>>>> index 9e538b9ffb9b..c92a65a83344 100644 >>>>> --- a/drivers/pinctrl/meson/Makefile >>>>> +++ b/drivers/pinctrl/meson/Makefile >>>>> @@ -10,5 +10,6 @@ obj-$(CONFIG_PINCTRL_MESON_AXG) += pinctrl-meson-axg.o >>>>> obj-$(CONFIG_PINCTRL_MESON_G12A) += pinctrl-meson-g12a.o >>>>> obj-$(CONFIG_PINCTRL_MESON_A1) += pinctrl-meson-a1.o >>>>> obj-$(CONFIG_PINCTRL_MESON_S4) += pinctrl-meson-s4.o >>>>> +obj-$(CONFIG_PINCTRL_AMLOGIC_A4) += pinctrl-amlogic-a4.o >>>>> obj-$(CONFIG_PINCTRL_AMLOGIC_C3) += pinctrl-amlogic-c3.o >>>>> obj-$(CONFIG_PINCTRL_AMLOGIC_T7) += pinctrl-amlogic-t7.o >>>>> diff --git a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c >>>>> new file mode 100644 >>>>> index 000000000000..dee1ae43edb5 >>>>> --- /dev/null >>>>> +++ b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c >>>>> @@ -0,0 +1,1176 @@ >>>>> +// SPDX-License-Identifier: (GPL-2.0-only OR MIT) >>>>> +/* >>>>> + * Pin controller and GPIO driver for Amlogic A4 SoC. >>>>> + * >>>>> + * Copyright (c) 2024 Amlogic, Inc. All rights reserved. >>>>> + * Author: Xianwei Zhao >>>>> + * Huqiang Qin >>>>> + */ >>>>> + >>>>> +#include >>>> >>>> I do not see any usage of it. >>>> >>> >>> The header file "amlogic-a4-gpio.h" is used by AMLOGIC_PIN and >>> GPIO_GROUP_V2, The code used is AMLOGIC_GPIO(). >>> This is binding definition. >> >> Then all other defines are not used. AMLOGIC_GPIO is not used by DTS, so >> how is that a binding? Don't stuff random defines into the bindings. >> > > The AMlOGIC_GPIO definition depends on other definitions to be used. > It is not currently used by DTS, but will be used by other modules in > the future. You keep disagreeing, addressing only some parts and ignoring the rest. Explain me what do you bind here that you call it a "binding"? Best regards, Krzysztof