From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95DECECAAD8 for ; Wed, 31 Aug 2022 06:02:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229962AbiHaGCW (ORCPT ); Wed, 31 Aug 2022 02:02:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbiHaGCV (ORCPT ); Wed, 31 Aug 2022 02:02:21 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF9EABB92C for ; Tue, 30 Aug 2022 23:02:20 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id y10so10390369ljq.0 for ; Tue, 30 Aug 2022 23:02:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=nbGcB33f3vtSsFvUomQd2O7+yHjb/bY+6jPg//hkM20=; b=JQDQPAfJ9E9k/gZ9UxWAz78BzOxgUSk9SJBPO9GcGvxkl7m/q5jucRtpr2Xj7J52iv COILzG1zqi7xot1XoMLVfXcsJ+nezIUJtiB6JU8C2DH7zbJC2fqkbq1NS2lXbBeMnNWm HZR1fMg89rEPz19W1mXqYUe2iAwnFvEIa64Ej0npJ8nTQPyz4x8dlOAwqaZmeAOI0jWh eRWr+2zUaTSk3M5LLmPkahWkNYt/7/kDO452Fl3Z7Oh5MN9WNNBTDn/sI1vZB30qOxJp YyWauDaNk52I4pi63pkNJSQtBbUwMN0VRZdmi/G/O13lmZb5E+lx7KAiFcnL2YMQGSDR NDaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=nbGcB33f3vtSsFvUomQd2O7+yHjb/bY+6jPg//hkM20=; b=Z9mXflaEBDxab/cspkZ/z5fXc0qUUJzxf8kKYsWgAieSgWbEa8GRsCAXxpDPjAX56F 6rXloJ4QJwRpYmw5fa7d+YR8LDWgRdmTdgUiQoZF9srWvI9XNqhYfYIcNji3n8FLy/U7 a2pYeD371iCHBsuV2Bdav8PdytovoVPHUxvgQFgFxFYKFni5BfzDzZmztg6a0m7bckmI FyjOM06y+xCiEf7luLV67PIzDyu4NGV2ILNS59vow2EUm0hnVEMiJ3gevTNWTv0+sbhw aa0WVAeEreb6x2tVsUIpCf+GcW/raVUP0fZwexUNHuh97Xwog1OYyMMarIhmlTS7tLVl XTPQ== X-Gm-Message-State: ACgBeo13hECc592MqLLyUMUTpbiEaqEEwl7tNwVZKHeIdUp9tF7K1yTH MiBRxmiaVsxO/72Nb8k5Y8wV8B2OhTxvX4sk X-Google-Smtp-Source: AA6agR6WkZsu4SBuQtp7SwPb2bib2k7rEr3JJpVbNcdOjhqQLSDhhBa0hL9scYuMfjpcRFIk6H8mEw== X-Received: by 2002:a2e:3112:0:b0:24f:132a:fd71 with SMTP id x18-20020a2e3112000000b0024f132afd71mr7670629ljx.522.1661925738915; Tue, 30 Aug 2022 23:02:18 -0700 (PDT) Received: from [192.168.28.124] (balticom-73-99-134.balticom.lv. [109.73.99.134]) by smtp.gmail.com with ESMTPSA id q14-20020ac25fce000000b00492f1b2ac0bsm1867976lfg.101.2022.08.30.23.02.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Aug 2022 23:02:18 -0700 (PDT) Message-ID: <82576790-9fb0-ee1b-2308-fbe292068bd9@linaro.org> Date: Wed, 31 Aug 2022 09:02:17 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v2 2/7] dt-bindings: phy: mediatek,tphy: add property to set pre-emphasis Content-Language: en-US To: Chunfeng Yun , Vinod Koul , Rob Herring Cc: Kishon Vijay Abraham I , Krzysztof Kozlowski , Matthias Brugger , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Eddie Hung References: <20220829080830.5378-1-chunfeng.yun@mediatek.com> <20220829080830.5378-2-chunfeng.yun@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 31/08/2022 06:14, Chunfeng Yun wrote: >> These bindings are expected to be >> usable/applicable on several devices, so units, not register values >> which can change between devices, are the proper and reliable way to >> describe a feature. > I prefer to use exact level values, but not the inexact values with > units (e.g. -percent, -microvolt). What stops you from using exact values - bp? Best regards, Krzysztof