From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Stein Subject: Re: [PATCH v2 1/1] Input: gpio_keys - add device tree support for interrupt only keys Date: Wed, 12 Nov 2014 17:38:31 +0100 Message-ID: <8280855.M123yTnXfy@ws-stein> References: <1415808176-13282-1-git-send-email-alexander.stein@systec-electronic.com> <3325183.d9PtLzFMKy@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <3325183.d9PtLzFMKy@wuerfel> Sender: linux-input-owner@vger.kernel.org To: Arnd Bergmann Cc: Dmitry Torokhov , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux-input@vger.kernel.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On Wednesday 12 November 2014 17:04:57, Arnd Bergmann wrote: > On Wednesday 12 November 2014 17:02:56 Alexander Stein wrote: > > This features already exists for board config setups. Add support for > > device tree based systems. > > > > Signed-off-by: Alexander Stein > > --- > > Please note: Due to current lack of hardware I could not test it yet. V2 > > includes the changes proposed by Dmitry. > > > > Changes in v2: > > * Added device tree bindings > > * IRQ is only parsed and mapped when there is no "gpios" property > > > > Can you list one or more examples in the patch description? > Are these systems that don't expose the GPIO controller with a > standalone driver, or systems that really actually connect the > buttons to an interrupt pin? You mean a use case? I came to this situation to test interrupt polarity on a microcontroller, thus a simple /IRQ pin, no GPIO at all. So in the end I have an input just connected to an interrupt line. I noticed gpio_keys using platform data only can be used for this setup. So I added this support for device tree. Best regards, Alexander