From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 455E5C433EF for ; Wed, 13 Apr 2022 13:45:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233817AbiDMNsJ (ORCPT ); Wed, 13 Apr 2022 09:48:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229555AbiDMNsI (ORCPT ); Wed, 13 Apr 2022 09:48:08 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12A913CA56 for ; Wed, 13 Apr 2022 06:45:47 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id lc2so4011026ejb.12 for ; Wed, 13 Apr 2022 06:45:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=I4Bto3DqqlTF/cosvOuigkAD+5xRDwJMBj3EBq0sxKk=; b=aTe3y/yHMNc1zwYdJQpMlDjJYwXFpOkvDRMDjdedCXzt0LZSpSQM3zdVo6zeIhaGpM VifdlLNTc889QD5rI4K7pi6kxQ8BsesPbT3rJvj877P2tLPmWhNRhEvd95m4f8z3qkUG 0/nE8keo+2Bu+DrJ98aXf1WpfXAeyToCdybOih2NN1ereli3Duo6F87eESTG3lP6lava u8XHylWNyoXL+x8igXQvtXKSpQEbo8JwGhyx19wU69Vk3WDhLrBsLoNWOZUzJZrOzL8h /4E8FuzPr/ImgG6JIotc/fH+6kVsj6mTYJGbdiPJ4XmIC8+KI9FarS9b9cL1/PzNOxsH g83Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=I4Bto3DqqlTF/cosvOuigkAD+5xRDwJMBj3EBq0sxKk=; b=ilGUfKqEecygomsvqgbrnz0/L0sPEOsS0vZeoIS9BPxHqcXHvIiGd/NJL0iqR94955 6GL6y8abeAmFZ02kRsFSXalVFsJZ3Bqqt66sMqvq7BGcKUMVJW83mSdji+78wMZR7o1x WtIhaRGFjyAfXx3i9ER7Zv8ecG5YDod0dusnn95mnsknIn+kGE6bsGq5Dg66SVG1x+RN oXtqI0xUeMU4ISKRPDcg0O62CpGrX/d7qXcNoxp/RzFbBmRuUBDVNy1BWiLz+FXvserA 4JJeghXnr4PBx9lL2GPlTd5Y0dZR6WAKwZvhk3PiWsj31w2AppcMySSiiMGfEWislaOL XkBA== X-Gm-Message-State: AOAM531pqoUUR9pzmPBC1GbNO63eb1UMwZIfuZgxgT3hGaqlPHWwLnI0 OY5rjIE8gUDouyI9XByxyexvLA== X-Google-Smtp-Source: ABdhPJz+E7zPXrbb5FwzmNw+1pRUnIJx05GyVyN4Ng1x+UgfUNEuczCcM4XR/p/lj+PKUsh5mpaSxw== X-Received: by 2002:a17:906:9754:b0:6da:7d72:1353 with SMTP id o20-20020a170906975400b006da7d721353mr38991990ejy.273.1649857545604; Wed, 13 Apr 2022 06:45:45 -0700 (PDT) Received: from [192.168.0.205] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id l11-20020a50cbcb000000b0041d8c4290aasm1189579edi.97.2022.04.13.06.45.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Apr 2022 06:45:45 -0700 (PDT) Message-ID: <8283132d-c271-d1b8-cb28-8f95305b11ec@linaro.org> Date: Wed, 13 Apr 2022 15:45:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2] arm64: dts: imx8mm-evk: add pwm1/backlight support Content-Language: en-US To: Tommaso Merciai Cc: linux-amarula@amarulasolutions.com, Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Joakim Zhang , Li Jun , Tim Harvey , Richard Zhu , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220413125636.28650-1-tommaso.merciai@amarulasolutions.com> From: Krzysztof Kozlowski In-Reply-To: <20220413125636.28650-1-tommaso.merciai@amarulasolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 13/04/2022 14:56, Tommaso Merciai wrote: > Add pwm1/backlight support nodes for imx8mm_evk board. > Align with u-boot dts > Thank you for your patch. There is something to discuss/improve. > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi > index 6d67df7692f1..4c18f8fcd377 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi > @@ -59,6 +59,15 @@ reg_usdhc2_vmmc: regulator-usdhc2 { > enable-active-high; > }; > > + backlight: backlight { > + status = "okay"; All nodes have status=okay by default, so no need for this. > + compatible = "pwm-backlight"; > + pwms = <&pwm1 0 5000000>; > + brightness-levels = <0 255>; > + num-interpolated-steps = <255>; > + default-brightness-level = <250>; > + }; > + > ir-receiver { > compatible = "gpio-ir-receiver"; > gpios = <&gpio1 13 GPIO_ACTIVE_LOW>; > @@ -395,6 +404,12 @@ &wdog1 { > status = "okay"; > }; > > +&pwm1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_backlight>; > + status = "okay"; This is needed if the node was disabled in DTSI (I did not check it). Best regards, Krzysztof