From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FD05C433FE for ; Fri, 13 May 2022 07:57:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377972AbiEMH5i (ORCPT ); Fri, 13 May 2022 03:57:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349747AbiEMH5g (ORCPT ); Fri, 13 May 2022 03:57:36 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27E586CA96 for ; Fri, 13 May 2022 00:57:34 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id a14-20020a7bc1ce000000b00393fb52a386so6469716wmj.1 for ; Fri, 13 May 2022 00:57:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Z+VCyQ4FdNddQ9JeHnVFC+z2HG9qAdxbs5Dzgp/YOGU=; b=U7l70itwvDOp59iGQBatgtEC7/68noHv/4vGH1xx/gK7xvyggOGACYW2HTnqYKz3ee sJOFgdqbHCFjCU3aQQl/Rg1oYM5N1KLbqe1vKRIzZJVZGp8F92oIuvvKTgXHunrypO6S ario2rMzTUHJpt5W1RyDo5AEHkPMHc+amiz8oaY8qUe5AE3xTHUlsBYYKgvlD51IrLri vRObZRK8TQUiyUGNtiuAcZZd2XHd8DuG6vzyk5VAodEsSQguBUEFDQ4fWttJWbeAXFoe 1t5doi5ttGiH+QvcINZYalUci9oo4Y9W/Xu2cBhRwzX7WUqbRGIPgfJBfrb++xH3GSeH Q26A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Z+VCyQ4FdNddQ9JeHnVFC+z2HG9qAdxbs5Dzgp/YOGU=; b=rsE5wxbxi+VAm71urf8t5E1yT9XqYKVG7FayakDpLD1ttnFxI0Y1jKOrkEisROUOCx /wngLTFK6hEoeWvpi/QcUB1p5fiwVHJg/mWfLYmgeLicK5Ygu5uchzIm/BctrZT1mLiY ncsnstr5z3b2r6BAAl2ZLJ5lWyjdK9WW8kGboNO2f72zAhmVopFt5Q9V8cVs8e4s0Qom C576QakdCilzVSQ7/Bda7NFzzpn/+a2VYiQ19QiyiI1ETRtXlm1v8K1sAvl6PfnhhjDH SUtpYLCueyeQgak5yYfsKmepB2T8fwdLaKre8a1b1hc/SO+6cJjsAnPHSR57lxUg2/VM vmkQ== X-Gm-Message-State: AOAM531RvKcwbuNNVDojWNxicAY5lVc5coJi7TW11fHxHqP55XlpnWTO KK8K1JVPdmdynOLLZTtdu+9RCA== X-Google-Smtp-Source: ABdhPJy4D3xJsnTbYAm3729KW2bXLN3aezoJhW288ATXwZYtmBFLJxapQ5HevWL2cU0I7YpH37KeGw== X-Received: by 2002:a7b:c0c3:0:b0:394:4c67:b9df with SMTP id s3-20020a7bc0c3000000b003944c67b9dfmr13853307wmh.8.1652428652625; Fri, 13 May 2022 00:57:32 -0700 (PDT) Received: from [192.168.0.168] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id y11-20020adfc7cb000000b0020cf41017b4sm297862wrg.19.2022.05.13.00.57.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 May 2022 00:57:31 -0700 (PDT) Message-ID: <828bc65f-e585-0fe7-c038-c750861c9446@linaro.org> Date: Fri, 13 May 2022 09:57:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 1/3] dt-bindings: arm: qcom: Add sc7180 Chromebook board bindings Content-Language: en-US To: Douglas Anderson , Rob Herring , Bjorn Andersson Cc: Stephen Boyd , Matthias Kaehlcke , Alexandru M Stan , Rajendra Nayak , "Joseph S . Barrera III" , Julius Werner , Andy Gross , Krzysztof Kozlowski , Rob Herring , Stephen Boyd , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220512090429.1.I9804fcd5d6c8552ab25f598dd7a3ea71b15b55f0@changeid> From: Krzysztof Kozlowski In-Reply-To: <20220512090429.1.I9804fcd5d6c8552ab25f598dd7a3ea71b15b55f0@changeid> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/05/2022 18:04, Douglas Anderson wrote: > This copy-pastes compatibles from sc7180-based boards from the device > trees to the yaml file so that `make dtbs_check` will be happy. > > NOTES: > - I make no attempt to try to share an "item" for all sc7180 based > Chromebooks. Because of the revision matching scheme used by the > Chromebook bootloader, at times we need a different number of > revisions listed. > - Some of the odd entries in here (like google,homestar-rev23 or the > fact that "Google Lazor Limozeen without Touchscreen" changed from > sku5 to sku6) are not typos but simply reflect reality. > - Many revisions of boards here never actually went to consumers, but > they are still in use within various companies that were involved in > Chromebook development. Since Chromebooks are developed with an > "upstream first" methodology, having these revisions supported with > upstream Linux is important. Making it easy for Chromebooks to be > developed with an "upstream first" methodology is valuable to the > upstream community because it improves the quality of upstream and > gets Chromebooks supported with vanilla upstream faster. > > Signed-off-by: Douglas Anderson > --- > > .../devicetree/bindings/arm/qcom.yaml | 180 ++++++++++++++++++ > 1 file changed, 180 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index 5c06d1bfc046..399be67eb5d2 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -214,11 +214,191 @@ properties: > - qcom,ipq8074-hk10-c2 > - const: qcom,ipq8074 > > + # Qualcomm Technologies, Inc. SC7180 IDP > - items: > - enum: > - qcom,sc7180-idp > - const: qcom,sc7180 > > + # Google CoachZ (rev1 - 2) > + - items: > + - const: google,coachz-rev1 > + - const: google,coachz-rev2 The inverted pattern of old revision being compatible with the new one, is done on purpose? You claim here every rev1 is always compatible with rev2 ... I don't think we discussed such patterns in previous talk. I quickly went through it and there were only skuX moving around, not rev1 being newer then rev2. Best regards, Krzysztof