From: Krzysztof Kozlowski <krzk@kernel.org>
To: Tengfei Fan <quic_tengfan@quicinc.com>,
andersson@kernel.org, konrad.dybcio@linaro.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@quicinc.com
Subject: Re: [PATCH] arm64: dts: qcom: sm8550: Move some common usb node settings to SoC dtsi
Date: Mon, 13 May 2024 10:56:11 +0200 [thread overview]
Message-ID: <829162d0-2fef-4bbc-9417-13e8ca96150c@kernel.org> (raw)
In-Reply-To: <20240513084701.1658826-1-quic_tengfan@quicinc.com>
On 13/05/2024 10:47, Tengfei Fan wrote:
> All the board dts which base on SM8550 SoC dtsi refer to usb_1_dwc3_ss,
> usb_dp_qmpphy_usb_ss_in, orientation-switch and usb-role-switch, so move
> them to SoC dtsi from board dts.
That's not really a good argument. Argument is that it is a SoC property
(vs being a property of a board). Provide rationale for that. You are
moving things just because they look common, so to me it looks really
unjustified.
> OTG is default for dr_mode, so it can be dropped from board dts.
Separate patch, see submitting patches.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-05-13 8:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 8:47 [PATCH] arm64: dts: qcom: sm8550: Move some common usb node settings to SoC dtsi Tengfei Fan
2024-05-13 8:56 ` Krzysztof Kozlowski [this message]
2024-05-14 0:52 ` Tengfei Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=829162d0-2fef-4bbc-9417-13e8ca96150c@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_tengfan@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).