Re: [PATCH] arm64: dts: qcom: sm8350-sagami: Rectify GPIO keys

[Konrad Dybcio <konrad.dybcio@linaro.org>]

On 13.12.2022 12:11, Marijn Suijten wrote:
> On 2022-12-13 11:23:12, Konrad Dybcio wrote:
>>
>>
>> On 13.12.2022 10:03, Marijn Suijten wrote:
>>> On 2022-12-10 14:38:50, Konrad Dybcio wrote:
>>>> With enough pins set properly, the hardware buttons now also work
>>>> like a charm.
>>>>
>>>> Fixes: c2721b0c23d9 ("arm64: dts: qcom: Add support for Xperia 1 III / 5 III")
>>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>>
>>> Tested-by: Marijn Suijten <marijn.suijten@somainline.org> # On Xperia 5 III
>>>
>>> However I also tested this on Xperia 1 III, and...
>>>
>>>> ---
>>>>  .../qcom/sm8350-sony-xperia-sagami-pdx214.dts | 24 ++++++++++
>>>>  .../dts/qcom/sm8350-sony-xperia-sagami.dtsi   | 47 ++++++++++++++++++-
>>>>  2 files changed, 70 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx214.dts b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx214.dts
>>>> index e6824c8c2774..6fa830bdc6bd 100644
>>>> --- a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx214.dts
>>>> +++ b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx214.dts
>>>> @@ -10,6 +10,20 @@
>>>>  / {
>>>>  	model = "Sony Xperia 5 III";
>>>>  	compatible = "sony,pdx214-generic", "qcom,sm8350";
>>>> +
>>>> +	gpio-keys {
>>>> +		pinctrl-names = "default";
>>>> +		pinctrl-0 = <&focus_n &snapshot_n &vol_down_n &g_assist_n>;
>>>> +
>>>> +		key-google-assist {
>>>> +			label = "Google Assistant Key";
>>>> +			gpios = <&pm8350_gpios 9 GPIO_ACTIVE_LOW>;
>>>> +			linux,code = <KEY_LEFTMETA>;
>>>> +			debounce-interval = <15>;
>>>> +			linux,can-disable;
>>>> +			gpio-key,wakeup;
>>>> +		};
>>>> +	};
>>>
>>> ... please move this to board DTS.  Xperia 1 III would also like to have
>>> it mapped.  Downstream DT indicates, and my local testing confirms, that
>>> it is identical to Xperia 5 III (i.e. common to the Sagami board).
>>>
>>> The other buttons work great on both devices!
>> While I'd agree that having it like that would be nice for completeness,
>> it's:
>>
>> - not necessary, as the button is not physically there, so the user will
>> never come into contact with it
> 
> I have the device in my hand right now and, unless I take an angle
> grinder to it, it has this button.
> 
> How else did you expect me to successfully test it?
> 
> Maybe you are confused with Xperia 1 IV, which does _not_ have the
> button.  Nor does Xperia 1 II, for that matter.
Lol yes I did, will send a v2..

Konrad
> 
> - Marijn
> 
>> - it will leak power, the plan is to park all unused pins after we get
>> "good enough" support for our devices (not now, so as not to mess with
>> ourselves in the dev process)
>>
>> Konrad