Re: [PATCH 2/2] arm64: dts: meson: add support for BananaPi M2S variants

Krzysztof Kozlowski
2023-03-05T13:31:05Z

On 05/03/2023 14:20, Christian Hewitt wrote:
> BananaPi M2S ships in Amlogic S922X and A311D variants with the
> following common specifications:
>
(...)

> +
> + leds {
> + compatible = "gpio-leds";
> +
> + blue {

led-0

Does not look like you tested the DTS against bindings. Please run `make
dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
for instructions).

> + color = <LED_COLOR_ID_BLUE>;
> + function = LED_FUNCTION_STATUS;
> + gpios = <&gpio_ao GPIOAO_7 GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "heartbeat";
> + };
> +
> + green {

led-1

> + color = <LED_COLOR_ID_GREEN>;
> + function = LED_FUNCTION_STATUS;
> + gpios = <&gpio_ao GPIOAO_2 GPIO_ACTIVE_LOW>;
> + };

Best regards,
Krzysztof