Re: [PATCH 2/2] arm64: dts: meson: add support for BananaPi M2S variants

Christian Hewitt
2023-03-05T14:31:20Z

> On 5 Mar 2023, at 6:15 pm, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
>
> On 05/03/2023 14:47, Christian Hewitt wrote:
>>
>>> On 5 Mar 2023, at 5:30 pm, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
>>>
>>> On 05/03/2023 14:20, Christian Hewitt wrote:
>>>> BananaPi M2S ships in Amlogic S922X and A311D variants with the
>>>> following common specifications:
>>>>
>>> (...)
>>>
>>>> +
>>>> + leds {
>>>> + compatible = "gpio-leds";
>>>> +
>>>> + blue {
>>>
>>> led-0
>>>
>>> Does not look like you tested the DTS against bindings. Please run `make
>>> dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
>>> for instructions).
>>
>> I’m building everything in a cross-compile build system that doesn’t allow
>> this to be done without a problem amount of hoop jumping. I need to work on
>> another arrangement to do this testing (work-in-progress). Thanks for the
>
> Cross compiling kernel and running this (also as cross compiled) is
> trivial, so what exactly stops you? Packaging kernel for your system
> (e.g. Yocto) is different topic, but that's final step, not necessary
> for development of DTS.

I’m reasonably competent within the constraints of the distro build-system
environment that I use and know. I’m very lacking in knowledge if you step
outside that. It’s mostly an old-dog/new-trick problem, and something I do
need to improve upon (not a good excuse, I know).

Christian