From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: Rob Herring <robh+dt@kernel.org>,
Jon Hunter <jonathanh@nvidia.com>,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/7] clocksource: Add Tegra186 timers support
Date: Fri, 3 Apr 2020 23:45:04 +0300 [thread overview]
Message-ID: <82a08b57-c151-daf8-0719-1034be07538c@gmail.com> (raw)
In-Reply-To: <20200403202209.299823-3-thierry.reding@gmail.com>
03.04.2020 23:22, Thierry Reding пишет:
...
> +config TEGRA186_TIMER
> + tristate "NVIDIA Tegra186 timer driver"
> + depends on ARCH_TEGRA || COMPILE_TEST
> + depends on WATCHDOG && WATCHDOG_CORE
> + help
> + Enables support for the timers and watchdogs found on NVIDIA
> + Tegra186 and later SoCs.
Personally, I'd like to see this in drivers/watchdog/ because I've seen
cases where subsys maintainers are doing bulk-changes to drivers and
missing those that reside outside of the subsys directory.
But, that's not to me to decide, so I don't really mind.
...
> +static void tegra186_wdt_enable(struct tegra186_wdt *wdt)
> +{
> + struct tegra186_timer *tegra = wdt->tmr->parent;
> + u32 value;
> +
> + /* unmask hardware IRQ, this may have been lost across powergate */
> + value = TKEIE_WDT_MASK(wdt->index, 1);
> + writel(value, tegra->regs + TKEIE(wdt->tmr->hwirq));
Perhaps this one also could be relaxed, for consistency. Sorry for
missing it in v2 :)
next prev parent reply other threads:[~2020-04-03 20:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 20:22 [PATCH v3 0/7] clocksource: Add NVIDIA Tegra186 timers support Thierry Reding
2020-04-03 20:22 ` [PATCH v3 1/7] dt-bindings: timer: Add bindings for NVIDIA Tegra186 timers Thierry Reding
2020-04-14 18:10 ` Rob Herring
2020-04-03 20:22 ` [PATCH v3 2/7] clocksource: Add Tegra186 timers support Thierry Reding
2020-04-03 20:45 ` Dmitry Osipenko [this message]
2020-04-03 20:51 ` Dmitry Osipenko
2020-04-03 21:06 ` Dmitry Osipenko
2020-04-03 20:58 ` Dmitry Osipenko
2020-04-03 20:22 ` [PATCH v3 3/7] arm64: tegra: Order nodes by unit-address on Tegra194 Thierry Reding
2020-04-03 20:22 ` [PATCH v3 4/7] arm64: tegra: Add native timer support on Tegra186 Thierry Reding
2020-04-03 20:22 ` [PATCH v3 5/7] arm64: tegra: Enable native timers on Jetson TX2 Thierry Reding
2020-04-03 21:11 ` Dmitry Osipenko
2020-04-03 20:22 ` [PATCH v3 6/7] arm64: tegra: Add native timer support on Tegra194 Thierry Reding
2020-04-03 20:22 ` [PATCH v3 7/7] arm64: tegra: Enable native timers on Jetson AGX Xavier Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82a08b57-c151-daf8-0719-1034be07538c@gmail.com \
--to=digetx@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).