From: Florian Fainelli <f.fainelli@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>,
linux-arm-kernel@lists.infradead.org,
"Kishon Vijay Abraham I" <kishon@ti.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
"Scott Branden" <sbranden@broadcom.com>,
"Jon Mason" <jonmason@broadcom.com>,
"Ray Jui" <rjui@broadcom.com>,
"Yendapally Reddy Dhananjaya Reddy"
<yendapally.reddy@broadcom.com>,
"Rob Herring" <robh+dt@kernel.org>,
bcm-kernel-feedback-list@broadcom.com,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH for-4.11 1/2] Revert "phy: Add USB3 PHY support for Broadcom NSP SoC"
Date: Wed, 8 Feb 2017 15:32:20 -0800 [thread overview]
Message-ID: <82b47a03-c41b-378b-2d7c-f263eff514a9@gmail.com> (raw)
In-Reply-To: <20170208233023.31922-1-zajec5@gmail.com>
On 02/08/2017 03:30 PM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> This reverts commit d7bc1a7d41bf ("phy: Add USB3 PHY support for
> Broadcom NSP SoC") as we already have driver for this PHY (shared by NS
> and NSP). It was added in commit e5666281d9ea ("phy: bcm-ns-usb3: new
> driver for USB 3.0 PHY on Northstar").
>
> Instead of adding separated driver & duplicating code we should work on
> improving existing (old) one. Thanks to work done by Broadcom we know
> there is MDIO bus we weren't aware of & we know register names which
> makes initialization more clear. This is very valuable info and we
> should work on using it in existing driver afterwards.
Should not we first extend the old driver to support NSP and then revert
d7bc1a7d41bf ("phy: Add USB3 PHY support for Broadcom NSP SoC")?
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2017-02-08 23:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 23:30 [PATCH for-4.11 1/2] Revert "phy: Add USB3 PHY support for Broadcom NSP SoC" Rafał Miłecki
[not found] ` <20170208233023.31922-1-zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-02-08 23:30 ` [PATCH for-4.11 2/2] Revert "dt-bindings: phy: Add documentation for NSP USB3 PHY" Rafał Miłecki
2017-02-10 0:27 ` Jon Mason
[not found] ` <20170208233023.31922-2-zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-02-10 0:30 ` Jon Mason
2017-02-15 23:04 ` Rob Herring
2017-02-08 23:32 ` Florian Fainelli [this message]
[not found] ` <82b47a03-c41b-378b-2d7c-f263eff514a9-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-02-08 23:36 ` [PATCH for-4.11 1/2] Revert "phy: Add USB3 PHY support for Broadcom NSP SoC" Jon Mason
2017-02-08 23:39 ` Rafał Miłecki
2017-02-08 23:44 ` Florian Fainelli
2017-02-09 7:21 ` Rafał Miłecki
2017-02-09 19:18 ` Florian Fainelli
2017-02-10 0:27 ` Jon Mason
[not found] ` <CAC3K-4o+ARP=_hg2XQszQh6v+ySpubyKRspCF38SLUUx4mXQDA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-03-08 12:13 ` Rafał Miłecki
2017-03-08 12:26 ` Kishon Vijay Abraham I
[not found] ` <58BFF88F.8080008-l0cyMroinI0@public.gmane.org>
2017-03-09 8:11 ` Kishon Vijay Abraham I
2017-03-09 9:17 ` Rafał Miłecki
[not found] ` <b2bdc1a7-4e5c-a13e-0cda-c90759d7308c-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-02-10 0:29 ` Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82b47a03-c41b-378b-2d7c-f263eff514a9@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=jonmason@broadcom.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=rafal@milecki.pl \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=yendapally.reddy@broadcom.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).