From: Marc Gonzalez <mgonzalez@freebox.fr>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
Arnaud Vrac <avrac@freebox.fr>,
Pierre-Hugues Husson <phhusson@freebox.fr>
Subject: Re: [PATCH 3/4] drm: bridge: simple-bridge: use only devm* in probe
Date: Tue, 18 Jun 2024 13:37:15 +0200 [thread overview]
Message-ID: <82c982ad-20ae-4f36-8797-440828317d32@freebox.fr> (raw)
In-Reply-To: <deirqqoap7ta3iwmmvg6uxzalfe22yirjp6et2a74ffh5ybi64@vekr6l7sl22c>
On 18/06/2024 00:28, Dmitry Baryshkov wrote:
> On Mon, Jun 17, 2024 at 06:03:01PM GMT, Marc Gonzalez wrote:
>
>> Once probe uses only devm functions, remove() becomes unnecessary.
>
> Breves vibrantesque sententiae
>
> With the hope of getting an expanded commit message:
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
I'm not quite sure what else to say.
Using only devm* functions in probe, the remove() callback is
no longer needed, since devm unwind will free all resources.
Is that better?
NB: this patch is not *required* but I thought "might as well
change it while I'm in the code".
Regards
next prev parent reply other threads:[~2024-06-18 11:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 16:02 [PATCH 0/4] Basic support for TI TDP158 Marc Gonzalez
2024-06-17 16:02 ` [PATCH 1/4] dt-bindings: display: simple-bridge: add ti,tdp158 Marc Gonzalez
2024-06-17 16:18 ` Conor Dooley
2024-06-17 19:37 ` Dmitry Baryshkov
2024-06-18 8:15 ` Maxime Ripard
2024-06-17 16:03 ` [PATCH 2/4] drm: bridge: simple-bridge: use dev pointer in probe Marc Gonzalez
2024-06-17 19:53 ` Dmitry Baryshkov
2024-06-18 8:16 ` Maxime Ripard
2024-06-17 16:03 ` [PATCH 3/4] drm: bridge: simple-bridge: use only devm* " Marc Gonzalez
2024-06-17 22:28 ` Dmitry Baryshkov
2024-06-18 11:37 ` Marc Gonzalez [this message]
2024-06-18 17:24 ` Dmitry Baryshkov
2024-06-17 16:03 ` [PATCH 4/4] drm: bridge: simple-bridge: add tdp158 support Marc Gonzalez
2024-06-17 22:33 ` Dmitry Baryshkov
2024-06-18 11:48 ` Marc Gonzalez
2024-06-18 17:25 ` Dmitry Baryshkov
2024-06-18 13:07 ` [PATCH 0/4] Basic support for TI TDP158 Marc Gonzalez
2024-06-18 14:36 ` Maxime Ripard
2024-06-18 16:17 ` Marc Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82c982ad-20ae-4f36-8797-440828317d32@freebox.fr \
--to=mgonzalez@freebox.fr \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=avrac@freebox.fr \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=phhusson@freebox.fr \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox