Re: [PATCH v7 3/3] arm64: Add architecture support for PCI

Liviu Dudau
2014-03-17T18:05:25Z

On Mon, Mar 17, 2014 at 05:38:21PM +0000, Catalin Marinas wrote:
> On Fri, Mar 14, 2014 at 06:05:27PM +0000, Liviu Dudau wrote:
> > On Fri, Mar 14, 2014 at 05:38:08PM +0000, Arnd Bergmann wrote:
> > > On Friday 14 March 2014, Catalin Marinas wrote:
> > > > On Fri, Mar 14, 2014 at 03:34:18PM +0000, Liviu Dudau wrote:
> > > > > --- /dev/null
> > > > > +++ b/arch/arm64/kernel/pci.c
> > > > [...]
> > > > > +int pci_register_io_range(phys_addr_t address, resource_size_t size)
> > > > [...]
> > > > > +unsigned long pci_address_to_pio(phys_addr_t address)
> > > > [...]
> > > > > +void pcibios_fixup_bus(struct pci_bus *bus)
> > > > [ actually most of this file ]
> > > >
> > > > Maybe it was raised before already but can we have __weak generic
> > > > definitions of these functions? They don't seem to be arm64 specific in
> > > > any way.
> [...]
> > Catalin, if you are happy to ask for ACKs from all arch maintainers that might get
> > affected by our custom version of pci_address_to_pio() before you can pull PCI support
> > for arm64 then I can propose a new patchset.
>
> You don't need to change the other architectures, that's the point of a
> __weak definition, it will be automatically overridden. If you want, you
> can even place a GENERIC_PCI or whatever config option that is only
> selected by arm64 for the time being.

pci_address_to_pio() is alread __weak. My patch was adding the arm64 version of it. Adding
an #ifdef GENERIC_PCI to the __weak implementation is not just a temporary solution.
We would still have to keep some sort of #ifdef around in the function as x86
will never pickup our version. Regardless, the list of people that would need to ACK that
change will increase, right?

Best regards,
Liviu

>
> --
> Catalin
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯