From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEFAEC433F5 for ; Thu, 14 Apr 2022 14:44:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237114AbiDNOqY (ORCPT ); Thu, 14 Apr 2022 10:46:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348094AbiDNOMa (ORCPT ); Thu, 14 Apr 2022 10:12:30 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7882457AA for ; Thu, 14 Apr 2022 07:04:12 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id i82-20020a1c3b55000000b0038ccb70e239so1398703wma.3 for ; Thu, 14 Apr 2022 07:04:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=sGaJ99RtJ+dYNj0rZGnHuhh5oNaX0IriWU/lV+rJbzI=; b=UZ9NGDgJnUPaHnWlhjnMgl0KKbYa6sjX3j1ma6UvRTcZOKuUjs2dQZ0PCn8zt0/vPm 6axL2/f7uOg3bwM54sz1mSpaK7ck8Zyh+xK0UKxmrGT+P3r5NLgHtTObp7LHPHMDhkJq NhLutWNr5BjsPY8I8jh1uTMMw48zR2rSpJZxfBxXqghLWzGOPus6i/u/vl0mvTa2c9cf yUmDoZMrSGDZI7OD6hmZwgGtdiffvu5ckVdbG+aBan4wNjnDEH5L/D0IbcmByuz0YW8g FNU9NY1j7z+z0qC5eB2IKUwyGP9+VjexJHVQP+GOQc6vG+8/r3M7NludXIN4HSjZgGX+ 4J1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=sGaJ99RtJ+dYNj0rZGnHuhh5oNaX0IriWU/lV+rJbzI=; b=b/gmg5UgTzRrOXeyKemkT9/gc+LhvJ2bUeN8A0m4RPzykGPMISGYss+KZOrqfozvtg ddyS2KtaEoKeWDb3x3orH++XJO06Xujc74uIJAc0hrP52hPqiA89VcxBljEotPZBX1ki 2IYhCCj6XKeETYuIG8uBD/+sEqv8Bg5tsHSHIExuKXcjUK0bIDHd8uf9xNzs5UV4Z02J hgSY50PplwzcsgyLd0RZuGca21AZUFmpAA5GYXLa/ise/jgMNeWgZjsSBUl6xOmYFZrI HRs4vW86CR0lDtijH3Kp5vRfc6mnd4tneAVQOnzpO1K344TH9sdG5SxpueGPj7TF48nh 7c/g== X-Gm-Message-State: AOAM532rmTQ5MTFTrA2EEfBaai1nrpeXP2nKK4v1nijjO9Lghhier7hX HlyKwH7eQY3zQAOmUBOJZl33dg== X-Google-Smtp-Source: ABdhPJxAQNUpOt/pOTTkq9icbx/O5JDFs7gYWRn60EyCC7m3uAIlzNlFPgi7g5hEIta6BxLvgi7RJg== X-Received: by 2002:a05:600c:4f91:b0:38f:fba2:3ccb with SMTP id n17-20020a05600c4f9100b0038ffba23ccbmr1332307wmq.125.1649945051428; Thu, 14 Apr 2022 07:04:11 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id n8-20020a05600c4f8800b0038eb596ab10sm6114089wmq.2.2022.04.14.07.04.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Apr 2022 07:04:10 -0700 (PDT) Message-ID: <831e3857-9ee7-c760-ef2e-3b235b57b907@linaro.org> Date: Thu, 14 Apr 2022 15:04:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v3 2/2] media: i2c: imx412: Add bulk regulator support Content-Language: en-US To: Sakari Ailus Cc: paul.j.murphy@intel.com, daniele.alessandrelli@intel.com, mchehab@kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, robert.foss@linaro.org, hfink@snap.com, jgrahsl@snap.com, dmitry.baryshkov@linaro.org, vladimir.zapolskiy@linaro.org References: <20220414124505.1329295-1-bryan.odonoghue@linaro.org> <20220414124505.1329295-3-bryan.odonoghue@linaro.org> <39cae749-67ef-13d7-2648-01c6e9603887@linaro.org> From: Bryan O'Donoghue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 14/04/2022 14:56, Sakari Ailus wrote: > On Thu, Apr 14, 2022 at 02:44:00PM +0100, Bryan O'Donoghue wrote: >> On 14/04/2022 14:00, Sakari Ailus wrote: >>>> ret = clk_prepare_enable(imx412->inclk); >>>> if (ret) { >>>> + regulator_bulk_disable(imx412->num_supplies, >>>> + imx412->supplies); >>> As the function already has an error handling section using labels, this >>> should go there as well. >>> >> Are you asking to move regulator_bulk_disable() to error_reset ? > > No. You'll need another label. > Hmm. I think another label is not required, have a look at V4.