From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 317EEC4332F for ; Thu, 29 Sep 2022 11:31:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235029AbiI2Lbc (ORCPT ); Thu, 29 Sep 2022 07:31:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235178AbiI2Lba (ORCPT ); Thu, 29 Sep 2022 07:31:30 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 152CF13D1C5 for ; Thu, 29 Sep 2022 04:31:28 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id a3so1767412lfk.9 for ; Thu, 29 Sep 2022 04:31:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=cNbvBpJQ8ytsaQU5m5L7uhDa6I7TxFtFcCoKpSC+nFg=; b=W1V/Q3GOj1L0xzmOMHfldXmwA0xiI87MV8akcr2iy7CI8ojb02e3ycmVFQiQ4pe6Tz HSD/tNHZSJceUOQJ3KZcMLEEXn+wCM5dDMCaAsHY7TSLk+6PRTT+z+Vc1tBfgiegpqiy M9PmBEa5As7rJ1ZwXFkQMcSvRGd48NSimRi6n7yFOTE+oncYUHefUqhShvDIGjxmPUC/ zBBDeUOHSC33O9mzMbTOtTOGLn49o40BE1MmJVdHIHmFxSp18MRYADUPj3tEm2IvjtnC vcYEA0/xhwSVeIR5cONyJyv4jNmIYyGCaO2LnJBvgHTqhJzjSP5yKS1b1G9lIJJ68yTI +z+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=cNbvBpJQ8ytsaQU5m5L7uhDa6I7TxFtFcCoKpSC+nFg=; b=PSjmAw/e0cqqtw2A7Fykiu2BX9yA1OsTgyl5vhnB8j9d0KnaINONaRyVLkAggzXBv1 ub17GiQCNimAmNca4u8n1IFQwx8Lh3T4jXhv/qUfXycxwJ9LcyqgnSItzAP9DUQYMcwl pWf4AVD/731VQAMmTTzybNUek/fqSgu2iKDnnHPX+S9VeAgoAQaeP+kKVKdMLdKALLJJ akn3m95Km0OoxAnqvGzXEwo3xGhCsbyKIeiLLAX1+knzXgQvY5ggItDvZcalUSjOxy/+ EtjchDWz//9DOhFqTkL1NXrtqRwmXLjUCh7tMFF9dKSqEJ9RL+VqnFsKXIu0oPLFx8pg 2YrA== X-Gm-Message-State: ACrzQf2gxbLpSINM6CGIqmZeRsP/lkeAodRKBsiq526jcVN59x03CGgP YvtNC9xHbAbSswzJBtUWjJoBDQ== X-Google-Smtp-Source: AMsMyM7/7burRUOysN5RGdTSdq7pYL2TS5pJVCGWHCWIFB0cZWr4oLtY45IVvxvQJsFPk52kWZElFw== X-Received: by 2002:a05:6512:511:b0:4a1:d9f3:ea10 with SMTP id o17-20020a056512051100b004a1d9f3ea10mr1255898lfb.555.1664451086461; Thu, 29 Sep 2022 04:31:26 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id v16-20020a056512049000b0048aef1abb08sm756680lfq.297.2022.09.29.04.31.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Sep 2022 04:31:26 -0700 (PDT) Message-ID: <8322b054-27c4-32c5-53a4-abb40845d66c@linaro.org> Date: Thu, 29 Sep 2022 13:31:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 1/2] dt-bindings: power: supply: Add Richtek RT9467 battery charger Content-Language: en-US To: ChiaEn Wu , sre@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: chiaen_wu@richtek.com, cy_huang@richtek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org References: <2590163cabaef9ece537c5453eeef9f259e56cef.1664475743.git.chiaen_wu@richtek.com> From: Krzysztof Kozlowski In-Reply-To: <2590163cabaef9ece537c5453eeef9f259e56cef.1664475743.git.chiaen_wu@richtek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 29/09/2022 12:37, ChiaEn Wu wrote: > From: ChiaEn Wu > > Add bindings for the Richtek RT9467 battery charger. > > Co-developed-by: ChiYuan Huang > Signed-off-by: ChiYuan Huang > Signed-off-by: ChiaEn Wu > --- Thank you for your patch. There is something to discuss/improve. > + > + reg: > + maxItems: 1 > + > + wakeup-source: true > + > + interrupts: > + maxItems: 1 > + > + charge-enable-gpios: > + description: GPIO is used to turn on and off charging. > + maxItems: 1 > + > + usb-otg-vbus-regulator: > + type: object > + description: OTG boost regulator. > + unevaluatedProperties: false > + $ref: /schemas/regulator/regulator.yaml# > + > + properties: > + enable-gpios: > + maxItems: 1 maxItems are coming from gpio-consumer-common.yaml, so just enable-gpios: true > + > +required: > + - compatible > + - reg > + - wakeup-source > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + rt9467@5b { Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "richtek,rt9467-charger"; > + reg = <0x5b>; > + wakeup-source; > + interrupts-extended = <&gpio_intc 32 IRQ_TYPE_LEVEL_LOW>; > + charge-enable-gpios = <&gpio26 1 0>; Use defines for GPIO flags. > + > + rt9467_otg_vbus: usb-otg-vbus-regulator { > + regulator-name = "rt9467-usb-otg-vbus"; > + regulator-min-microvolt = <4425000>; > + regulator-max-microvolt = <5825000>; > + regulator-min-microamp = <500000>; > + regulator-max-microamp = <3000000>; > + }; > + }; > + }; Best regards, Krzysztof