From: Krzysztof Kozlowski <krzk@kernel.org>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Rakesh Kota <rakesh.kota@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Sebastian Reichel <sre@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
jishnu.prakash@oss.qualcomm.com, kamal.wadhwa@oss.qualcomm.com
Subject: Re: [PATCH 1/2] dt-bindings: soc: qcom: pmic-glink: Document batteryless property
Date: Tue, 19 May 2026 12:49:21 +0200 [thread overview]
Message-ID: <832d31a1-60fc-4af1-aa8e-8b417fce206c@kernel.org> (raw)
In-Reply-To: <ef1edc3b-a34a-48cd-bf68-572fa57babee@oss.qualcomm.com>
On 19/05/2026 12:47, Konrad Dybcio wrote:
> On 5/19/26 12:35 PM, Krzysztof Kozlowski wrote:
>> On Tue, May 19, 2026 at 01:55:26PM +0530, Rakesh Kota wrote:
>>>
>>>> And isn't lack of monitored battery property enough to indicate that?
>>>
>>> Regarding monitored-battery — its absence alone isn't sufficient. The
>>> BATT_ID line on debug boards is pulled to ~10kΩ, which is used during
>>> development phase where some battery properties are still present. The
>>> same ~10kΩ value is also used on some genuinely battery-less production
>>> platforms where no battery properties exist, making auto-detection
>>> unreliable. Hence the need for an explicit DT property to identify
>>> hardware platforms where no battery populated.
>>
>> I don't understand this logic. So you claim you have debug boards which
>> do not have battery, but define monitored-battery? Then these are wrong
>> and fix them first.
>
> I don't think any pmic-glink device defines a monitored-battery node
>
> The firmware is in full control of the battery charger (maybe with the
> exception of some coordination with ECs on some laptops and maybe if
> the vendor has some very in-depth custom charging hw, but that's
> educated guesses)
If you are saying that monitored-battery is not applicable here, then it
feels like "battery-less" is not applicable as well.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-05-19 10:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 13:49 [PATCH 0/2] qcom_battmgr: Add batteryless DC-adapter MAINS support Rakesh Kota
2026-05-18 13:49 ` [PATCH 1/2] dt-bindings: soc: qcom: pmic-glink: Document batteryless property Rakesh Kota
2026-05-18 13:59 ` sashiko-bot
2026-05-19 7:09 ` Rakesh Kota
2026-05-18 15:27 ` Krzysztof Kozlowski
2026-05-19 8:25 ` Rakesh Kota
2026-05-19 10:35 ` Krzysztof Kozlowski
2026-05-19 10:47 ` Konrad Dybcio
2026-05-19 10:49 ` Krzysztof Kozlowski [this message]
2026-05-18 13:49 ` [PATCH 2/2] power: supply: qcom_battmgr: Add support batteryless boards as MAINS Rakesh Kota
2026-05-18 15:10 ` sashiko-bot
2026-05-19 6:55 ` Rakesh Kota
2026-05-18 14:36 ` [PATCH 0/2] qcom_battmgr: Add batteryless DC-adapter MAINS support Konrad Dybcio
2026-05-19 6:59 ` Rakesh Kota
2026-05-19 10:58 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=832d31a1-60fc-4af1-aa8e-8b417fce206c@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jishnu.prakash@oss.qualcomm.com \
--cc=kamal.wadhwa@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rakesh.kota@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox