From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4092C6379F for ; Tue, 7 Feb 2023 13:00:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231223AbjBGNAW (ORCPT ); Tue, 7 Feb 2023 08:00:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231621AbjBGNAS (ORCPT ); Tue, 7 Feb 2023 08:00:18 -0500 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A54439CE3 for ; Tue, 7 Feb 2023 05:00:00 -0800 (PST) Received: by mail-wm1-x329.google.com with SMTP id o36so10978578wms.1 for ; Tue, 07 Feb 2023 05:00:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=b8356G0ixrthqJeN28CG9y80D2Z75FJcc11F+7VGnio=; b=S3wzBB5NFcZmPn5qH9zTuYEcJa1RBcpsC4cQ+IpUqG5G8wDtO/rNhgluXYICZnpa2E h0H191B53OVYM0GecQv2GO5AzzI3KrpV20JXyjN6Bwd9qNhYaOEVyIaL8NkmayyZylxY CXt/z/fxlf5yd9ZGyJW66nDvfwqIFU5Ehams64KFxym9mhOXSredFEFxePTVDRSlcJ7T rsN16PTsHp0cjCmKdEjdpIkCHxK7daJIDFAdueUYxy/5n8RJDwNdBxMOmPTJlA6HA67e muKjYCkA8+rvSX5hvrYiL3UzvL2iY2cUdJeLrSzjP32Taaup9y9JqoJ7+q/1/HwsA8h0 wEUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=b8356G0ixrthqJeN28CG9y80D2Z75FJcc11F+7VGnio=; b=ryyfbcC5f30ftQh+Eb1BQF7h2tFIHNMJhFDlM/fdOMJqOJVjF14gAQCRIi4Zywc3Et kg62w53pwL14+si/APSOeUILzU1hfsddl3Q2RNVyv06N8qBB4Z860MvqWeR2I2unpkhc aAimCjdExjmU/6ATdX0ufXq3J38mHL6NhZMnUClZbiv6hQqpP5vlLI9h+OhSoYKqYhlW 8E1xLH8vQxLDFc4VpJKABzE6hpjz5rFW0PYS0xL8yT6fmGZe5iCUYvx9UaCdBvHocl9S KG3m9v3t0XV5EJMazom/bLRQxwyaxGkeIOg2lbsVaDuw/sKYfmbQ1I58uwEI1P8IFzsq +8kQ== X-Gm-Message-State: AO0yUKVOJKPND8fwUTTbnGToI/h86AHTM/WolybDdYlDYVLpHRspN4WT kqY4A0dpAdL/BuXNTSj/bvd6qw== X-Google-Smtp-Source: AK7set+FOWndI8Z6n4n8EYKXWdmdd4I/2cAiD7qwm96lBb0MjLTo70rwDS+uJ5+vgp2K0dZOmLirJQ== X-Received: by 2002:a05:600c:3412:b0:3e0:481:c88f with SMTP id y18-20020a05600c341200b003e00481c88fmr3759507wmp.30.1675774799551; Tue, 07 Feb 2023 04:59:59 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id j10-20020a05600c1c0a00b003dd1c45a7b0sm15203438wms.23.2023.02.07.04.59.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Feb 2023 04:59:59 -0800 (PST) Message-ID: <8337e4a3-a25b-aa1a-9409-6fe1fb4ea84e@linaro.org> Date: Tue, 7 Feb 2023 13:59:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCHv2 2/4] wiegand: add Wiegand bus driver Content-Language: en-US To: Greg KH , Zhou Furong Cc: =?UTF-8?Q?Martin_Za=c5=a5ovi=c4=8d?= , linux-kernel@vger.kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, martin.petersen@oracle.com, beanhuo@micron.com, arnd@arndb.de, avri.altman@wdc.com, iwona.winiarska@intel.com, fmdefrancesco@gmail.com, dipenp@nvidia.com, ogabbay@kernel.org, bvanassche@acm.org, mathieu.poirier@linaro.org, yangyicong@hisilicon.com, dan.j.williams@intel.com, devicetree@vger.kernel.org, linus.walleij@linaro.org References: <20230202143305.21789-1-m.zatovic1@gmail.com> <20230202143305.21789-3-m.zatovic1@gmail.com> <581353bc-cc2c-295b-1f9a-04bcf705261b@linux.intel.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 07/02/2023 07:08, Greg KH wrote: > On Tue, Feb 07, 2023 at 08:36:47AM +0800, Zhou Furong wrote: >> >> >> On 2023/2/6 18:26, Greg KH wrote: >>> On Mon, Feb 06, 2023 at 05:49:44PM +0800, Zhou Furong wrote: >>>> >>>>>> + >>>>>> +#include >>>>>> +#include >>>>>> +#include >>>>>> +#include >>>>>> +#include >>>>>> +#include >>>>>> +#include >>>>>> +#include >>>>>> +#include >>>>>> + >>>> >>>> please order headers >>> >>> Why? What order? For what gain > >> >> If all header file ordered in alphabet, it will be easy to find if a header >> file has been included or not when header file list is long. > > That's what search in your editor is for :) > > This is not a real problem with this code, sorry. I would say the only argument is reducing conflicts for simultaneous edits, mostly when adding new headers. If everyone add at the end, you get conflicts which could not happen if entries were ordered. Another thing is that actual order allows easier to spot duplicates or unneeded headers by looking. At least to me it's easier to read. Best regards, Krzysztof