From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAA79C6FA83 for ; Sun, 11 Sep 2022 11:28:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230089AbiIKL2B (ORCPT ); Sun, 11 Sep 2022 07:28:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229992AbiIKL2A (ORCPT ); Sun, 11 Sep 2022 07:28:00 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3206D2E6A2 for ; Sun, 11 Sep 2022 04:27:59 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id k10so10403604lfm.4 for ; Sun, 11 Sep 2022 04:27:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=wODXrUGa3xJje0kIbd8qZg/z/wc1dTw39zG2Qx5AyhI=; b=AkNi3/z9b9CHqnJdIfnIBVDDMABspoLSeuVjYlbR5LJn7OoLnkReI5eVApXBhxQD++ BhRUBswOj2pgzEAfLQsiwAbTtVPs+nIoxM3nLwrOI7K4s58D4N/PUhHrvjWyhjzkJnrd 0kU/zGfsf3UoSVxYCToP69gSe0n7Hmcy8moTgbE+0WxvdjlExnPsvvFdZOCb98B09HbX baoKiktVRdbWQVfrNqQ6t+ndzbGfPmau2hvJVYMpzvH2k79I4rxGITYm0IrcHrE5B43N tdfZ7JJI9zQNWZQk1EDARNlERktOHp+EXvJ91rKFaS8yFhHxys+BnCpjuke8PNE0vAQM QXOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=wODXrUGa3xJje0kIbd8qZg/z/wc1dTw39zG2Qx5AyhI=; b=EfiXGwQKPPU/IFJAHjj/uJwOUe6ckS6SFNjMSOY4ASymiATOSbT3FzMvsT5Z/lmCvW 45OIZ//+JuMZAk2fPhHUa1gyKV9edDDSITevqrYqkZ038vLU9nf3gEwd7aToFNHbnC+j mirxKGfcksV57s3kMdue3coljrIWDivuKM3XOogezQEFWWNGUnTPP0XQonS2+XSdijlu 3tYfeormz95Q3rKKH9AKFapKN/Hrm7MbnUfNotTngvH+UlNFEdaW98O+SFysgHZZkDIq QMbbsENiH3lqV1ChBsnjjd6nspBQ4ZUsr/Ic+rGhR3qfUc7DH+8FB1AMOSrXqNf77CrK ZlDw== X-Gm-Message-State: ACgBeo0q9HZfJWttY70Zf4pUmcHnXSOraktYmlBkEicFumXQEI8Fnla/ sJ1EWkvlS8AYR1cKDLIGiWS+YQ== X-Google-Smtp-Source: AA6agR7+C80U63XwG32U92syOxTjw9Jp4ccOZIjl5T+WYcwHZ2T0df7+gpCmPXCVRBqqVz2H4iE9TQ== X-Received: by 2002:a05:6512:11f1:b0:497:adc5:629a with SMTP id p17-20020a05651211f100b00497adc5629amr5928383lfs.419.1662895677571; Sun, 11 Sep 2022 04:27:57 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id d23-20020a194f17000000b00492e69be4d6sm585484lfb.27.2022.09.11.04.27.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 11 Sep 2022 04:27:57 -0700 (PDT) Message-ID: <834eafc7-adb8-4977-a8c0-e34c44a583f3@linaro.org> Date: Sun, 11 Sep 2022 13:27:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [RFC PATCH 04/10] dt-bindings: arm: apple: Add t6001/t6002 Mac Studio compatibles Content-Language: en-US To: Janne Grunau Cc: asahi@lists.linux.dev, Mark Kettenis , Alyssa Rosenzweig , Hector Martin , Krzysztof Kozlowski , Rob Herring , Sven Peter , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220909135103.98179-1-j@jannau.net> <20220909135103.98179-5-j@jannau.net> <25b42684-1bee-b7f6-a89d-ed0b0ea7428b@linaro.org> <20220910113714.GC4024@jannau.net> From: Krzysztof Kozlowski In-Reply-To: <20220910113714.GC4024@jannau.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10/09/2022 13:37, Janne Grunau wrote: >>> The compatible property should follow this format: >>> >>> @@ -79,8 +81,15 @@ properties: >>> - enum: >>> - apple,j314c # MacBook Pro (14-inch, M1 Max, 2021) >>> - apple,j316c # MacBook Pro (16-inch, M1 Max, 2021) >>> + - apple,j375c # Mac Studio (M1 Max, 2022) >>> - const: apple,t6001 >>> - const: apple,arm-platform >> >> Blank line. > > Added. The other entries in this list are not separated by blank lines. > What would preferred to fix this? A whitespace only patch or can just > add those additional blank lines in this change? Both would work for me. Best regards, Krzysztof