From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 441B5C61DA4 for ; Mon, 13 Mar 2023 07:51:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230024AbjCMHvd (ORCPT ); Mon, 13 Mar 2023 03:51:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229996AbjCMHvZ (ORCPT ); Mon, 13 Mar 2023 03:51:25 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 836B328E78 for ; Mon, 13 Mar 2023 00:51:23 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id j11so44893648edq.4 for ; Mon, 13 Mar 2023 00:51:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678693882; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ApcfsHN2wN7CiLQkpY6hRDWMeHf0lIJaK00DDrg5fNU=; b=kQPrGnxYvasHxYFYfGSGho1RYetKH4JyMKJ3ud5unTPePmdSRjZrRVQ2DDQprphbqa +r/m8bdt6bmvlyJDpEICv8tnMoRqoVjoSPb/VHJY+mR5PHDx5Ktfzcfsg4LRlK4ofQpO UlW+5VSH/eaEjDfdof4PmhhiDf5LsxDX3AyoauL/4xCkhXbCaNoBmLO0bsH48989iZdI 10/GL6vzIfjDJvEgL9zKJnluIlENU3y5J8koECXzLnt00hCMy2OgIxN7WhgXAgqhfPg7 gsivioYUOX8yzoZkH3CxeTHLIp4SkWd0F2piLS9zeaUFVH0oKf4PWk3e0Xz445cQOeNU I4SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678693882; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ApcfsHN2wN7CiLQkpY6hRDWMeHf0lIJaK00DDrg5fNU=; b=ZMzfc9koitIGRYlBKc2YUn/kb/nziY/DwMothXtKqZ8umAevzV9tEUEMvi4pHMlSK3 ru+AFvo3npAaxDxkmoZI6R4udkSb8eXnpsG0u4smk5ZTxgk1Qo9s/lc6J2tOvsV5KJt8 gJY2cstHfj3s+vVFwhGz3mpIZtNaULkA9EoXNf4tn9bt+1x066xrZDvqkW3CaARp4P46 f6iTS9R3cAxwL+sT1jO9XAgHmodzIn6CJTCPVlc0IS4NWE3EZIUoIKjriaak7SifIltk Xc1jV3RRU6CIAa81t7DjuiR8dBWHdiWT41MMP1Wb7bawu0YH44eOTMjft3Y/vP18GF7q ab7Q== X-Gm-Message-State: AO0yUKXHeYbwj47j5d17p83ylQuHFjURhOxtxELOHuVX7OqTVIX20uoK ApxMv3Fjo161/9pF9i9epMvuQg== X-Google-Smtp-Source: AK7set/Wdx3mz3K2b03zcdbLEh+zTAXkriPquRH3CNjv2VE6Bjjx7PkESjwthAp40ot+7EmKIeFxmg== X-Received: by 2002:aa7:c54b:0:b0:4ac:b760:f07a with SMTP id s11-20020aa7c54b000000b004acb760f07amr33049256edr.19.1678693881955; Mon, 13 Mar 2023 00:51:21 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:f052:f15:3f90:fcb3? ([2a02:810d:15c0:828:f052:f15:3f90:fcb3]) by smtp.gmail.com with ESMTPSA id l22-20020a50d6d6000000b004fa19f5ba99sm2652296edj.79.2023.03.13.00.51.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Mar 2023 00:51:21 -0700 (PDT) Message-ID: <834fb899-7a03-ba0a-8302-f64ea58c60dd@linaro.org> Date: Mon, 13 Mar 2023 08:51:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v5 11/21] dt-bindings: clock: Add StarFive JH7110 system clock and reset generator Content-Language: en-US To: Hal Feng , Rob Herring Cc: Marc Zyngier , Krzysztof Kozlowski , Ben Dooks , Philipp Zabel , Stephen Boyd , linux-riscv@lists.infradead.org, Conor Dooley , Emil Renner Berthing , Thomas Gleixner , Paul Walmsley , Albert Ou , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Daniel Lezcano , linux-clk@vger.kernel.org, Michael Turquette , Palmer Dabbelt References: <20230311090733.56918-1-hal.feng@starfivetech.com> <20230311090733.56918-12-hal.feng@starfivetech.com> <167854282659.42837.5915012938593380363.robh@kernel.org> <80549148-1bad-9190-c4ea-a9555d15ca38@starfivetech.com> From: Krzysztof Kozlowski In-Reply-To: <80549148-1bad-9190-c4ea-a9555d15ca38@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 13/03/2023 03:47, Hal Feng wrote: > On Sat, 11 Mar 2023 08:17:00 -0600, Rob Herring wrote: >> On Sat, 11 Mar 2023 17:07:23 +0800, Hal Feng wrote: >>> From: Emil Renner Berthing >>> >>> Add bindings for the system clock and reset generator (SYSCRG) on the >>> JH7110 RISC-V SoC by StarFive Ltd. >>> >>> Signed-off-by: Emil Renner Berthing >>> Signed-off-by: Hal Feng >>> --- >>> .../clock/starfive,jh7110-syscrg.yaml | 104 +++++++++ >>> MAINTAINERS | 8 +- >>> .../dt-bindings/clock/starfive,jh7110-crg.h | 203 ++++++++++++++++++ >>> .../dt-bindings/reset/starfive,jh7110-crg.h | 142 ++++++++++++ >>> 4 files changed, 454 insertions(+), 3 deletions(-) >>> create mode 100644 Documentation/devicetree/bindings/clock/starfive,jh7110-syscrg.yaml >>> create mode 100644 include/dt-bindings/clock/starfive,jh7110-crg.h >>> create mode 100644 include/dt-bindings/reset/starfive,jh7110-crg.h >>> >> >> >> Please add Acked-by/Reviewed-by tags when posting new versions. However, >> there's no need to repost patches *only* to add the tags. The upstream >> maintainer will do that for acks received on the version they apply. >> >> If a tag was not added on purpose, please state why and what changed. >> >> Missing tags: >> >> Reviewed-by: Rob Herring > > This patch has been changed a lot and I am not sure whether it's still > the one you want. So I removed the Reviewed-by tag. Then mention it in changelog, just like Rob asked: "If a tag was not added on purpose, please state why and what changed." I don't see any explanation in the changelog about it. Best regards, Krzysztof