From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A629B16DC05 for ; Fri, 9 Aug 2024 07:09:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723187343; cv=none; b=Hgwy8Jp3FPYtlfKuBgWhSkSj5wfq8ukIldzeSdmORd3yP+yHl/sz9xWew1B8k+uUnAs2lxYgmOwTP5GCte7rEoAi1bQhx+nwI8uB+mtaoMBXt4nSGRFCXZm9HmXExAWkS2WT4y2DkoyDpTrCLx1JY3fDygUGLTX5cMN3SJfEoPQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723187343; c=relaxed/simple; bh=VfECz7OPrQqPTCXZmokmOw+YGaGRk23fu+dwqvsd0QQ=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=Q6JAXpE3cwz1JbEJg8nYkWD4dmGklkQ/BvOrET1FISIaS8bGqIJuPcrd3jcnPopGqMPf5gdic3bg7UM89ixGmJ1c6lRE9XqAfUkA1yrNqxUkBGYCQeU0AapzgeyJUuwhcWkFeOo8y+lcxfZw9lRuFjJ1C/4pZVbbA6Epc49mWtY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=cUK+2OxK; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="cUK+2OxK" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5b8c2a6117aso691604a12.0 for ; Fri, 09 Aug 2024 00:09:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1723187340; x=1723792140; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uyevx1eSZveednPIyrWDCVPvbsLJ4CSv84HEJGwgqRA=; b=cUK+2OxKdFs3j66gaTn6DtxLCFKl/B5tVAn18w+VYYnqMzHK5Kj74JR5FpKsi+1B44 DOrmmM3HXPfOEkLlfXkFv9PDEPndLzAnfitoKe9JmqmwjSXxynLyx0Fi+aZjCjhBizvB EcMH150UGj3Anoi/DQfiBwD6fRKV4QRBSx140qzBSrT3v7b2uZIqiNAHMBXB6/kpL91G H5TyF0B8Zt7oJ5+w0cMXnybdq3uvY4kNMQWsfHYTmN9kD/qBwCD82bA1HVdaCIg/heWx L++AuzEdgVw0h6RC4C2hKbtvc6lbNGDwzFmMytRufKAvmB1/BGuhOuzy2dhMHTCvhRgL 3AtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723187340; x=1723792140; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uyevx1eSZveednPIyrWDCVPvbsLJ4CSv84HEJGwgqRA=; b=CNH+oQnqCrh5VmDYd6Rl0brRyflhHgIh8WEgU7RmcCp2P6p/MSbalhrUtzEShjEZQg xAGsqFJKQYIcXvv33K7wU98nIFlYvVDyOSM487AxXUJvZJGc7AceKolu71bCm3IysH7F yXMouq4r2EFbaY2dp8mbG3cD633FnK9MpwaXqJfAIkscmZ4PzBKfkyXqcP7EZ37CPojr 9koxJH+NawJEazh6D5DejeKYFFcZdXPJccPetJmwHvbAQ9dyYCJ5vg0yuJ0VEYg1B1kY 23lkayyezA6NRsHXZWtm3OabMv0YNqV4ut89T6Wp84r1bn9MMDE40o+mDv1ZDNxX77bM T4lw== X-Forwarded-Encrypted: i=1; AJvYcCWXZjsYzyYMXB8AXtky39/xuf34pzw9ND1MIoj3iSNQMv5MllJmuwurx/lgjpbC2TVidPf9od4s4m95EfZGLyU1RuPQJLluaYDhXA== X-Gm-Message-State: AOJu0Yyn+zf6HcRCjBOBtqi6pPQdxWUhvcZx/gIbkZeSw7eCmzZJjEpm LdRaEZx/YakZRMXa9pIqq1LAkMdVsnI3HEupl9H6cQUcBOfvcwpi/RM1nj28Ukk= X-Google-Smtp-Source: AGHT+IGS2QSI7Zek1QoyFMiJIsl9IBJLkppjoDYkqSIfv+JYsY3kSxvXPRLfJWdBp4iPNDsWfQLR7w== X-Received: by 2002:a05:6402:2116:b0:5a0:f9f7:6565 with SMTP id 4fb4d7f45d1cf-5bd0a577cc8mr714543a12.21.1723187339798; Fri, 09 Aug 2024 00:08:59 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.180]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7dc9bc3d77sm807642866b.43.2024.08.09.00.08.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Aug 2024 00:08:59 -0700 (PDT) Message-ID: <8359caf0-5219-47dc-b68b-41486757be92@tuxon.dev> Date: Fri, 9 Aug 2024 10:08:57 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 05/11] i2c: riic: Add suspend/resume support Content-Language: en-US To: Wolfram Sang , chris.brandt@renesas.com, andi.shyti@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, geert+renesas@glider.be, magnus.damm@gmail.com, p.zabel@pengutronix.de, linux-renesas-soc@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Claudiu Beznea References: <20240711115207.2843133-1-claudiu.beznea.uj@bp.renesas.com> <20240711115207.2843133-6-claudiu.beznea.uj@bp.renesas.com> From: claudiu beznea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 08.08.2024 18:15, Wolfram Sang wrote: > On Thu, Jul 11, 2024 at 02:52:01PM +0300, Claudiu wrote: >> From: Claudiu Beznea >> >> Add suspend/resume support for the RIIC driver. This is necessary for the >> Renesas RZ/G3S SoC which support suspend to deep sleep state where power >> to most of the SoC components is turned off. As a result the I2C controller >> needs to be reconfigured after suspend/resume. For this, the reset line >> was stored in the driver private data structure as well as i2c timings. >> The reset line and I2C timings are necessary to re-initialize the >> controller after resume. >> >> Signed-off-by: Claudiu Beznea > > ? Doesn't apply on top of the previous patches for me? I just checked it on next-20240809. It should be due to commit e1571b1fb4ff ("i2c: riic: reword according to newest specification") which introduced changes around riic_algo object, present also in the diff of this patch. > >> +static int riic_i2c_resume(struct device *dev) >> +{ >> + struct riic_dev *riic = dev_get_drvdata(dev); >> + int ret; >> + >> + ret = reset_control_deassert(riic->rstc); >> + if (ret) >> + return ret; >> + >> + ret = riic_init_hw(riic); >> + if (ret) { >> + reset_control_assert(riic->rstc); > > Is this assertion really needed? It is not done when init_hw fails in > probe(). In case riic_init_hw() fails there is no recovering way for this driver, AFAICT, and thus there is no point in keeping the reset signal de-asserted. In probe this is handled by the devres through action or reset function (riic_reset_control_assert) registered by: ret = devm_add_action_or_reset(dev, riic_reset_control_assert, rstc); if (ret) return ret; Thank you, Claudiu Beznea