From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH v10 01/15] clk: tegra20/30: Add custom EMC clock implementation Date: Tue, 13 Aug 2019 05:36:41 +0300 Message-ID: <8369884e-1bd7-063f-e053-5152378078e9@gmail.com> References: <20190811210043.20122-1-digetx@gmail.com> <20190811210043.20122-2-digetx@gmail.com> <20190812231258.GA31836@qmqm.qmqm.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20190812231258.GA31836@qmqm.qmqm.pl> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: =?UTF-8?B?TWljaGHFgsKgTWlyb3PFgmF3?= Cc: Rob Herring , Michael Turquette , Joseph Lo , Thierry Reding , Jonathan Hunter , Peter De Schrijver , Prashant Gaikwad , Stephen Boyd , devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org 13.08.2019 2:12, Michał Mirosław пишет: > On Mon, Aug 12, 2019 at 12:00:29AM +0300, Dmitry Osipenko wrote: >> A proper External Memory Controller clock rounding and parent selection >> functionality is required by the EMC drivers, it is not available using >> the generic clock implementation because only the Memory Controller driver >> is aware of what clock rates are actually available for a particular >> device. EMC drivers will have to register a Tegra-specific CLK-API >> callback which will perform rounding of a requested rate. EMC clock users >> won't be able to request EMC clock by getting -EPROBE_DEFER until EMC >> driver is probed and the callback is set up. > [...] >> diff --git a/drivers/clk/tegra/Makefile b/drivers/clk/tegra/Makefile >> index 4812e45c2214..df966ca06788 100644 >> --- a/drivers/clk/tegra/Makefile >> +++ b/drivers/clk/tegra/Makefile >> @@ -17,7 +17,9 @@ obj-y += clk-tegra-fixed.o >> obj-y += clk-tegra-super-gen4.o >> obj-$(CONFIG_TEGRA_CLK_EMC) += clk-emc.o >> obj-$(CONFIG_ARCH_TEGRA_2x_SOC) += clk-tegra20.o >> +obj-$(CONFIG_ARCH_TEGRA_2x_SOC) += clk-tegra20-emc.o >> obj-$(CONFIG_ARCH_TEGRA_3x_SOC) += clk-tegra30.o >> +obj-$(CONFIG_ARCH_TEGRA_3x_SOC) += clk-tegra20-emc.o >> obj-$(CONFIG_ARCH_TEGRA_114_SOC) += clk-tegra114.o >> obj-$(CONFIG_ARCH_TEGRA_124_SOC) += clk-tegra124.o >> obj-$(CONFIG_TEGRA_CLK_DFLL) += clk-tegra124-dfll-fcpu.o > > Doesn't it complain when both CONFIG_ARCH_TEGRA_2x_SOC and > CONFIG_ARCH_TEGRA_3x_SOC are enabled at the same time? No, at least not with my toolchain setup. Are you getting some warning?