From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 238857D3E9 for ; Tue, 12 Mar 2024 16:12:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710259946; cv=none; b=PNDMZybQ9BmxrksNfLP7SQUSIItK+88G2OFPAY0QuVY6eutnYVOVBIiVB1dF+U4L03O0KSc5VU5KZp8QyXxt5V31QOPwZgN8FBxdnkEgv75PNFjFKJwgt0kg1pN6RTfdEl4dXp597ct6aCtMqRRwdNb6Amb7wAgHkc5CecMFbC8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710259946; c=relaxed/simple; bh=rXaL0LJcdegT3oLCAhYYQ90a8sQqF6H95AJnSTlrKSc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bY3h2Wv76w/kYtzCj9NvLEGjznckxiGBs3AWa2y990Coz2/3NdEjxF6f8ckER5OG3iq9pO2WPbIuixNxKOTlAnkFPADzmdPDjF27MbKBriAkFaSc7wQq963nCC8nYUeVt9RE6z/YhVsI7EjTfROMbb7O0qlWCSNupMBUNNcjMCA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VkaKbl3O; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VkaKbl3O" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-513b1e1724bso136655e87.1 for ; Tue, 12 Mar 2024 09:12:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710259942; x=1710864742; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zLG0VkRk9T+MqlwYSwMr85lswH7UeBe9EKEDGZIjNWM=; b=VkaKbl3OsvXrFmg4E80Ozyosy3q8c7v0SYE5ZgaVP8kkVtVxnhBaXrSltAxKs7fieN 4iFYDNM/aKYLsliKygdYE5llmP5alF0YBHRVzAsn5ZbgF8yXkW33szIXxRN9aUt2I85W FQty0IIldS6e+jyPuZ60jzeplo6g55x+Du6oD4BLrUSLC9+gha++YwMRPdChAdB88dLd tq8F47vH1P+TDYQ7pkVKdLd633GU9BlVjfbuoUfZGpMJlqJFwW36Ty7s/nbqsankpES6 9XNqGezrepJHGBPwfAhbY1+eks1ZQ8vWvKT9pZUyGDIgENzEQ8p9TXV0Lo6q5edCDu4a k51w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710259942; x=1710864742; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zLG0VkRk9T+MqlwYSwMr85lswH7UeBe9EKEDGZIjNWM=; b=wrzxDPmiL+V3sdOUXxht/ixQhlvOwJyFubehq3JmkaotO1KN8SYfPtFnVt5A8VTQ3h VnDuf4U0ZFyPf7Xqd3yLrqRW1BMDP2Po7mMh43qqNDaQj2YWpg4bIq81iIyONrNDihMW GzA/NzevAWcW0C4Qs8wUKi1/Rt1fpk3uincpKCqE1waS1XmDpIMXXS6fpK0nmYCYRbLy KuFwIoaW56INc0Hr+v2iAdzLvtnvlZiMrCOqmRoI6f/xXcAAgGd6Jas25fFmTc1COKh9 1ePvWWAaYvbydDOPCUlPgcqnKOAz1kbZMCYS/zyLs1dDa8nmB54lOWMzy4dXxYfGKDET G57A== X-Forwarded-Encrypted: i=1; AJvYcCUHIVehzarG/PMRTDskrf8Qa8cav1ma4CzTGojP1pLd0fyKIuVBRz87g6hnJYA5uGmJp9TDJdYxW64uEei7W17++sMoNHMwkZqlLQ== X-Gm-Message-State: AOJu0Yyy4ahielWdXqS8K5mzfYLXdjmpw9D6USD0Jr42lFKehkcRUZ0/ riLSaolQpcr5E+0aK6e3RUta6WB6YXFq2tkdLBKrhkf2Uh/UNW/pLPUaQbQveP8= X-Google-Smtp-Source: AGHT+IHFOEHl33gs0on8qTVXiyJ+aHRxksDiQ505Q8fof/YGiXciDjx8sbsbVrPzSuDgBdzksPF1+g== X-Received: by 2002:ac2:4d0f:0:b0:513:488a:95af with SMTP id r15-20020ac24d0f000000b00513488a95afmr1774lfi.15.1710259942295; Tue, 12 Mar 2024 09:12:22 -0700 (PDT) Received: from [87.246.221.205] (netpanel-87-246-221-205.pol.akademiki.lublin.pl. [87.246.221.205]) by smtp.gmail.com with ESMTPSA id o5-20020ac24945000000b0051321db6a0dsm1634984lfi.139.2024.03.12.09.12.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Mar 2024 09:12:21 -0700 (PDT) Message-ID: <83734790-85c5-446f-b353-f3765cb10d41@linaro.org> Date: Tue, 12 Mar 2024 17:12:19 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/7] clk: qcom: clk-alpha-pll: Add HUAYRA_2290 support Content-Language: en-US To: Trilok Soni , Will Deacon , Robin Murphy , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter Cc: Marijn Suijten , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org References: <20240219-topic-rb1_gpu-v2-0-2d3d6a0db040@linaro.org> <20240219-topic-rb1_gpu-v2-2-2d3d6a0db040@linaro.org> <605d9e50-d61b-b0ce-1664-00554ba70b41@quicinc.com> From: Konrad Dybcio In-Reply-To: <605d9e50-d61b-b0ce-1664-00554ba70b41@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/23/24 23:48, Trilok Soni wrote: > On 2/23/2024 1:21 PM, Konrad Dybcio wrote: >> + /* Wait 50us for PLL_LOCK_DET bit to go high */ >> + usleep_range(50, 55); >> + >> + /* Enable PLL output */ >> + regmap_update_bits(regmap, PLL_MODE(pll), PLL_OUTCTRL, PLL_OUTCTRL); >> +} >> +EXPORT_SYMBOL(clk_huayra_2290_pll_configure); > > Please use EXPORT_SYMBOL_GPL. Sure, I glanced over this! I've also noticed that it's a very common oversight.. would you be interested in extending scripts/checkpatch.pl to suggest the _GPL variant? Konrad