From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F95EEB64D9 for ; Sat, 17 Jun 2023 07:28:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346094AbjFQH21 (ORCPT ); Sat, 17 Jun 2023 03:28:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346084AbjFQH20 (ORCPT ); Sat, 17 Jun 2023 03:28:26 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7273C271E for ; Sat, 17 Jun 2023 00:28:25 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-51a2fa4a45eso2044622a12.0 for ; Sat, 17 Jun 2023 00:28:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686986904; x=1689578904; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tNOXDR8ammGfhSACaL8GR+6Nt9orr8dF7n6TFf183BI=; b=qA+WvJ4hNQbyu/ACCtBfo8NrOiRUJJsOv2VOujI9VBUaTryLoSEHQ9Tuq9GNM9kw8b pYWAVBmXglKYw10E5rOfOpKqY/QmJtvyB5GWFYmzaWj/mQZqii+aHgNv62HhXgvHius2 D7R4Ju0yD2qUzxwY9FY9zS7Z4W57zmIqnLMiKk6bM2JX85TrIeAwKJOrgskvantYq26u dDqDQsTcIzeyl7fpmAEOq0NrSXfH1IX1xv6TLcn4nfewHcJYm74oZP/Rx5xgmLOa1ft3 FWFUrpsUZSmFOUe6YV9cwWvkL73ltimhmXShmLbL3mkkD1YmdpCqZYscRZn+1EoxDic7 95Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686986904; x=1689578904; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tNOXDR8ammGfhSACaL8GR+6Nt9orr8dF7n6TFf183BI=; b=b+3YbpDeNPNXu3KxROXqqKxzsM6b73ckkxCIkWaxAKZusWTSxZgtA6cd7bw8WT7X0y ef0OtNtEz6ouqrWjl4xK0E5AnrTm6ex84u12TCgA0Ix7qOURnTe/cd8z9T4qZi3zTnJb xBi+YA/Qr4pIdQRVSBwUH25L6tMUpLAaa1B5m4IBTx8PSBB4ghNS/c6kOyFNqhmlERFP 1WjaVv+uuZIMSoiW2diKacYfwMqQlHae2Mx4Q2m23qvU7MoNR3LOcGsK4SaHBYmBUyQw n4ATdTfGwU5W2F4kDdhfT+vLSR412Ji15eJj4rqPjij2V0i+/N/PvvAAMsxhtQKx97Pd /f1w== X-Gm-Message-State: AC+VfDxWm9jufPa2yC8yBKp39/AV5exK9e0ipFsFw8ntURk8nehXQGoH IIxJ586mzcU/gm7RThCPvJmlmQ== X-Google-Smtp-Source: ACHHUZ64pqeOFhHo+B+O2squOClmtsXC2rT2z2VNvrH1Uhz5PU02jMg1G7EMy4k5dz26C/Vc342YkA== X-Received: by 2002:a17:907:3e27:b0:982:30e3:ddcb with SMTP id hp39-20020a1709073e2700b0098230e3ddcbmr5108273ejc.65.1686986903823; Sat, 17 Jun 2023 00:28:23 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id a13-20020a170906684d00b009828dac8425sm3713144ejs.105.2023.06.17.00.28.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Jun 2023 00:28:23 -0700 (PDT) Message-ID: <83807d70-c35c-6b66-e7f9-521bdfc6d1b4@linaro.org> Date: Sat, 17 Jun 2023 09:28:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v8 10/11] arm64: dts: qcom: sm8350: Add Crypto Engine support To: Konrad Dybcio , Bhupesh Sharma , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Cc: agross@kernel.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, andersson@kernel.org, bhupesh.linux@gmail.com, robh+dt@kernel.org, vladimir.zapolskiy@linaro.org, rfoss@kernel.org, neil.armstrong@linaro.org, djakov@kernel.org, stephan@gerhold.net, Anders Roxell , Linux Kernel Functional Testing References: <20230526192210.3146896-1-bhupesh.sharma@linaro.org> <20230526192210.3146896-11-bhupesh.sharma@linaro.org> <11c3eb6c-823d-9688-ec53-e05c7bb557c5@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <11c3eb6c-823d-9688-ec53-e05c7bb557c5@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 17/06/2023 01:33, Konrad Dybcio wrote: > On 16.06.2023 19:36, Krzysztof Kozlowski wrote: >> On 26/05/2023 21:22, Bhupesh Sharma wrote: >>> Add crypto engine (CE) and CE BAM related nodes and definitions to >>> 'sm8350.dtsi'. >>> >>> Tested-by: Anders Roxell >>> Tested-by: Linux Kernel Functional Testing >>> Co-developed-by and Signed-off-by: Robert Foss >>> [Bhupesh: Switch to '#interconnect-cells = <2>', available since commit 4f287e31ff5f] >>> Signed-off-by: Bhupesh Sharma >>> --- >> >> #regzbot introduced: f1040a7fe8f069d2259ab3dab9190210005ceb33 >> #regzbot title: HDK8350 silently crashes early on boot >> >> Hi, this landed in the next but unfortunately it causes silent crash >> (and reboot) of HDK8350. Reverting this commit helps. > Downstream also references the following SIDs: > > iommus = <&apps_smmu 0x592 0>, > <&apps_smmu 0x598 0>, > <&apps_smmu 0x599 0>, > <&apps_smmu 0x59F 0>; I already tried iommus from downstream from: 1. qcrypto node (0x584, 0x594) 2. qcedev (0x586, 0x596) 3. qcom_cedev_ns_cb (0x592, 0x598, 0x599, 0x59F), although with 0x0011 last argument. Same results, but indeed iommu would be nice reason here. I also double checked the version of block (BAM DMA is v1.7.4) and other properties. When I disabled crypto but left BAM DMA, the result was the same, thus it is maybe the BAM who causes abort. Best regards, Krzysztof