From: Andrew Davis <afd@ti.com>
To: Thomas Richard <thomas.richard@bootlin.com>,
Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<thomas.petazzoni@bootlin.com>, <gregory.clement@bootlin.com>,
<u-kumar1@ti.com>
Subject: Re: [PATCH 1/5] dt-bindings: arm: keystone: add ti,j7200-sci compatible
Date: Wed, 29 Nov 2023 09:54:57 -0600 [thread overview]
Message-ID: <83814027-12a1-4273-9d2d-400739bc3b64@ti.com> (raw)
In-Reply-To: <20231129-j7200-tisci-s2r-v1-1-c1d5964ed574@bootlin.com>
On 11/29/23 9:31 AM, Thomas Richard wrote:
> On j7200, during suspend to ram the soc is powered-off.
> At resume requested irqs shall be restored which is a different behavior
> from other platforms.
Why is J7200 different? All K3 can/will support off mode suspend
to RAM. The only difference is you are adding support for it to this
one SoC first. You are describing a software behavior, not hardware.
Using a compatible to describe if a SW feature is enabled is not a
correct use of DT.
Andrew
>
> Signed-off-by: Thomas Richard <thomas.richard@bootlin.com>
> ---
> Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> index c24ad0968f3e..53d9c58dcd70 100644
> --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> @@ -40,6 +40,8 @@ properties:
> - description: System controller on TI AM654 SoC
> items:
> - const: ti,am654-sci
> + - description: System controller on TI J7200 SOC
> + - const: ti,j7200-sci
>
> reg-names:
> description: |
>
next prev parent reply other threads:[~2023-11-29 15:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 15:31 [PATCH 0/5] Add suspend/resume support in ti_sci driver for j7200 Thomas Richard
2023-11-29 15:31 ` [PATCH 1/5] dt-bindings: arm: keystone: add ti,j7200-sci compatible Thomas Richard
2023-11-29 15:34 ` Conor Dooley
2023-11-29 15:38 ` Conor Dooley
2023-11-30 15:42 ` Conor Dooley
2023-11-29 15:54 ` Andrew Davis [this message]
2023-12-01 7:46 ` Nishanth Menon
2023-11-29 15:31 ` [PATCH 2/5] firmware: ti_sci: add suspend/resume support for irqs Thomas Richard
2023-12-01 8:05 ` Nishanth Menon
2023-11-29 15:31 ` [PATCH 3/5] arm64: dts: ti: k3-j7200: use ti,j7200-sci compatible Thomas Richard
2023-11-29 15:35 ` Conor Dooley
2023-11-29 15:31 ` [PATCH 4/5] firmware: ti-sci: for j7200 before suspend check the reserved memory for lpm Thomas Richard
2023-11-29 15:31 ` [PATCH 5/5] arm64: dts: ti: k3-j7200: add reserved memory regions " Thomas Richard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83814027-12a1-4273-9d2d-400739bc3b64@ti.com \
--to=afd@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=ssantosh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=thomas.richard@bootlin.com \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox