From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C7D4C7EE25 for ; Mon, 12 Jun 2023 08:40:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229732AbjFLIkZ (ORCPT ); Mon, 12 Jun 2023 04:40:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233291AbjFLIkD (ORCPT ); Mon, 12 Jun 2023 04:40:03 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB57FA8 for ; Mon, 12 Jun 2023 01:40:01 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-97460240863so672863166b.0 for ; Mon, 12 Jun 2023 01:40:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686559200; x=1689151200; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=02uq97znLW4jmjI8z3bfmKNKoaY1pURh+uCJ5ILlpl4=; b=r3TsQrkeAGuvV2odOjldtDHX2T+L/m8a6yRAR6lIrc1jRs/1Pi7KK6zsjHLQaR8cFi SxaiTckU4XCvA2DPqjaaReqb+/Ae0hBbsLNK5bvqVBAI2no9Okt7LkqEigfQIl88nkDa w7wumWQefYsGZSbmJ1MQso5m0yw6SrQjAHkcXfTMBztqlxs+oQbcCNSNhRQ49gBbDecK 3ULlREI4GhYIh6OYo/CtkDRCa61kLyeP5IohYjEoxQaXLHbRuB93Jam2vFM/NLuA9yk9 eOoNeqarG51IqFkVglJ+aCHvRNBS7EBfpFXnulWi3Erhu2A6GnEgPgDwE7YVB48i9yIX SLMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686559200; x=1689151200; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=02uq97znLW4jmjI8z3bfmKNKoaY1pURh+uCJ5ILlpl4=; b=RjsaW8vPMwpEZun2nasbV9sg1wDEp73ca61gk7StKeI3h3C0Eii91t+AvG7A68kOky 5veQi12IB1M/s+rhdBgpISEyiPMklT3d7NnmYAoRtK2H0qHSfCAPbYeVQE83/P+4O2Uc c2hLKIPQhfH8HxEnfANCRDQLM4+e5vM0iJkq7AePjH+Ms62kmKCMOCsJOT6hLUWOaiIY YEnm0ws3dB1flQRMha6lMEtVe8KxluNFJgFMqKeemIhQLB/DGTQBVxlhCc1mA9c9Pekl cRmErMVtHX4JtAPNno7yc7PdxDNbZSvVB9CdwW6gCCB1JviCEgGyf8HM9aMTXFGDEcwl 7u1Q== X-Gm-Message-State: AC+VfDwEdXbp3ivBULEST03U2DJjPVUfixgwlXYIQeHWa+tuPPnqXRaQ tbQk47zCNm4v7L6VmRVdUX381ZHoUADudqgWJvU= X-Google-Smtp-Source: ACHHUZ4xrQwuUVb3h5HfV5TapbFL6CRyh+HdmkFi6c1IQyUy5wmGPCLKe5LhyIoZ9pNqf/4ghHn8Qg== X-Received: by 2002:a17:907:9617:b0:974:1ef7:1e88 with SMTP id gb23-20020a170907961700b009741ef71e88mr9928825ejc.13.1686559200150; Mon, 12 Jun 2023 01:40:00 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id m3-20020a170906258300b00977d194bf42sm4851790ejb.161.2023.06.12.01.39.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jun 2023 01:39:59 -0700 (PDT) Message-ID: <838ed0e6-985d-9a45-7ece-c607bda15871@linaro.org> Date: Mon, 12 Jun 2023 10:39:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v3 2/5] dt-bindings: ata: dwc-ahci: add Rockchip RK3588 Content-Language: en-US To: Serge Semin Cc: Sebastian Reichel , Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Damien Le Moal , Vinod Koul , Kishon Vijay Abraham I , linux-ide@vger.kernel.org, linux-phy@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com References: <20230608162238.50078-1-sebastian.reichel@collabora.com> <20230608162238.50078-3-sebastian.reichel@collabora.com> <4c914503-c2e5-a5d8-97af-daaee0b4ec7c@linaro.org> <20230612083536.q3sq7w6cyiuxaqtv@mobilestation> From: Krzysztof Kozlowski In-Reply-To: <20230612083536.q3sq7w6cyiuxaqtv@mobilestation> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/06/2023 10:35, Serge Semin wrote: > On Mon, Jun 12, 2023 at 10:24:06AM +0200, Krzysztof Kozlowski wrote: >> On 08/06/2023 18:22, Sebastian Reichel wrote: >>> This adds Rockchip RK3588 AHCI binding. In order to narrow down the >>> allowed clocks without bloating the generic binding, the description >>> of Rockchip's AHCI controllers has been moved to its own file. >>> >>> Signed-off-by: Sebastian Reichel >>> --- >> >> ... >> >>> + >>> +properties: >>> + compatible: >>> + items: >>> + - enum: >>> + - rockchip,rk3568-dwc-ahci >>> + - rockchip,rk3588-dwc-ahci >>> + - const: snps,dwc-ahci >>> + >>> + ports-implemented: >>> + const: 1 >>> + >>> +patternProperties: >>> + "^sata-port@[0-9a-e]$": >>> + $ref: /schemas/ata/snps,dwc-ahci-common.yaml#/$defs/dwc-ahci-port >>> + >>> + unevaluatedProperties: false >> > >> You should be able to skip this patternProperties entirely, because it >> comes from dwc-ahci-common -> ahci-common schema. Did you try the patch >> without it? > > Please see my message about this. The "sata-port@[0-9a-e]$" sub-node > bindings could be updated with the "reg" property constraint which, > based on the "ports-implemented" property value, most likely is > supposed to be always set to const: 1. Then anyway the pattern is wrong as it should be @1 always. Best regards, Krzysztof