From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FB13C83F13 for ; Mon, 28 Aug 2023 07:49:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229573AbjH1Hsc (ORCPT ); Mon, 28 Aug 2023 03:48:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229734AbjH1HsG (ORCPT ); Mon, 28 Aug 2023 03:48:06 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3A02114; Mon, 28 Aug 2023 00:48:00 -0700 (PDT) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 77DBC7FDC; Mon, 28 Aug 2023 15:47:53 +0800 (CST) Received: from EXMBX072.cuchost.com (172.16.6.82) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 28 Aug 2023 15:47:53 +0800 Received: from [192.168.125.72] (113.72.145.245) by EXMBX072.cuchost.com (172.16.6.82) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 28 Aug 2023 15:47:52 +0800 Message-ID: <8390fffb-c704-286f-44b9-4e0d24818343@starfivetech.com> Date: Mon, 28 Aug 2023 15:47:51 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [RFC v4 0/4] StarFive's Pulse Width Modulation driver support Content-Language: en-US To: Krzysztof Kozlowski , Conor Dooley , William Qiu CC: , , , , "Emil Renner Berthing" , Rob Herring , Philipp Zabel , Thierry Reding , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , "Krzysztof Kozlowski" , Conor Dooley , Paul Walmsley , "Palmer Dabbelt" , Albert Ou References: <20230825081328.204442-1-william.qiu@starfivetech.com> <20230825-exclusion-doing-93532be4fa97@spud> <683df184-6688-f006-c4d8-fa7000b7b771@linaro.org> From: Hal Feng In-Reply-To: <683df184-6688-f006-c4d8-fa7000b7b771@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.145.245] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX072.cuchost.com (172.16.6.82) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 8/28/2023 3:16 PM, Krzysztof Kozlowski wrote: > On 28/08/2023 09:12, Hal Feng wrote: >> On Fri, 25 Aug 2023 16:06:12 +0100, Conor Dooley wrote: >>> On Fri, Aug 25, 2023 at 04:13:24PM +0800, William Qiu wrote: >>>> Hi, >>>> >>>> This patchset adds initial rudimentary support for the StarFive >>>> Pulse Width Modulation controller driver. And this driver will >>>> be used in StarFive's VisionFive 2 board.The first patch add >>>> Documentations for the device and Patch 2 adds device probe for >>>> the module. >>>> >>>> Changes v3->v4: >>>> - Rebased to v6.5rc7. >>>> - Sorted the header files in alphabetic order. >>>> - Changed iowrite32() to writel(). >>>> - Added a way to turn off. >>>> - Moified polarity inversion implementation. >>>> - Added 7100 support. >>>> - Added dts patches. >>>> - Used the various helpers in linux/math.h. >>>> - Corrected formatting problems. >>>> - Renamed dtbinding to 'starfive,jh7100-pwm.yaml'. >>>> - Dropped the redundant code. >>>> >>>> Changes v2->v3: >>>> - Fixed some formatting issues. >>>> >>>> Changes v1->v2: >>>> - Renamed the dt-binding 'pwm-starfive.yaml' to 'starfive,jh7110-pwm.yaml'. >>>> - Dropped the compatible's Items. >>>> - Dropped the unuse defines. >>>> - Modified the code to follow the Linux coding style. >>>> - Changed return value to dev_err_probe. >>>> - Dropped the unnecessary local variable. >>>> >>>> The patch series is based on v6.5rc7. >>> >>> Out of curiosity, why is this series still an RFC? >> >> There was no comments received in v4. So William resend it and >> request for comments. > > The question was: why he requests for comments? > > RFC means *it should not be merged, it is not ready*. Oh, it was misunderstood by William and me. So this series is not a RFC. Best regards, Hal