From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C744C38147 for ; Wed, 18 Jan 2023 14:45:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231534AbjAROpp (ORCPT ); Wed, 18 Jan 2023 09:45:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231462AbjAROpb (ORCPT ); Wed, 18 Jan 2023 09:45:31 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 410A45AB49 for ; Wed, 18 Jan 2023 06:37:33 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id t5so29738192wrq.1 for ; Wed, 18 Jan 2023 06:37:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BerAg7MaTiqh8AGRs2l1bVSpcU/dcHYC1GMmqI8bSIE=; b=P0A3t9d7EFYTQFvCohOEXhUrBZgzCWZlctxwJ2+fKkqwLIIy8i2LgbA0KNE5ybPVK0 1PE/je1saa8Qo0dJxmVb/VdY8TkfH8+jl3kaaXUoVw9GuOGzSIoqn/aKxbDUtm9FIcxL eToo3p+qYadSRDaUlZruoFDzNpHUyVzeJtePxMBvp6kTq9j+kaFO+HVV/OKdnQ1iGdwq /2F2oebDM7DbP/XI0hgibVtE8ml4VjKTbl9A+lsty5Bc1w5uTXH0X7K0YrkxchUA4HBT 9k2XJLgAa7XjwY1pL5kWPtQGsUOmX5F+XC9FFFjsBNXwlMYupiKcH7fwxoYavEjQDx9x pxGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BerAg7MaTiqh8AGRs2l1bVSpcU/dcHYC1GMmqI8bSIE=; b=g1WEw+TfZzc/aM6LMS/K5NQmdTDysaG6DSXWLbB89gp3774LJVd+dGM8K1DrfcLYbY 6SCTO+J6Tmo81HKF4vVdH0oziJGv+txCKtrHIE5pTenJDhgRDp1F+6L0Qe/Y7anhQUC6 6O2LyxOweqhM8OtgPro00DCB+F9/wr41Ts0cgUbJNBxFfrvOwrqNml/2I/eHdIhbZ4OS oZAXd++V+AnMqW6UHVF9p3OQYyL3e/spQoVhi6Tgbtnc0HYTZ/cNBBPB4t3HhaYMrwQ6 wC2i0j2fx2vlW3tEeXIDzpF5DR+gmQ98fZ493bGmsXfYapKlBPA1Ori9u2mUNk7w1EaE +hFQ== X-Gm-Message-State: AFqh2krshoJ36AoLf/nSTaCSfpYU+rkKC+s5d5jjYlGA2TnKLnvWtLGO mW9Z6LYDSeVRuytCmr1AsJdTnQ== X-Google-Smtp-Source: AMrXdXs2yrAPAcyrY27r/gzfcjpjvvGd7OkYOEn/4I6hRGm6z8/ULmc9XPTmWiJRIrKxS5VGlT+7Fw== X-Received: by 2002:a5d:58f2:0:b0:2bd:fcd8:c778 with SMTP id f18-20020a5d58f2000000b002bdfcd8c778mr5570929wrd.31.1674052651820; Wed, 18 Jan 2023 06:37:31 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id f2-20020adff982000000b002bde537721dsm13537089wrr.20.2023.01.18.06.37.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jan 2023 06:37:31 -0800 (PST) Message-ID: <83939b6b-0188-9cb7-c4fc-624f13437a48@linaro.org> Date: Wed, 18 Jan 2023 15:37:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH v4 16/17] arm64: dts: freescale: apalis-imx8: fix reserved-memory node names Content-Language: en-US To: Marcel Ziswiler , "devicetree@vger.kernel.org" Cc: "linux-imx@nxp.com" , "kernel@pengutronix.de" , "festevam@gmail.com" , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "krzysztof.kozlowski+dt@linaro.org" , "robh+dt@kernel.org" References: <20230118072656.18845-1-marcel@ziswiler.com> <20230118072656.18845-17-marcel@ziswiler.com> <1d4dc13ce1ffae4885bceb439d5d259f3567e6c4.camel@toradex.com> From: Krzysztof Kozlowski In-Reply-To: <1d4dc13ce1ffae4885bceb439d5d259f3567e6c4.camel@toradex.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18/01/2023 15:36, Marcel Ziswiler wrote: > On Wed, 2023-01-18 at 15:02 +0100, Krzysztof Kozlowski wrote: >> On 18/01/2023 08:26, Marcel Ziswiler wrote: >>> From: Marcel Ziswiler >>> >>> Fix reserved-memory node names using dashes rather than underscores. >>> >>> Signed-off-by: Marcel Ziswiler >>> >>> --- >>> >>> Changes in v4: >>> - New patch fixing reserved-memory node names. >>> >>>  arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi | 12 ++++++------ >>>  1 file changed, 6 insertions(+), 6 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi b/arch/arm64/boot/dts/freescale/imx8- >>> apalis-v1.1.dtsi >>> index 70c00b92cb05..6217e0a48f96 100644 >>> --- a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi >>> +++ b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi >>> @@ -133,17 +133,17 @@ reserved-memory { >>>                 #size-cells = <2>; >>>                 ranges; >>>   >>> -               decoder_boot: decoder_boot@84000000 { >>> +               decoder_boot: decoder-boot@84000000 { >> >> This is ridiculous. You just added it! If we consider original code as >> wrong, then you intentionally added wrong code just to fix it. >> >> No, that's not the way how it should be developed. > > Shawn asked me to ease the review process which is exactly what I did. Any reason why b4 diff cannot be used? If your patchset fails b4 auto-detection of version, this should be fixed instead of fake split. Best regards, Krzysztof