From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14CACC001DE for ; Sun, 9 Jul 2023 17:18:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229769AbjGIRS1 (ORCPT ); Sun, 9 Jul 2023 13:18:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230107AbjGIRS0 (ORCPT ); Sun, 9 Jul 2023 13:18:26 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76844128 for ; Sun, 9 Jul 2023 10:18:24 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-4f4b2bc1565so5578549e87.2 for ; Sun, 09 Jul 2023 10:18:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688923103; x=1691515103; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=a4ESr9ycTlv2oyhDdfMdroTzsv1FcuY2XELb8Cinj9g=; b=plrOflODvDRg6EplaXi1Kbv7vSI/ij+/ROSCoK/v8rJnX9j2Sxdk3U+VncxJ5kjxz0 1iA6K0Sqk7l3kIAoFDtkLxBdncWSAlf4TZ9Oilqc4iAZ7PgLeoBhH2cPFPmxqjsHGbHm xbw95cttVEdbWkleNdSbTIUUe3gldUTb2+SgaWMB9wA+QyB+lZa7dedtdQ36w8I2qDQA /N+AQDuydcTNKxAaetdmIg5JaLWvYrGLbHUpSYVEGudzs9ir62EsDQ6Pmz9btkBHKZqU 3Ol5cdALdzyzxICPvymN6s+/cxEmRiGBJKdb0KEvmvl3mKilRCK/yQJOGOIaRprBpXAT A5XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688923103; x=1691515103; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=a4ESr9ycTlv2oyhDdfMdroTzsv1FcuY2XELb8Cinj9g=; b=O/ylJlGALPMrRmK8dTq8qj8gHmylEw5qwMgjhtZ0Ri9T59omFkYFwCCbT0aS2YaQtL 0Wot9cnIR/Y2xTZoeUQDrFsWSowJ0IHu4kEPKyEH7GuZjjHaGxSLDCjKj1+QYCtNe5SU XQzFwrRNM82RGYe11ECpljViumvy/1hlnI3IoliqzOapHmAITyLj+Vc2S66s9VYXST8v eEaOCGU8qyiuwyl1Lv7j/RIAQh/M8LhuQQjhtGlgRXPJ+cdZGs7S02QbQuVr8x7rDA2C dBk6gSfxIS6UZkgq1Cfab/esuRJJwUy/vR7/mtFL88u9XY1gfFXWLHhLLwwjwITgmSfH tHEg== X-Gm-Message-State: ABy/qLYZTbVp4OxqtkNmR9oyiQljUyZ85wl8Weeivg25ShZnqC+n/Zif QZbDBUcJAywWUdkh07EzBa3QuA== X-Google-Smtp-Source: APBJJlEF3q8C9/RXRj0i6X1QW9hyoU2aZchYK6HK5qdXq5LupCCj5k9C+09fwOMNhreTqE5GdS2zhQ== X-Received: by 2002:a05:6512:3d0f:b0:4f8:58ae:8ea8 with SMTP id d15-20020a0565123d0f00b004f858ae8ea8mr8776912lfv.58.1688923102661; Sun, 09 Jul 2023 10:18:22 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id v7-20020a056402184700b0051de2455041sm4685273edy.24.2023.07.09.10.18.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 09 Jul 2023 10:18:22 -0700 (PDT) Message-ID: <839cfac2-8f74-3386-5854-e3fb2ba4e07f@linaro.org> Date: Sun, 9 Jul 2023 19:18:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 03/11] ARM: dts: qcom: Update devicetree for ADC7 rename for QCOM PMICs Content-Language: en-US To: Jishnu Prakash , agross@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linus.walleij@linaro.org, Jonathan.Cameron@huawei.com, sboyd@kernel.org, dmitry.baryshkov@linaro.org, quic_subbaram@quicinc.com, quic_collinsd@quicinc.com, quic_kamalw@quicinc.com, quic_jestar@quicinc.com, marijn.suijten@somainline.org, andriy.shevchenko@linux.intel.com, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org Cc: linux-iio@vger.kernel.org, linux-arm-msm-owner@vger.kernel.org References: <20230708072835.3035398-1-quic_jprakash@quicinc.com> <20230708072835.3035398-4-quic_jprakash@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20230708072835.3035398-4-quic_jprakash@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 08/07/2023 09:28, Jishnu Prakash wrote: > The name "ADC7" needs to be replaced with the name "ADC5_GEN2" > everywhere to match the convention used for these ADC peripherals > on Qualcomm Technologies, Inc. PMICs. Update devicetree files for We do not rename compatibles to match convention. Please provide proper rationale. > the corresponding name change done in bindings and driver. > > Signed-off-by: Jishnu Prakash > --- > arch/arm64/boot/dts/qcom/pmk8350.dtsi | 4 +- > arch/arm64/boot/dts/qcom/sc7280-idp.dts | 4 +- > arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 4 +- > arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 8 ++-- > .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 48 +++++++++---------- > arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi | 2 +- > .../boot/dts/qcom/sm7225-fairphone-fp4.dts | 4 +- > 7 files changed, 37 insertions(+), 37 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/pmk8350.dtsi b/arch/arm64/boot/dts/qcom/pmk8350.dtsi > index bc6297e7253e..149d2bb43d2d 100644 > --- a/arch/arm64/boot/dts/qcom/pmk8350.dtsi > +++ b/arch/arm64/boot/dts/qcom/pmk8350.dtsi > @@ -50,7 +50,7 @@ pon_resin: resin { > }; > > pmk8350_vadc: adc@3100 { > - compatible = "qcom,spmi-adc7"; > + compatible = "qcom,spmi-adc5-gen2"; You break all users without explaining it. Best regards, Krzysztof