From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54849C6FA8E for ; Thu, 2 Mar 2023 11:37:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229702AbjCBLhl (ORCPT ); Thu, 2 Mar 2023 06:37:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230013AbjCBLhX (ORCPT ); Thu, 2 Mar 2023 06:37:23 -0500 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F6764E5C1 for ; Thu, 2 Mar 2023 03:36:50 -0800 (PST) Received: by mail-ed1-x531.google.com with SMTP id da10so66414833edb.3 for ; Thu, 02 Mar 2023 03:36:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1677757001; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=itiw5UOLyp8x5GAZYaYv1Vs2aytftoTZFE/0BZf8oio=; b=kIXs0xzTihohuEbRt/RONHqrNwOkJLWyJD46Cg9nHpst/qa4/ITeiXi5lHVPCYKKF8 68gVD6Y6EJKS+cefqndrjM6eOIX0qoS4q0aLBHAPHOu7boPglfE/2HZ6f2jWzFUnFT/6 jduwQvKVXembm5kITS0Ycwl7VQKCra5YF2soFbTtCj9PMs1qqyp90JLvqFaKQjITG8YK 0BiuwVdH1dm3noOQzIAyNjEZlebYUB+h37E5gGxjK9iVpil71Oyz1xUx3IOHjwe+ySlF 8pAW/b1xn3j4SFZ/zcz7E+oTT4yiEJOUaiqe+XriuS8tn+J4vkyQpt2eWIKXjFXwwPMG yAJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677757001; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=itiw5UOLyp8x5GAZYaYv1Vs2aytftoTZFE/0BZf8oio=; b=zFPG/VBPc6c13mwd1hxP8HkPu1OVupNwREf2hs4XHOyKZQYBhcPzngxiS9a2WCETWI IXKeCPdl75EtsgVOSXvdQZApTjO5z7acbX/z7aXPgtGkVZ/V6V6UOG53xjLnam+n8VAj VmMYE0D4bl5juNFP6xPk8QKHSSE0vJtboIrT/M+Bw9XUtMJWb0rp1p7WNumSqnGTurfb bZgnMdQ0J5FLUtFhDpvp0xsi66RpVoSIpzKVVg4n2VuwB2gJ05PK4ZVR6N3JQU+86gyV 393+YkkLyFkm9GMt6SSkg/I4ixrRw5o7wxotmPd/yAQDG0YHkWC6gQauLgb+rzjkVBP8 aBMA== X-Gm-Message-State: AO0yUKXtDNRrkDtFJdPaoEkuVY3CYeweLIzVBx552fR1l7pLpKJabS1t ut0GrJMi1H9qKnxrcDQhEC0wgA== X-Google-Smtp-Source: AK7set8UroysICtw/tuh/i+KbnuaphWGNNH6VTX/a+cbEyQ42b9nkdxhdV//zLythoyXJt6AwhrTtg== X-Received: by 2002:a17:907:1006:b0:8b1:2e7c:df49 with SMTP id ox6-20020a170907100600b008b12e7cdf49mr11219032ejb.7.1677757001526; Thu, 02 Mar 2023 03:36:41 -0800 (PST) Received: from [192.168.1.20] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id m18-20020a1709061ed200b008d427df3245sm7007014ejj.58.2023.03.02.03.36.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Mar 2023 03:36:41 -0800 (PST) Message-ID: <83a03258-9e52-3d09-67fe-12e9e5ed4b76@linaro.org> Date: Thu, 2 Mar 2023 12:36:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [RFC PATCH 07/16] dt-bindings: pinctrl: ralink: add new compatible strings Content-Language: en-US To: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= , Rob Herring Cc: Sergio Paracuellos , Linus Walleij , Krzysztof Kozlowski , linux-mediatek@lists.infradead.org, linux-mips@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Matthias Brugger , Sean Wang , William Dean , Daniel Golle , Daniel Santos , Luiz Angelo Daros de Luca , Frank Wunderlich , Landen Chao , DENG Qingfang , Sean Wang , erkin.bozoglu@xeront.com References: <20230222183932.33267-1-arinc.unal@arinc9.com> <20230222183932.33267-8-arinc.unal@arinc9.com> <20230227173333.GA496999-robh@kernel.org> <20230301024431.GA251215-robh@kernel.org> <11d3c806-04b6-da54-65f1-c0bd154affbc@linaro.org> <1aae7ac9-c83d-71b4-4fce-325f02fcd722@linaro.org> <89588f69-9cf0-e7a4-b976-5ce87d42e296@arinc9.com> <2ccb573d-39f4-cb80-7a3e-63a60c2bc0a8@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 02/03/2023 11:47, Arınç ÜNAL wrote: > On 2.03.2023 13:29, Krzysztof Kozlowski wrote: >> On 02/03/2023 11:22, Arınç ÜNAL wrote: >>>>> >>>>> ## Incorrect naming >>>>> >>>>> MT7620, MT7621, MT7628, and MT7688 SoCs are incorrectly called Ralink, >>>>> introduce new ralink->mediatek compatible strings to address it. >>>> >>>> So this part was addressed by Rob - we don't do it, because it does not >>>> matter. Ralink is now Mediatek, thus there is no conflict and no issues >>>> with different vendor used. >>> >>> I think Rob was rather addressing that updating compatible strings based >>> on acquisition or marketing whims is not permitted. This condition does >>> not apply here as these SoCs were never Ralink. >>> >>> I understand your point that Ralink is now MediaTek but still, calling >>> these SoCs Ralink would be a bit misleading, don't you think? >> >> Misleading yes, but also does not matter. At least matter not enough to >> justify ABI break, so you would need to deprecate old ones and keep >> everything backwards compatible. You still would affect 3rd party users >> of DTS, though... > > I intend to do just that. Introduce new mediatek strings, keep the old > ones so it's backwards compatible, therefore don't break the ABI. > > Instead of deprecating old strings, I intend to introduce the checks I > mentioned, on the schema, so the pin muxing bindings only apply if the > DT has got a string that won't match multiple schemas. This way it > shouldn't affect 3rd party DTs. I meant, 3rd party users of DTS. You will replace the compatible in the DTS, right? So the DTS exported and used in all other projects, OS, firmwares, bootloaders, out of tree kernel forks will stop working. Best regards, Krzysztof