From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44CD8C6FD18 for ; Tue, 18 Apr 2023 16:35:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232495AbjDRQfY (ORCPT ); Tue, 18 Apr 2023 12:35:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232543AbjDRQfU (ORCPT ); Tue, 18 Apr 2023 12:35:20 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F4441385D for ; Tue, 18 Apr 2023 09:35:18 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id ud9so74569715ejc.7 for ; Tue, 18 Apr 2023 09:35:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681835717; x=1684427717; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bqklLL1/d8Vp5tYKo0ZG5zd2TLFgTYIUWIOvR0v621A=; b=zMCO8QAb00BwxuqKZOdexZbO4o2VgDdaMdmcYIy7S3IZi6XQpoBMuZ/5mthOoy5vwx C+JpSANMQLNtC2xNNHljZVxPEj9NVxwWXBP40CLzlUUtcB6LKpm/66nTfzTKGTIgxkwH CcJYnJ35TVLf8SWGYaM0cbY8ZgI7bbi1HAAnPRqMsFy6hAbLDVSNjhOHsGCy9is4ISlb HfsJEx/wHH6g5O/jv30gWWsZJyf+r0sC1Rutsdc6Yv1hSylUekMGP8ZEoOXZ4ebbo4aW BSNk9S6LKM8RrfbpoGI0jRb09LELrJzi4eORtsOGNfDsNRHe59e36ujnQo6gLh4wZuQf R3Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681835717; x=1684427717; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bqklLL1/d8Vp5tYKo0ZG5zd2TLFgTYIUWIOvR0v621A=; b=GJzWVvNtnwPATv7OIZLkbZo+KNOcb0oA+WSz/AWpmizCo3YZIJHs8hpoQWUsuG1UHv qQDg3gIVoNawcLrhr0j2dosvg7U+yPf4f81YfFBa9lv/+JHmib4TwjDwrqb1AquVN1Bs KhZK1tuH7l+FP5mCIVJltIcSTBJK79U0HaCdNxECceI6cZ0+4d4Jn9ygJEkcQo+Mk2sD 0ZNdw7L2q62cUXRP4UXEfACUlG9/fuxHvM/Is4sfcbyLprxVmkczLqqMkRURo1PxW9fB UNATGBZVDvE792UcfHV+qV2+9tgbUh/zlZZ2w9lYDfrRsuphtxyGHUwLnZJHhlPlQ1wr 5alA== X-Gm-Message-State: AAQBX9dktdNyxm/22yzUo3/uUOo/7S6ehDs0O9l7ROUN0YqKAM+4LgK6 2jqwzWsk/DZEo2n4Sor/k/aaQw== X-Google-Smtp-Source: AKy350aZ4vDf25kOEHBmpxkhlb1Dx2g1MoTdgqLpnICCmomELF1kDA0FHFFTa7oKFkPIiYVUTo+DpQ== X-Received: by 2002:a17:907:3f08:b0:94f:9f76:c74f with SMTP id hq8-20020a1709073f0800b0094f9f76c74fmr5561973ejc.52.1681835716901; Tue, 18 Apr 2023 09:35:16 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:a276:7d35:5226:1c77? ([2a02:810d:15c0:828:a276:7d35:5226:1c77]) by smtp.gmail.com with ESMTPSA id fy1-20020a170906b7c100b0094e4b8816e0sm8175969ejb.217.2023.04.18.09.35.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Apr 2023 09:35:16 -0700 (PDT) Message-ID: <83ac1bd0-13c4-1c4b-9d1b-7205c34122ad@linaro.org> Date: Tue, 18 Apr 2023 18:35:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 2/2] iio: light: Add support for TI OPT4001 light sensor Content-Language: en-US From: Krzysztof Kozlowski To: Stefan Windfeldt-Prytz , Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@axis.com References: <20230323-add-opt4001-driver-v1-0-1451dcc1bc8a@axis.com> <20230323-add-opt4001-driver-v1-2-1451dcc1bc8a@axis.com> <72d5b078-da9e-ccbb-1557-9cacaea68e8d@linaro.org> In-Reply-To: <72d5b078-da9e-ccbb-1557-9cacaea68e8d@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18/04/2023 18:34, Krzysztof Kozlowski wrote: > On 04/04/2023 11:07, Stefan Windfeldt-Prytz wrote: >> This driver uses the continuous mode of the chip and integration >> time can be configured through sysfs. >> The constants for calculating lux value differs between packaging >> so it uses different compatible string for the two versions >> "ti,opt4001-picostar" and "ti,opt4001-sot-5x3" since the device id >> is the same. > > Thank you for your patch. There is something to discuss/improve. > >> + >> + indio_dev->channels = opt4001_channels; >> + indio_dev->num_channels = ARRAY_SIZE(opt4001_channels); >> + indio_dev->modes = INDIO_DIRECT_MODE; >> + indio_dev->name = chip->client->name; >> + >> + of_id = of_match_device(of_match_ptr(opt4001_of_match), &client->dev); > > ? Drop of_match_ptr Ah, this is old patch... so maybe you already did this. Best regards, Krzysztof