From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28292C6FD1C for ; Sun, 26 Mar 2023 10:13:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231422AbjCZKNT (ORCPT ); Sun, 26 Mar 2023 06:13:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230292AbjCZKNQ (ORCPT ); Sun, 26 Mar 2023 06:13:16 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B9FA358E for ; Sun, 26 Mar 2023 03:13:13 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id t10so24378692edd.12 for ; Sun, 26 Mar 2023 03:13:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679825592; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MOh4lC4EpmD6D3IsSXbrUjZG6ycDZwmCNEwAzeoH1FQ=; b=xe3VuwN4Ew16g8dK3fS72dD7DoMqWCfpxH2cYkvrulfZLAAFccoNSAP1wDTjJPg7so 2miZ3d/n6zwx2aLARZVLLw3X4gRqznCFw7Rllq560862ZmkDgfwdfFUO86qin8uFv/td c+Ttf5lrMlasAnGarYO36lM3pbJBpwuakPbhTyzb8m3TPfTx53/SFLELNt4yPCh8lFeI nD9inVGSNGPnTtfuoqr+ki32H+M03jUAMMJpUmPSnv20ijJ/OoEq/QD8zQ1Ex2X/QtrN k8jJXDO2ICGxbC30kijnumArQx+wd5oMJgNUOcUBoSra6fap5VFIzYaZStOsGpPPQbTR 4GoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679825592; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MOh4lC4EpmD6D3IsSXbrUjZG6ycDZwmCNEwAzeoH1FQ=; b=ML6C7Wj7jYw8oFKqLGcjJZBnHzSZ/PKDesQB5g8kBgdp9bLc54I4M8vmOGC4S70QDx wzolc+SLPFrf4QYf/7+6K8yQsUA1G/YlmPbYpmZ3hQU4Uvb0pXKGCihdMFkjFrhIhwhp dyXLPTWOv/sTzdMSKLgzusCZFPVXgaRtoxhcX8/7wcanmoEBLzIXoIsPrndAq7MnQEAe csix1NpLVPF3W/IssyOL+K/eeINWfbgPBQ8wDQcOrRIV7qoqfcgcxVIxS/n8JqTgMlYS BSfqhS5UXGOn0ZXPT0Yb97dmdOxvgWfE5Irj1jyl1ewiRerBgj4gY9hxP2jgS6RYnv1z /Gvw== X-Gm-Message-State: AAQBX9e9Kk2bRtBCBAR86sX1n7BQZgwpHaqeU06e57cm76doy/KU0Xom 9drXU0Y3oOrcVtoCA0P7iKjUBw== X-Google-Smtp-Source: AKy350b/CpcoRKdk5/rSN0V752Q+031uCPvdlGTc1KTIxeFnGCZF//nkNLeyvGT5IiBmK3/EG7pg4g== X-Received: by 2002:aa7:d291:0:b0:4fb:59bb:ce7c with SMTP id w17-20020aa7d291000000b004fb59bbce7cmr8324123edq.32.1679825591993; Sun, 26 Mar 2023 03:13:11 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:6cac:926d:a4f2:aa09? ([2a02:810d:15c0:828:6cac:926d:a4f2:aa09]) by smtp.gmail.com with ESMTPSA id r3-20020a50aac3000000b004fccef39ec9sm13384888edc.70.2023.03.26.03.13.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Mar 2023 03:13:11 -0700 (PDT) Message-ID: <83b657c3-5a78-1c81-fea5-5679a30bd517@linaro.org> Date: Sun, 26 Mar 2023 12:13:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2] arm64: dts: qcom: sdm630: move DSI opp-table out of soc node Content-Language: en-US To: Dmitry Baryshkov Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230326091605.18908-1-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26/03/2023 12:03, Dmitry Baryshkov wrote: > On Sun, 26 Mar 2023 at 12:22, Krzysztof Kozlowski > wrote: >> >> On 26/03/2023 11:21, Dmitry Baryshkov wrote: >>> On Sun, 26 Mar 2023 at 12:16, Krzysztof Kozlowski >>> wrote: >>>> >>>> The soc node is supposed to have only device nodes with MMIO addresses, >>>> so move the DSI OPP out of it (it is used also by second DSI1 on >>>> SDM660): >>> >>> This raises a question: would it make sense to add /opps to handle all >>> opp tables? >> >> We didn't add it to any other cases like this (and we already fixed all >> other boards), so why now? We can but it is a bit late for it. > > Because nobody expressed this idea beforehand? I'm not insisting here, > you have a better understanding of DT. Just wondering if it makes > sense. It will not change much of ordering - all nodes will be close to each other anyway (opp-table-XYZ), thus is rather a matter of readability and subjective preference. No other platforms have "opps" or "opp-tables". Best regards, Krzysztof