From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Lin, Meng-Bo" <linmengbo0689@protonmail.com>,
linux-kernel@vger.kernel.org
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Stephan Gerhold <stephan@gerhold.net>,
Nikita Travkin <nikita@trvn.ru>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 3/8] arm64: dts: qcom: msm8939-samsung-a7: Add touch key
Date: Thu, 22 Jun 2023 17:11:48 +0200 [thread overview]
Message-ID: <83b95d08-e32e-3d57-cf00-3c40e0e44ee3@linaro.org> (raw)
In-Reply-To: <20230622020448.65791-1-linmengbo0689@protonmail.com>
On 22/06/2023 04:04, Lin, Meng-Bo wrote:
> Add the CORERIVER TC360 touch key together with the necessary
> fixed regulator for it.
>
> Note that for some reason Samsung decided to connect this to GPIOs
> where no hardware I2C bus is available, so we need to fall back
> to software bit-banging using i2c-gpio.
Squash patches doing one logical change. That change is: adding new
board. Since you sent it as one patchset, then one commit is to add new
DTS. There is no point in sending piece of board and immediately another
piece. It's not release early, release often.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-22 15:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 2:03 [PATCH 0/8] arm64: dts: qcom: msm8939-samsung-a7: Add initial dts Lin, Meng-Bo
2023-06-22 2:04 ` [PATCH 1/8] dt-bindings: qcom: Document msm8939,a7 Lin, Meng-Bo
2023-06-22 14:41 ` Rob Herring
2023-06-22 2:04 ` [PATCH 2/8] arm64: dts: qcom: msm8939-samsung-a7: Add initial dts Lin, Meng-Bo
2023-06-22 2:04 ` [PATCH 3/8] arm64: dts: qcom: msm8939-samsung-a7: Add touch key Lin, Meng-Bo
2023-06-22 15:11 ` Krzysztof Kozlowski [this message]
2023-06-22 2:05 ` [PATCH 4/8] arm64: dts: qcom: msm8939-samsung-a7: Add accelerometer/magnetometer Lin, Meng-Bo
2023-06-22 2:05 ` [PATCH 5/8] arm64: dts: qcom: msm8939-samsung-a7: Add rt5033 battery Lin, Meng-Bo
2023-06-22 2:05 ` [PATCH 6/8] arm64: dts: qcom: msm8939-samsung-a7: Add NFC Lin, Meng-Bo
2023-06-22 2:05 ` [PATCH 7/8] arm64: dts: qcom: msm8939-samsung-a7: Add vibrator Lin, Meng-Bo
2023-06-22 2:06 ` [PATCH 8/8] arm64: dts: qcom: msm8939-samsung-a7: Add touchscreen Lin, Meng-Bo
2023-06-23 10:01 ` [PATCH v2 0/2] arm64: dts: qcom: msm8939-samsung-a7: Add initial dts Lin, Meng-Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83b95d08-e32e-3d57-cf00-3c40e0e44ee3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linmengbo0689@protonmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita@trvn.ru \
--cc=robh+dt@kernel.org \
--cc=stephan@gerhold.net \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).