From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E4EAC2D1 for ; Fri, 9 May 2025 15:19:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746803984; cv=none; b=kddiAMK0gCLiwjD8JuEVAU72RP9tH8hGc6uCyEDKFN3loBK99zRLg7NaC5f4ih1QGFYVQUBPlA5mUSG2XgH8/e93JTjmxWRgOEcwQ8s9LiLPp8+8ZHJxuNcsmMtJ2A42OK0+E65fJ0XFTik8I0lzHFpZrlGFAXX9C49DD74v+ps= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746803984; c=relaxed/simple; bh=+QfR8Np8mmi9dnZBXYk5XMcsA9L4g7b0+Z1hkFIgtLI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bXpEHpzWwF/gStiyzemVDRkP+Te8vnuZdu0mFQTpGPBo+tiRY9BneWWhxznT38R0fel4wqrUVrzscL9wnMtBK26vEWqd1YNNlcBwCFdm8JAg6vrSQuA3gLgjvW8ixk/Uv9cP9B5/5nGpVQPl6kturGE/oXQ7q/hYQ+bAr+3jWoc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GVudo9SM; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GVudo9SM" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 549Bw53m010796 for ; Fri, 9 May 2025 15:19:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= DTdhhYB6FCC5ZtrJ/082OOPt7NU3J5IYSW/Bpjk2brs=; b=GVudo9SMBROW5p8m HdJcRSKDOb8lNKAXW7PcwYnh6TA3a1JEWL/K9noFutY54pjNHHBgXFB+Dj1tNXje 8VXChvnEYop18fYt4XmxSHbGXBzYKQJSGV2Fm4PtvdlzJ/2j562Yuxv+M98Vcr88 gyc9WpZB5Ld8mSSKJxeFqIeWmFkDB3nDyGHryE13DfwEJF6Lms0rzo2uD9/NQ+ND YRUWJ9E0ZW+y0kgJwy2vKLDYRlYk0muv2unr/Cr14ozmaMUXy/DKvExiTE9G/b65 TkXLheoaLz9xsb764K4kWi5WkhrkKyPUGGf+DonBXWsT5XPQvd8DJXwt7TP2Wdcm tpSI/A== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46gnp7d62b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 09 May 2025 15:19:41 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7caef20a527so550486285a.3 for ; Fri, 09 May 2025 08:19:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746803977; x=1747408777; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DTdhhYB6FCC5ZtrJ/082OOPt7NU3J5IYSW/Bpjk2brs=; b=EHKFcQtze9TfYJu/7WIIM4PwMduTWK54kvvCUh9erpHC16hcbU8Wld/kQG/KEoR4Jj wvYGNPO3x6dvZUXjN12ANWTgsa1SWBxTSMwL7KDRFPV0SP2Fe7NrFiQylvqmOfGpTdAU mqDg0xNIv7cTpQiUXI5z55AO6VCCLP4a1nzmACNt1C2gVa1OTUND/Y4biB85Vv6NmyJS aZSLly+JQEKQQA/sK14G3fVY6a+CwchGtk3sszqo0W/1dHgmY5Cp0mNTpkTBNAkg0+03 jXiEBqOW3uMio6DwGNiHQ5+dgG+7I+89njuoTEYCH+M6An+NbK+UZrfjQV4g2p9N1v7U rfgg== X-Forwarded-Encrypted: i=1; AJvYcCUt98U0OehbTZYCGx79Umjo1rNtLH7m8xZq+GAj63KaNVlpSwgo16uDdBKbzH+++QuFTIxewhB+Y9KZ@vger.kernel.org X-Gm-Message-State: AOJu0YwdiKLy7iFE/vv7X+s4XSBGyf6OdbbeT+MpW+X4btbpKVxqw9Bt 8OtZuMmWmOZW5QqOKiKa15kpcIz1z7/cLljrQQe1K898tRhH7cqi2dQmMY8n/FgFRpnauXy6rtU 3tkPRowF0r/jM+x9KV61vXVnIwl7NJrs3lIKONWyWZk2I6pKsBH2MB9YMLjvfV8znYB8F X-Gm-Gg: ASbGnctPXf3H1/9Fkwu6D4usc6gwmpbsHmnM6FGwqynSUQcC0Jw88qJ4sz3/oD/ewZk DP0xCkgMmDhumi8+SxfcvbVph7eR4ApBYORuZRnOIarX8ZBfhnehgRDmXlw2uhH8cur0YQh4V3d ne0bsh1g4pZqVNLaO+eyZ81GPJIRbPYc/PhqRZ4yVLhVjIc0osYdqzpZYpy37m0ppbUFPEBooP9 1CRrnvcyj8sdxs+pwTbG+f4E6YBbsdmD45DWEaiu0JXjV+yy11jxnLWyt4zYz8HGmIDkEUSFyDp rNqv91qRn+5JGyBJ2Y/LDWIfBuucwWocSX2kGbbhZmwlUhtoC/s2GpeAnMgi5wj1Tvl1Ykj5EQm JK6dEEFLcegRSEtz9RX5w/+AThV/cW24H1yrLKhrCBvyGtJaYs7itw3X782NDk+Qt X-Received: by 2002:a05:620a:444d:b0:7c5:407e:1ff8 with SMTP id af79cd13be357-7cd010f187bmr435463485a.2.1746803977439; Fri, 09 May 2025 08:19:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGxxH7nrk/AqG3hrr28OmJOlY7nRUo0lL9q5nufep0/yH/q/o1vYXrEJA392S7p+PHBN12kSQ== X-Received: by 2002:ad4:5dcf:0:b0:6f6:33aa:258b with SMTP id 6a1803df08f44-6f6e48222e6mr62260126d6.45.1746803965858; Fri, 09 May 2025 08:19:25 -0700 (PDT) Received: from ?IPV6:2001:14bb:a6:738a:e519:cad2:e720:53eb? (2001-14bb-a6-738a-e519-cad2-e720-53eb.rev.dnainternet.fi. [2001:14bb:a6:738a:e519:cad2:e720:53eb]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54fc645d03asm306482e87.95.2025.05.09.08.19.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 May 2025 08:19:25 -0700 (PDT) Message-ID: <83ba11db-9a9e-48b7-afe0-9df7b5de3e85@oss.qualcomm.com> Date: Fri, 9 May 2025 18:19:23 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/7] Convert inno hdmi to drm bridge To: Andy Yan Cc: =?UTF-8?Q?Heiko_St=C3=BCbner?= , conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org, hjc@rock-chips.com, mripard@kernel.org, neil.armstrong@linaro.org, knaerzche@gmail.com, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Andy Yan References: <20250422070455.432666-1-andyshrk@163.com> <9503607.rMLUfLXkoz@diego> <1a07d69.1e47.196b2c3aa12.Coremail.andyshrk@163.com> Content-Language: en-US From: Dmitry Baryshkov In-Reply-To: <1a07d69.1e47.196b2c3aa12.Coremail.andyshrk@163.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTA5MDE1MSBTYWx0ZWRfX2Cy4m0jjgjeX O29op3GCw+vZKjsuPT82RDudTt8XVoIOXn0P23RJoVH9TJXTqoI37vi5kSca5IihPBVAaBL+ajj 9D8+VNui9L5VsqbblkV6COadP3DQ85xDdPqdpiMtKRQQM0yJ/KkoFePOpsSOFTX4Qc8a1/jW0zn sEnC6CRD2Ec6dNW9MOBPXluEBv9ecLc0Rsr2DGoiPOe8XEww8LllI2nHmROdO2uuNvUOvCXmlYm F3X2Cocse4B3JK1rMnK6s6yS8DadGhbwpZDgvPNNOoJx0dCrrvPp0/OXIZeF81cyDL00M3asb/Y JD5X32YdibI2Xm3qpHzAqgLe/nJJsEz6Se1+U0O5hf0dG24kEDBT71xdq4vWjqTPJpXMkfC3dDE 8UpcL6T+ryfmbt1SfES0bRM5QdY46EjqAGSz1Z6fUm8H7cPsU6Ku6s9RYIC7HssVqiOqNsMH X-Proofpoint-GUID: LOT6ZrJ5fxugMj6c5Lr-UqtltXntbfe9 X-Authority-Analysis: v=2.4 cv=B/G50PtM c=1 sm=1 tr=0 ts=681e1d0d cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=EUspDBNiAAAA:8 a=s8YR1HE3AAAA:8 a=U4mCzpOltDhEmR4TI6sA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=jGH_LyMDp9YhSvY-UuyI:22 X-Proofpoint-ORIG-GUID: LOT6ZrJ5fxugMj6c5Lr-UqtltXntbfe9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-09_06,2025-05-09_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 spamscore=0 suspectscore=0 phishscore=0 priorityscore=1501 bulkscore=0 adultscore=0 mlxlogscore=999 malwarescore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2505090151 On 09/05/2025 04:58, Andy Yan wrote: > > Hi Dmitry, > > Thanks for you review. > > 在 2025-05-05 00:16:35，"Dmitry Baryshkov" 写道： >> On Sat, May 03, 2025 at 04:42:04PM +0200, Heiko Stübner wrote: >>> Am Dienstag, 22. April 2025, 09:04:39 Mitteleuropäische Sommerzeit schrieb Andy Yan: >>>> From: Andy Yan >>>> >>>> When preparing to convert the current inno hdmi driver into a >>>> bridge driver, I found that there are several issues currently >>>> existing with it: >>>> >>>> 1. When the system starts up, the first time it reads the EDID, it >>>> will fail. This is because RK3036 HDMI DDC bus requires it's PHY's >>>> reference clock to be enabled first before normal DDC communication >>>> can be carried out. >>>> >>>> 2. The signal is unstable. When running the glmark2 test on the screen, >>>> there is a small probability of seeing some screen flickering. >>>> This is because The HSYNC/VSYNC polarity of rk3036 HDMI are controlled >>>> by GRF. This part is missing in the current driver. >>>> >>>> PATCH 1~6 are try to Fix Document in the dt-binding, then add the >>>> missing part in driver and dts. >>>> PATCH 7 converts the curren driver to drm bridge mode. >>> >>> After resurrecting my rk3036-kylin which hasn't sucessfully booted in a >>> while, I could veryify this series, so on a rk3036-kylin >>> >>> Tested-by: Heiko Stuebner >>> >>> >>> I'll probably apply patches 1-4 to drm-misc later today, as that solely >>> touches the Rockchip (and only rk3036-)side and patches 5+6 to the >>> rockchip tree. >>> >>> Patch 7 should probably get some attention by people more familiar with >>> drm-bridges, so I'll let that sit for a bit longer. >> >> I will take a look later, but on the first glance it looks like there >> are too many things going on in that patch, including some unnecessary >> fnction movements and define movements, etc. I would kindly ask to split > > These registers were initially defined in a separate header file(inno_hdmi.h), > but they were only used by a single C file, so I think it's not necessary to put > them in a separate header file. I decided to simply merge them into the inno_hdmi.c file. > If I first create a patch and separately carry out the merging of this register definition, would that be possible? Yes, just create a separate commit, folding the header into the source file. > > And I will try to avoid function movements in next version. > > >> the non-functional refactorings and the functional ones (splitting to a >> library, etc). > > Will do in next version. > >> >>> >>> >>> Thanks a lot for working on all this >>> Heiko >>> >>> >> >> -- >> With best wishes >> Dmitry -- With best wishes Dmitry