From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-180.mta0.migadu.com (out-180.mta0.migadu.com [91.218.175.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C00791C5489 for ; Tue, 1 Apr 2025 20:13:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743538401; cv=none; b=D1NzNZKucpnnqST/eR1GxfNLm4DdgmTAVIQKtCNVHVyD0UpvBzmqgTUup0sprZYgDSzP9krEYBxZoavpJ2iaQ+CsJ0mGB9UTuyUNcuvbO3k3mzMmx1gNefVNLUj724riJTtCl5EtANiJjUwYt497GJ7j1NgPzKJYF+iv9EuxFGo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743538401; c=relaxed/simple; bh=eR/YG4GZyqt/XnIjqOcSz8pWI6XUwLriVsH7q4VEKSw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eDWiy6OuMggkUl/W2/lE3cwtF7+zJwEgiPKe/NT4R0YU9JxDSBSRgvAUaWUiGRe4Xvy6E9uV7I7BlD0mg0gCSiwf9OYoJsQps2D66gt4ffzJ4DRN5jofauEFc+Q6OSiS7OP5k2pMiDY7/1jpBAilxbugWf74N9IiwXcXuJ1m3Do= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=gXIMIfqd; arc=none smtp.client-ip=91.218.175.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="gXIMIfqd" Message-ID: <83c02df7-25c7-44d4-a0b6-d771061dc5c5@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1743538385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pbsnLA4xc9KhhaMRrdi3YWrFr+lgbctl9xbpkqw1/Vc=; b=gXIMIfqdh1UPRoCM1zQ+48q1QUGmgI2WQLBofZDwLv5UW09MbyqEag45d7LaKSCgahnWj1 ndlB9KZrbYsqcNCo2wsxOxIvLM+o6dkT/JFEwzAjVURRr9MFFTbfwk33TkSIuGNnXAS1Do aEIZ78gLidJvAYVGjpjGYqvn7Cb3/ZU= Date: Tue, 1 Apr 2025 16:12:59 -0400 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [net-next PATCH 4/6] dt-bindings: net: ethernet-controller: permit to define multiple PCS To: Christian Marangi , Rob Herring Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Conor Dooley , Heiner Kallweit , Russell King , Philipp Zabel , Daniel Golle , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, upstream@airoha.com References: <20250318235850.6411-1-ansuelsmth@gmail.com> <20250318235850.6411-5-ansuelsmth@gmail.com> <20250321161812.GA3466720-robh@kernel.org> <67e57382.050a0220.3ce63f.a120@mx.google.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <67e57382.050a0220.3ce63f.a120@mx.google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 3/27/25 11:49, Christian Marangi wrote: > On Fri, Mar 21, 2025 at 11:18:12AM -0500, Rob Herring wrote: >> On Wed, Mar 19, 2025 at 12:58:40AM +0100, Christian Marangi wrote: >> > Drop the limitation of a single PCS in pcs-handle property. Multiple PCS >> > can be defined for an ethrnet-controller node to support various PHY >> >> typo >> >> > interface mode type. >> >> What limitation? It already supports multiple PCS phandles. It doesn't >> support arg cells. If you want that, either you have to fix the number >> of cells or define a #pcs-handle-cells property. You've done neither >> here. >> >> Adding #pcs-handle-cells will also require some updates to the dtschema >> tools. >> > > I might be confused by doesn't > > pcs-handle: > items: > maxItems: 1 > > limit it to > > pcs-handle = <&foo>; > > and make it not valid > > pcs-handle = <&foo1>, <&foo2>; > > ? You should modify this in the MAC's devicetree. See Documentation/devicetree/bindings/net/fsl,fman-dtsec.yaml for an example. > The cells property will come but only when there will be an actual user > for it (I assume QCOM PCS will make use of it) I think it would be better to add this as necessary. --Sean