devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Stefan Wahren <stefan.wahren@i2se.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>
Cc: kernel@pengutronix.de, Fabio Estevam <festevam@gmail.com>,
	linux-imx@nxp.com, "Rafael J . Wysocki" <rafael@kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Amit Kucheria <amitk@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-crypto@vger.kernel.org, devicetree@vger.kernel.org,
	linux-serial@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
	Jacky Bai <ping.bai@nxp.com>
Subject: Re: [PATCH V2 6/6] ARM: dts: imx6ul: Add clock and PGC node to GPC
Date: Tue, 11 Apr 2023 07:46:07 +0200	[thread overview]
Message-ID: <83c098ed-a9f4-e856-fea7-c8714c1cc1aa@linaro.org> (raw)
In-Reply-To: <20230410205803.45853-7-stefan.wahren@i2se.com>

On 10/04/2023 22:58, Stefan Wahren wrote:
> According to fsl,imx-gpc.yaml the General Power Control requires
> a ipg clock and a Power Gating Control node. So add them to fix
> the dtbs_check warnings on i.MX6UL boards:
> 
> gpc@20dc000: 'clocks' is a required property
> gpc@20dc000: 'clock-names' is a required property
> gpc@20dc000: 'pgc' is a required property
> 
> Suggested-by: Jacky Bai <ping.bai@nxp.com>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
>  arch/arm/boot/dts/imx6ul.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
> index 118764c50d92..a8efaed69214 100644
> --- a/arch/arm/boot/dts/imx6ul.dtsi
> +++ b/arch/arm/boot/dts/imx6ul.dtsi
> @@ -719,6 +719,18 @@ gpc: gpc@20dc000 {
>  				#interrupt-cells = <3>;
>  				interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>;
>  				interrupt-parent = <&intc>;
> +				clocks = <&clks IMX6UL_CLK_IPG>;
> +				clock-names = "ipg";
> +
> +				pgc {
> +						#address-cells = <1>;
> +						#size-cells = <0>;

Wrong indentation.

Best regards,
Krzysztof


      reply	other threads:[~2023-04-11  5:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-10 20:57 [PATCH V2 0/6] ARM: dts: imx6ull: Fix dtbs_check warnings Stefan Wahren
2023-04-10 20:57 ` [PATCH V2 1/6] dt-bindings: serial: fsl-imx-uart: add missing properties Stefan Wahren
2023-04-11  5:46   ` Krzysztof Kozlowski
2023-04-10 20:57 ` [PATCH V2 2/6] dt-bindings: crypto: fsl-dcp: add imx6sl and imx6ull compatible Stefan Wahren
2023-04-11  5:47   ` Krzysztof Kozlowski
2023-04-10 20:58 ` [PATCH V2 3/6] dt-bindings: imx-thermal: add imx6sll and imx6ul compatible Stefan Wahren
2023-04-11  5:47   ` Krzysztof Kozlowski
2023-04-17  7:40   ` Daniel Lezcano
2023-04-10 20:58 ` [PATCH V2 4/6] dt-bindings: imxgpt: add " Stefan Wahren
2023-04-11  5:48   ` Krzysztof Kozlowski
2023-04-10 20:58 ` [PATCH V2 5/6] ARM: dts: imx: Adjust dma-apbh node name Stefan Wahren
2023-04-10 20:58 ` [PATCH V2 6/6] ARM: dts: imx6ul: Add clock and PGC node to GPC Stefan Wahren
2023-04-11  5:46   ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83c098ed-a9f4-e856-fea7-c8714c1cc1aa@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=amitk@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=ping.bai@nxp.com \
    --cc=rafael@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=stefan.wahren@i2se.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).