Devicetree
 help / color / mirror / Atom feed
From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Rosen Penev <rosenp@gmail.com>, devicetree@vger.kernel.org
Cc: Johannes Berg <johannes@sipsolutions.net>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	van Spriel <arend@broadcom.com>,
	"open list:NETWORKING DRIVERS (WIRELESS)"
	<linux-wireless@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv2] dt-bindings: net: brcm,bcm4329-fmac: add nvmem-cells for MAC address
Date: Sun, 16 Aug 2026 11:43:41 +0200	[thread overview]
Message-ID: <83ef9f7b-4145-4985-b157-6fb9fbb0b3f0@broadcom.com> (raw)
In-Reply-To: <20260811192829.123410-1-rosenp@gmail.com>

On 11/08/2026 21:28, Rosen Penev wrote:
> The nvmem-cells and nvmem-cell-names properties are used to supply a
> MAC address to the brcmfmac wireless controller. Nodes such as
> bcm4709-linksys-ea9200.dts fail dtbs_check with:
> 
>      Unevaluated properties are not allowed ('nvmem-cell-names',
>      'nvmem-cells' were unexpected)
> 
> nvmem-consumer.yaml cannot be referenced from the common
> network-class.yaml because it does not constrain the number of entries
> or their names, and not all network devices use the same cell names.
> Each binding that uses nvmem must therefore define its own
> nvmem-cells/nvmem-cell-names constraints, like ethernet-controller.yaml
> and qca,ath9k.yaml already do.
> 
> Add the single-cell, mac-address-only constraints to the
> brcm,bcm4329-fmac binding.
> 
> Assisted-by: opencode:deepseek-v4-flash-free

Probably for this v2 it is better to say:

Suggested-by: Rob Herring <robh@kernel.org>

> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
>   v2: don't use nvmem-consumer.yaml
>   .../bindings/net/wireless/brcm,bcm4329-fmac.yaml           | 7 +++++++
>   1 file changed, 7 insertions(+)

      parent reply	other threads:[~2026-08-16  9:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11 19:28 [PATCHv2] dt-bindings: net: brcm,bcm4329-fmac: add nvmem-cells for MAC address Rosen Penev
2026-08-11 19:39 ` sashiko-bot
2026-08-16  9:43 ` Arend van Spriel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ef9f7b-4145-4985-b157-6fb9fbb0b3f0@broadcom.com \
    --to=arend.vanspriel@broadcom.com \
    --cc=arend@broadcom.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=johannes@sipsolutions.net \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=rosenp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox