From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Renjiang Han <quic_renjiang@quicinc.com>,
Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Stanimir Varbanov <stanimir.varbanov@linaro.org>
Subject: Re: [PATCH v5 3/4] arm64: dts: qcom: qcs615: add venus node
Date: Tue, 17 Dec 2024 09:38:12 +0000 [thread overview]
Message-ID: <83fcb683-d610-4e47-bcce-128453a0afef@linaro.org> (raw)
In-Reply-To: <20241217-add-venus-for-qcs615-v5-3-747395d9e630@quicinc.com>
On 17/12/2024 09:17, Renjiang Han wrote:
> +
> + video-decoder {
> + compatible = "venus-decoder";
> + };
> +
> + video-encoder {
> + compatible = "venus-encoder";
> + };
I gave you feedback on this in v4.
Could you please provide some commentary on why you're persisting with
this ?
- Driver configuration should not live in dts
- A patchset exists to mitigate this
- If you don't want to use that series, what do you propose
to resolve this ?
Please don't just ignore feedback, either act on it or add to your
commit log _why_ you didn't act on it.
---
bod
next prev parent reply other threads:[~2024-12-17 9:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 9:17 [PATCH v5 0/4] media: venus: enable venus on qcs615 Renjiang Han
2024-12-17 9:17 ` [PATCH v5 1/4] dt-bindings: media: add support for video hardware Renjiang Han
2024-12-17 12:40 ` Krzysztof Kozlowski
2024-12-17 12:40 ` Krzysztof Kozlowski
2024-12-18 2:30 ` Renjiang Han
2024-12-17 9:17 ` [PATCH v5 2/4] media: venus: core: use opp-table for the frequency Renjiang Han
2024-12-17 9:17 ` [PATCH v5 3/4] arm64: dts: qcom: qcs615: add venus node Renjiang Han
2024-12-17 9:38 ` Bryan O'Donoghue [this message]
2024-12-17 9:54 ` Renjiang Han
2024-12-17 11:01 ` Bryan O'Donoghue
2024-12-18 6:09 ` Renjiang Han
2024-12-17 12:09 ` Dmitry Baryshkov
2024-12-18 6:13 ` Renjiang Han
2024-12-17 9:17 ` [PATCH v5 4/4] arm64: dts: qcom: qcs615-ride: enable " Renjiang Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fcb683-d610-4e47-bcce-128453a0afef@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_renjiang@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=robh@kernel.org \
--cc=stanimir.k.varbanov@gmail.com \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).