devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tomasz Figa <t.figa@samsung.com>
To: Andrzej Hajda <a.hajda@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
	Kukjin Kim <kgene.kim@samsung.com>,
	Mike Turquette <mturquette@linaro.org>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	"moderated list:OPEN FIRMWARE AND..."
	<devicetree@vger.kernel.org>,
	"moderated list:ARM/S5P EXYNOS AR..."
	<linux-samsung-soc@vger.kernel.org>
Subject: Re: [PATCH v2 00/12] clk/exynos convert clock IDs to macros
Date: Fri, 06 Sep 2013 13:19:49 +0200	[thread overview]
Message-ID: <8412301.YP2zzplWoe@amdc1227> (raw)
In-Reply-To: <1378462361-13680-1-git-send-email-a.hajda@samsung.com>

Hi Andrzej,

On Friday 06 of September 2013 12:12:29 Andrzej Hajda wrote:
> Hi,
> 
> This patch set adds headers with defines of exynos clocks.
> Then it converts dts files and drivers to use macros instead
> of magic numbers/enums to describe clock bindings.
> 
> The patch set is based on the latest mturquette/clk-next branch.
> 
> The patches are generated by script.
> I have verified random clocks by hand.
> I have also tested it on exynos4 based board.
> 
> This is the 2nd version of the patchset.
> Changes:
> - corrected devicetree mailing list,
> - added comments to include/dt-bindings/clock/exynos4.h for
>   clocks present only in particular chip,
> - added tab alignement in headers,
> - added comment to CLK_NR_CLKS,
> - added copyright headers,
> - split long lines in dts,
> - corrected example in bindings/clock/exynos5250-clock.txt, to point
>   appropriate clocks.
> 
> Regards
> Andrzej
> 
> Andrzej Hajda (12):
>   ARM: exynos4: create a DT header defining CLK IDs
>   ARM: dts: exynos4: convert magic numbers to macros in clock bindings
>   clk: exynos4: replace clock ID private enums with IDs from DT header
>   ARM: exynos5250: create a DT header defining CLK IDs
>   ARM: dts: exynos5250: convert magic numbers to macros in clock
>     bindings
>   clk: exynos5250: replace clock ID private enums with IDs from DT
>     header
>   ARM: exynos5420: create a DT header defining CLK IDs
>   ARM: dts: exynos5420: convert magic numbers to macros in clock
>     bindings
>   clk: exynos5420: replace clock ID private enums with IDs from DT
>     header
>   ARM: exynos5440: create a DT header defining CLK IDs
>   ARM: dts: exynos5440: convert magic numbers to macros in clock
>     bindings
>   clk: exynos5440: replace clock ID private enums with IDs from DT
>     header
> 
>  .../devicetree/bindings/clock/exynos4-clock.txt    | 259 +------
>  .../devicetree/bindings/clock/exynos5250-clock.txt | 160 +---
>  .../devicetree/bindings/clock/exynos5420-clock.txt | 184 +----
>  .../devicetree/bindings/clock/exynos5440-clock.txt |  45 +-
>  arch/arm/boot/dts/exynos4.dtsi                     |  55 +-
>  arch/arm/boot/dts/exynos4210.dtsi                  |   6 +-
>  arch/arm/boot/dts/exynos4412.dtsi                  |   2 +-
>  arch/arm/boot/dts/exynos4x12.dtsi                  |   2 +-
>  arch/arm/boot/dts/exynos5250.dtsi                  |  92 +--
>  arch/arm/boot/dts/exynos5420.dtsi                  |  13 +-
>  arch/arm/boot/dts/exynos5440.dtsi                  |  27 +-
>  drivers/clk/samsung/clk-exynos4.c                  | 857
> ++++++++++----------- drivers/clk/samsung/clk-exynos5250.c              
> | 501 ++++++------ drivers/clk/samsung/clk-exynos5420.c               |
> 648 ++++++++-------- drivers/clk/samsung/clk-exynos5440.c              
> |  81 +-
>  include/dt-bindings/clock/exynos4.h                | 244 ++++++
>  include/dt-bindings/clock/exynos5250.h             | 157 ++++
>  include/dt-bindings/clock/exynos5420.h             | 188 +++++
>  include/dt-bindings/clock/exynos5440.h             |  42 +
>  19 files changed, 1734 insertions(+), 1829 deletions(-)
>  create mode 100644 include/dt-bindings/clock/exynos4.h
>  create mode 100644 include/dt-bindings/clock/exynos5250.h
>  create mode 100644 include/dt-bindings/clock/exynos5420.h
>  create mode 100644 include/dt-bindings/clock/exynos5440.h

I believe this series should be rebased on top of my series (and possibly 
remaining patches touching clock numbers queued on the list):
[PATCH v2 00/16] Exynos clock clean-up for 3.12
http://thread.gmane.org/gmane.linux.kernel.samsung-soc/22514

Otherwise, it's really nice to finally see this being cleaned up, so:
Acked-by: Tomasz Figa <t.figa@samsung.com>

Best regards,
Tomasz

  parent reply	other threads:[~2013-09-06 11:19 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-06 10:12 [PATCH v2 00/12] clk/exynos convert clock IDs to macros Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 01/12] ARM: exynos4: create a DT header defining CLK IDs Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 02/12] ARM: dts: exynos4: convert magic numbers to macros in clock bindings Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 03/12] clk: exynos4: replace clock ID private enums with IDs from DT header Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 04/12] ARM: exynos5250: create a DT header defining CLK IDs Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 05/12] ARM: dts: exynos5250: convert magic numbers to macros in clock bindings Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 06/12] clk: exynos5250: replace clock ID private enums with IDs from DT header Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 07/12] ARM: exynos5420: create a DT header defining CLK IDs Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 08/12] ARM: dts: exynos5420: convert magic numbers to macros in clock bindings Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 09/12] clk: exynos5420: replace clock ID private enums with IDs from DT header Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 10/12] ARM: exynos5440: create a DT header defining CLK IDs Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 11/12] ARM: dts: exynos5440: convert magic numbers to macros in clock bindings Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 12/12] clk: exynos5440: replace clock ID private enums with IDs from DT header Andrzej Hajda
2013-09-06 11:19 ` Tomasz Figa [this message]
2013-09-12 10:50   ` [PATCH v2 00/12] clk/exynos convert clock IDs to macros Kukjin Kim
2013-09-12 11:12     ` Tomasz Figa
     [not found]     ` <070001ceafa5$d4d81a40$7e884ec0$%kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-09-16 14:33       ` Sylwester Nawrocki
     [not found]         ` <523716C9.3000204-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-09-16 19:37           ` Mike Turquette
2013-09-26 12:21             ` Andrzej Hajda
2013-09-30 10:11             ` Kukjin Kim
     [not found]               ` <06c101cebdc5$75a83d10$60f8b730$%kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-10-02  1:09                 ` Mike Turquette
2013-10-05  2:16                   ` Kukjin Kim
2013-10-06 20:27                     ` Mike Turquette
2013-10-07  8:46                       ` Andrzej Hajda
2013-10-28 14:31                         ` Andrzej Hajda
2013-10-28 15:03                           ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8412301.YP2zzplWoe@amdc1227 \
    --to=t.figa@samsung.com \
    --cc=a.hajda@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kgene.kim@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mturquette@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).