[PATCH v3 0/6] Add support Relfor Saib board which is based on Rockchip RV1109 SoC

[PATCH v3 0/6] Add support Relfor Saib board which is based on Rockchip RV1109 SoC

[Karthikeyan Krishnasamy]

Rockchip RV1109 is compatible with Rockchip RV1126.
In this series, adding required missing peripheral in
RV1126 and its pin mux.

Relfor Saib board is equipped with 1GB of RAM and 4GB of eMMC
Pheripherals like Bluetooth 4.2, Wifi 5G, audio-codec,
ir transmitter and receiver, etc

Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com>
---
Changes in v3:
- Align to the comments
- Rebased with master
- Drop first 3 commit from v2, since it got applied
- Link to v2: https://lore.kernel.org/all/20240903105245.715899-1-karthikeyan@linumiz.com

Changes in v2:
 - Align to the comments
 - Rebased with master
 - Link to v1: https://lore.kernel.org/all/20240823153528.3863993-1-karthikeyan@linumiz.com

---
Karthikeyan Krishnasamy (6):
  dt-bindings: watchdog: rockchip: Add rockchip,rv1126-wdt string
  ARM: dts: rockchip: Add watchdog node for RV1126
  dt-bindings: rtc: microcrystal,rv3028: add #clock-cells property
  dt-bindings: vendor-prefixes: Add Relfor labs
  dt-bindings: arm: rockchip: Add Relfor Saib
  ARM: dts: rockchip: Add Relfor Saib board

 .../devicetree/bindings/arm/rockchip.yaml     |   5 +
 .../bindings/rtc/microcrystal,rv3028.yaml     |   3 +
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 .../bindings/watchdog/snps,dw-wdt.yaml        |   1 +
 arch/arm/boot/dts/rockchip/Makefile           |   1 +
 .../boot/dts/rockchip/rv1109-relfor-saib.dts  | 422 ++++++++++++++++++
 arch/arm/boot/dts/rockchip/rv1126.dtsi        |   8 +
 7 files changed, 442 insertions(+)
 create mode 100644 arch/arm/boot/dts/rockchip/rv1109-relfor-saib.dts

-- 
2.39.2

[PATCH v3 1/6] dt-bindings: watchdog: rockchip: Add rockchip,rv1126-wdt string

[Karthikeyan Krishnasamy]

Add rockchip,rv1126-wdt compatible string.

Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com>
---

Notes:
    v3:
    - add watchdog compatible string

 Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
index c7aab0418a32..bccd27a1e470 100644
--- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
@@ -31,6 +31,7 @@ properties:
               - rockchip,rk3568-wdt
               - rockchip,rk3588-wdt
               - rockchip,rv1108-wdt
+              - rockchip,rv1126-wdt
           - const: snps,dw-wdt
 
   reg:
-- 
2.39.2

[PATCH v3 2/6] ARM: dts: rockchip: Add watchdog node for RV1126

[Karthikeyan Krishnasamy]

Add watchdog node for Rockchip RV1126

Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com>
---

Notes:
    v3:
    - add watchdog compatible string
    
    v2:
    - no change

 arch/arm/boot/dts/rockchip/rv1126.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/rockchip/rv1126.dtsi b/arch/arm/boot/dts/rockchip/rv1126.dtsi
index abf442804d27..22a22bcad04b 100644
--- a/arch/arm/boot/dts/rockchip/rv1126.dtsi
+++ b/arch/arm/boot/dts/rockchip/rv1126.dtsi
@@ -544,6 +544,14 @@ timer0: timer@ff660000 {
 		clock-names = "pclk", "timer";
 	};
 
+	wdt: watchdog@ff680000 {
+		compatible = "rockchip,rv1126-wdt", "snps,dw-wdt";
+		reg = <0xff680000 0x100>;
+		interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&cru PCLK_WDT>;
+		status = "disabled";
+	};
+
 	i2s0: i2s@ff800000 {
 		compatible = "rockchip,rv1126-i2s-tdm";
 		reg = <0xff800000 0x1000>;
-- 
2.39.2

[PATCH v3 3/6] dt-bindings: rtc: microcrystal,rv3028: add #clock-cells property

[Karthikeyan Krishnasamy]

RV3028 RTC has a clock out features, the clk out can be
controlled using clkout register, to consume the clock out
from rv3028 '#clock-cells' property is added.

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com>
---

Notes:
    v3:
    - fix commit message
    
    v2:
    - fix commit message subject

 Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml
index 5ade5dfad048..cda8ad7c1203 100644
--- a/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml
+++ b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml
@@ -22,6 +22,9 @@ properties:
   interrupts:
     maxItems: 1
 
+  "#clock-cells":
+    const: 0
+
   trickle-resistor-ohms:
     enum:
       - 3000
-- 
2.39.2

[PATCH v3 4/6] dt-bindings: vendor-prefixes: Add Relfor labs

[Karthikeyan Krishnasamy]

Add Relfor Labs Pvt. Ltd. vendor prefixes
https://www.relfor.com/

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com>
---

Notes:
    v3:
    - no change
    
    v2:
    - no change

 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index a70ce43b3dc0..7d10ac7d6800 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -1220,6 +1220,8 @@ patternProperties:
     description: Unisoc Communications, Inc.
   "^realtek,.*":
     description: Realtek Semiconductor Corp.
+  "^relfor,.*":
+    description: Relfor Labs Pvt. Ltd.
   "^remarkable,.*":
     description: reMarkable AS
   "^renesas,.*":
-- 
2.39.2

[PATCH v3 5/6] dt-bindings: arm: rockchip: Add Relfor Saib

[Karthikeyan Krishnasamy]

Add devicetree binding for the Relfor saib board which
is based on Rockchip RV1109

Acked-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com>
---

Notes:
    v3:
    - no change
    
    v2:
    - fix wrong usage of SoC enum

 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 1ef09fbfdfaf..ae5e0104612e 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -848,6 +848,11 @@ properties:
               - radxa,zero-3w
           - const: rockchip,rk3566
 
+      - description: Relfor SAIB board
+        items:
+          - const: relfor,saib
+          - const: rockchip,rv1109
+
       - description: Rikomagic MK808 v1
         items:
           - const: rikomagic,mk808
-- 
2.39.2

[PATCH v3 6/6] ARM: dts: rockchip: Add Relfor Saib board

[Karthikeyan Krishnasamy]

Saib is an consumer electronics board from Relfor labs
Features:
    - Rockchip RV1109
    - 1GB DDR4
    - 4GB eMMC
    - Realtek RTL8821CS Wi-Fi/BT
    - IR transmitter/receiver
    - RV3028 RTC
    - Switch
    - User leds

Add support for it.

Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com>
---

Notes:
    v3:
    - sort nodes in aplhabetical order
    
    v2:
    - Drop status=okay in new nodes

 arch/arm/boot/dts/rockchip/Makefile           |   1 +
 .../boot/dts/rockchip/rv1109-relfor-saib.dts  | 422 ++++++++++++++++++
 2 files changed, 423 insertions(+)
 create mode 100644 arch/arm/boot/dts/rockchip/rv1109-relfor-saib.dts

diff --git a/arch/arm/boot/dts/rockchip/Makefile b/arch/arm/boot/dts/rockchip/Makefile
index ab4cd9aab722..716f5540e438 100644
--- a/arch/arm/boot/dts/rockchip/Makefile
+++ b/arch/arm/boot/dts/rockchip/Makefile
@@ -2,6 +2,7 @@
 dtb-$(CONFIG_ARCH_ROCKCHIP) += \
 	rv1108-elgin-r1.dtb \
 	rv1108-evb.dtb \
+	rv1109-relfor-saib.dtb \
 	rv1109-sonoff-ihost.dtb \
 	rv1126-edgeble-neu2-io.dtb \
 	rv1126-sonoff-ihost.dtb \
diff --git a/arch/arm/boot/dts/rockchip/rv1109-relfor-saib.dts b/arch/arm/boot/dts/rockchip/rv1109-relfor-saib.dts
new file mode 100644
index 000000000000..a63356ade3b7
--- /dev/null
+++ b/arch/arm/boot/dts/rockchip/rv1109-relfor-saib.dts
@@ -0,0 +1,422 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2024 Relfor Labs Pvt. Ltd.
+ */
+
+
+/dts-v1/;
+#include "rv1109.dtsi"
+#include <dt-bindings/leds/common.h>
+#include <dt-bindings/input/input.h>
+
+/ {
+	model = "Rockchip RV1109 Relfor Saib Board";
+	compatible = "relfor,saib", "rockchip,rv1109";
+
+	gpio-keys {
+		compatible = "gpio-keys";
+
+		button {
+			gpios = <&gpio2 RK_PA7 GPIO_ACTIVE_HIGH>;
+			linux,code = <KEY_DATA>;
+			label = "GPIO User Switch";
+			linux,input-type = <1>;
+		};
+	};
+
+	ir_receiver: ir-receiver {
+		compatible = "gpio-ir-receiver";
+		gpios = <&gpio3  RK_PB4 GPIO_ACTIVE_LOW>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&ir_rx>;
+	};
+
+	ir_transmitter: ir-transmitter {
+		compatible = "pwm-ir-tx";
+		pwms = <&pwm11 0 10000000 1>;
+	};
+
+	led-controller {
+		compatible = "pwm-leds-multicolor";
+
+		multi-led {
+			color = <LED_COLOR_ID_RGB>;
+			function = LED_FUNCTION_INDICATOR;
+			max-brightness = <65535>;
+
+			led-0 {
+				active-low;
+				color = <LED_COLOR_ID_BLUE>;
+				pwms = <&pwm9 0 50000 0>;
+			};
+
+			led-1 {
+				active-low;
+				color = <LED_COLOR_ID_GREEN>;
+				pwms = <&pwm6 0 50000 0>;
+			};
+
+			led-2 {
+				active-low;
+				color = <LED_COLOR_ID_RED>;
+				pwms = <&pwm10 0 50000 0>;
+			};
+		};
+	};
+
+	pwm-leds {
+		compatible = "pwm-leds";
+
+		led-0 {
+			pwms = <&pwm2 0 50000 0>;
+			max-brightness = <255>;
+			linux,default-trigger = "none";
+		};
+
+		led-1 {
+			pwms = <&pwm8 0 50000 0>;
+			max-brightness = <0>;
+			linux,default-trigger = "none";
+		};
+
+		led-2 {
+			pwms = <&pwm5 0 50000 0>;
+			max-brightness = <255>;
+			linux,default-trigger = "none";
+		};
+	};
+
+	sdio_pwrseq: pwrseq-sdio {
+		compatible = "mmc-pwrseq-simple";
+		clocks = <&rtc0>;
+		clock-names = "ext_clock";
+		pinctrl-names = "default";
+		pinctrl-0 = <&wifi_enable_h>;
+		reset-gpios = <&gpio1 RK_PD0 GPIO_ACTIVE_LOW>;
+	};
+
+	thermal_sensor1: thermal-sensor1 {
+		compatible = "generic-adc-thermal";
+		#thermal-sensor-cells = <0>;
+		io-channels = <&saradc 1>;
+		io-channel-names = "sensor-channel";
+		temperature-lookup-table = <(-40000) 826
+					     85000 609>;
+	};
+
+	thermal_sensor2: thermal-sensor2 {
+		compatible = "generic-adc-thermal";
+		#thermal-sensor-cells = <0>;
+		io-channels = <&saradc 2>;
+		io-channel-names = "sensor-channel";
+		temperature-lookup-table = <(-40000) 826
+					     85000 609>;
+	};
+
+	vcc_0v8: vcc-0v8 {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc_0v8";
+		regulator-min-microvolt = <800000>;
+		regulator-max-microvolt = <800000>;
+		regulator-always-on;
+		regulator-boot-on;
+		startup-delay-us = <150>;
+		vin-supply = <&vcc5v0_sys>;
+	};
+
+	vcc_1v2_ddr: vcc-1v2-ddr {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc_1v2_ddr";
+		regulator-min-microvolt = <1200000>;
+		regulator-max-microvolt = <1200000>;
+		regulator-always-on;
+		regulator-boot-on;
+		startup-delay-us = <75000>;
+		vin-supply = <&vcc5v0_sys>;
+	};
+
+	vcc_1v8: vcc-1v8 {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc_1v8";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+		regulator-always-on;
+		regulator-boot-on;
+		startup-delay-us = <51000>;
+		vin-supply = <&vcc5v0_sys>;
+	};
+
+	vcc1v8_ir: vcc1v8-ir {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc1v8_ir";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+		regulator-always-on;
+		regulator-boot-on;
+		vin-supply = <&vcc5v0_sys>;
+	};
+
+	vcc_2v5_ddr: vcc-2v5-ddr {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc_2v5_ddr";
+		regulator-min-microvolt = <2500000>;
+		regulator-max-microvolt = <2500000>;
+		regulator-always-on;
+		regulator-boot-on;
+		vin-supply = <&vcc3v3_sys>;
+	};
+
+	vcc3v3_sys: vcc3v3-sys {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc3v3_sys";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-always-on;
+		regulator-boot-on;
+		startup-delay-us = <75000>;
+		vin-supply = <&vcc5v0_sys>;
+	};
+
+	vcc5v0_sys: vcc5v0-sys {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc5v0_sys";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		regulator-always-on;
+		regulator-boot-on;
+	};
+
+	vdd_arm: vdd-arm {
+		compatible = "pwm-regulator";
+		pwms = <&pwm0 0 5000 1>;
+		regulator-name = "vdd_arm";
+		regulator-min-microvolt = <720000>;
+		regulator-max-microvolt = <1000000>;
+		regulator-settling-time-up-us = <18000>;
+		regulator-always-on;
+		regulator-boot-on;
+		pwm-supply = <&vcc3v3_sys>;
+		vin-supply = <&vcc5v0_sys>;
+	};
+
+	vdd_npu_vepu: vdd-npu-vepu {
+		compatible = "pwm-regulator";
+		pwms = <&pwm1 0 5000 1>;
+		regulator-name = "vdd_npu_vepu";
+		regulator-min-microvolt = <650000>;
+		regulator-max-microvolt = <950000>;
+		regulator-settling-time-up-us = <18000>;
+		regulator-always-on;
+		regulator-boot-on;
+		pwm-supply = <&vcc3v3_sys>;
+		vin-supply = <&vcc5v0_sys>;
+	};
+};
+
+&cpu0 {
+	cpu-supply = <&vdd_arm>;
+};
+
+&cpu1 {
+	cpu-supply = <&vdd_arm>;
+};
+
+&emmc {
+	bus-width = <8>;
+	non-removable;
+	pinctrl-0 = <&emmc_bus8 &emmc_cmd &emmc_clk>;
+	pinctrl-names = "default";
+	rockchip,default-sample-phase = <90>;
+	vmmc-supply = <&vcc3v3_sys>;
+	status = "okay";
+};
+
+&i2c3 {
+	pinctrl-0 = <&i2c3m2_xfer>;
+	pinctrl-names = "default";
+	status = "okay";
+
+	rtc0: rtc@52 {
+		compatible = "microcrystal,rv3028";
+		reg = <0x52>;
+		#clock-cells = <0>;
+		interrupt-parent = <&gpio2>;
+		interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
+		pinctrl-0 = <&rtc_int>;
+		pinctrl-names = "default";
+	};
+};
+
+&i2s0 {
+	/delete-property/ pinctrl-0;
+	rockchip,trcm-sync-rx-only;
+	pinctrl-0 =  <&i2s0m0_sclk_rx>,
+		     <&i2s0m0_lrck_rx>,
+		     <&i2s0m0_sdi0>;
+	pinctrl-names = "default";
+	status = "okay";
+};
+
+&pinctrl {
+	bluetooth-pins {
+		bt_reset: bt-reset {
+			rockchip,pins =
+			<1 RK_PC4 RK_FUNC_GPIO &pcfg_pull_none>;
+		};
+		bt_wake_dev: bt-wake-dev {
+			rockchip,pins =
+			<1 RK_PC5 RK_FUNC_GPIO &pcfg_pull_none>;
+		};
+		bt_wake_host: bt-wake-host {
+			rockchip,pins =
+			<1 RK_PC6 RK_FUNC_GPIO &pcfg_pull_down>;
+		};
+	};
+
+	buttons {
+		switch: switch {
+			rockchip,pins = <2 RK_PA7 RK_FUNC_GPIO &pcfg_pull_up>;
+		};
+	};
+
+	ir {
+		ir_rx: ir-rx {
+			rockchip,pins = <3 RK_PB4 RK_FUNC_GPIO &pcfg_pull_none>;
+		};
+	};
+
+	pwm {
+		pwm0m0_pins_pull_up: pwm0m0-pins-pull-up {
+			rockchip,pins =
+			/* pwm0_pin_m0 */
+			<0 RK_PB6 3 &pcfg_pull_up>;
+		};
+		pwm1m0_pins_pull_up: pwm1m0-pins-pull-up {
+			rockchip,pins =
+			/* pwm1_pin_m0 */
+			<0 RK_PB7 3 &pcfg_pull_up>;
+		};
+	};
+
+	rtc {
+		rtc_int: rtc-int {
+			rockchip,pins = <2 RK_PA0 RK_FUNC_GPIO &pcfg_pull_up>;
+		};
+	};
+
+	sdio-pwrseq {
+		wifi_enable_h: wifi-enable-h {
+			rockchip,pins = <1 RK_PD0 RK_FUNC_GPIO &pcfg_pull_none>;
+		};
+	};
+};
+
+&pmu_io_domains {
+	pmuio0-supply = <&vcc3v3_sys>;
+	pmuio1-supply = <&vcc3v3_sys>;
+	vccio4-supply = <&vcc3v3_sys>;
+	vccio5-supply = <&vcc3v3_sys>;
+	vccio6-supply = <&vcc3v3_sys>;
+	vccio7-supply = <&vcc3v3_sys>;
+	status = "okay";
+};
+
+&pwm0 {
+	/delete-property/ pinctrl-0;
+	pinctrl-0 = <&pwm0m0_pins_pull_up>;
+	pinctrl-names = "default";
+	status = "okay";
+};
+
+&pwm1 {
+	/delete-property/ pinctrl-0;
+	pinctrl-0 = <&pwm1m0_pins_pull_up>;
+	pinctrl-names = "default";
+	status = "okay";
+};
+
+&pwm2 {
+	/delete-property/ pinctrl-0;
+	pinctrl-0 = <&pwm2m1_pins>;
+	pinctrl-names = "default";
+	status = "okay";
+};
+
+&pwm5 {
+	pinctrl-0 = <&pwm5m0_pins>;
+	pinctrl-names = "default";
+	status = "okay";
+};
+
+&pwm6 {
+	pinctrl-0 = <&pwm6m0_pins>;
+	pinctrl-names = "default";
+	status = "okay";
+};
+
+&pwm8 {
+	pinctrl-0 = <&pwm8m1_pins>;
+	pinctrl-names = "default";
+	status = "okay";
+};
+
+&pwm9 {
+	pinctrl-0 = <&pwm9m1_pins>;
+	pinctrl-names = "default";
+	status = "okay";
+};
+
+&pwm10 {
+	pinctrl-0 = <&pwm10m1_pins>;
+	pinctrl-names = "default";
+	status = "okay";
+};
+
+&pwm11 {
+	/delete-property/ pinctrl-0;
+	pinctrl-0 = <&pwm11m1_pins>;
+	pinctrl-names = "default";
+	status = "okay";
+};
+
+&saradc {
+	vref-supply = <&vcc_1v8>;
+	status = "okay";
+};
+
+&sdio {
+	bus-width = <4>;
+	cap-sd-highspeed;
+	cap-sdio-irq;
+	max-frequency = <100000000>;
+	mmc-pwrseq = <&sdio_pwrseq>;
+	no-mmc;
+	no-sd;
+	non-removable;
+	pinctrl-0 = <&sdmmc1_clk &sdmmc1_cmd &sdmmc1_bus4>;
+	pinctrl-names = "default";
+	sd-uhs-sdr104;
+	vmmc-supply = <&vcc3v3_sys>;
+	status = "okay";
+};
+
+&uart0 {
+	pinctrl-0 = <&uart0_xfer &uart0_ctsn &uart0_rtsn>;
+	pinctrl-names = "default";
+	status = "okay";
+
+	bluetooth {
+		compatible = "realtek,rtl8822cs-bt";
+		device-wake-gpios = <&gpio1 RK_PC5 GPIO_ACTIVE_HIGH>;
+		enable-gpios = <&gpio1 RK_PC4 GPIO_ACTIVE_HIGH>;
+		host-wake-gpios = <&gpio1 RK_PC6 GPIO_ACTIVE_HIGH>;
+		pinctrl-0 = <&bt_reset>, <&bt_wake_dev>, <&bt_wake_host>;
+		pinctrl-names = "default";
+	};
+};
+
+&uart2 {
+	pinctrl-0 = <&uart2m1_xfer>;
+	pinctrl-names = "default";
+	status = "okay";
+};
-- 
2.39.2

Re: [PATCH v3 1/6] dt-bindings: watchdog: rockchip: Add rockchip,rv1126-wdt string

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]

On Thu, Sep 12, 2024 at 07:54:46PM +0530, Karthikeyan Krishnasamy wrote:
> Add rockchip,rv1126-wdt compatible string.
> 
> Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

> ---
> 
> Notes:
>     v3:
>     - add watchdog compatible string
> 
>  Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> index c7aab0418a32..bccd27a1e470 100644
> --- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> @@ -31,6 +31,7 @@ properties:
>                - rockchip,rk3568-wdt
>                - rockchip,rk3588-wdt
>                - rockchip,rv1108-wdt
> +              - rockchip,rv1126-wdt
>            - const: snps,dw-wdt
>  
>    reg:
> -- 
> 2.39.2
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v3 3/6] dt-bindings: rtc: microcrystal,rv3028: add #clock-cells property

[Alexandre Belloni]

On 12/09/2024 19:54:48+0530, Karthikeyan Krishnasamy wrote:
> RV3028 RTC has a clock out features, the clk out can be
> controlled using clkout register, to consume the clock out
> from rv3028 '#clock-cells' property is added.
> 
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

> Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com>
> ---
> 
> Notes:
>     v3:
>     - fix commit message
>     
>     v2:
>     - fix commit message subject
> 
>  Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml
> index 5ade5dfad048..cda8ad7c1203 100644
> --- a/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml
> +++ b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml
> @@ -22,6 +22,9 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> +  "#clock-cells":
> +    const: 0
> +
>    trickle-resistor-ohms:
>      enum:
>        - 3000
> -- 
> 2.39.2
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH v3 3/6] dt-bindings: rtc: microcrystal,rv3028: add #clock-cells property

[Heiko Stuebner]

Hi Alexandre,

Am Montag, 16. September 2024, 14:37:56 CEST schrieb Alexandre Belloni:
> On 12/09/2024 19:54:48+0530, Karthikeyan Krishnasamy wrote:
> > RV3028 RTC has a clock out features, the clk out can be
> > controlled using clkout register, to consume the clock out
> > from rv3028 '#clock-cells' property is added.
> > 
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

just for my understanding, does this mean that you expect this change
to get applied together with the others?

No preference, just making sure I understand :-)

Thanks
Heiko

Re: [PATCH v3 3/6] dt-bindings: rtc: microcrystal,rv3028: add #clock-cells property

[Alexandre Belloni]

On 16/09/2024 16:26:23+0200, Heiko Stuebner wrote:
> Hi Alexandre,
> 
> Am Montag, 16. September 2024, 14:37:56 CEST schrieb Alexandre Belloni:
> > On 12/09/2024 19:54:48+0530, Karthikeyan Krishnasamy wrote:
> > > RV3028 RTC has a clock out features, the clk out can be
> > > controlled using clkout register, to consume the clock out
> > > from rv3028 '#clock-cells' property is added.
> > > 
> > > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> 
> just for my understanding, does this mean that you expect this change
> to get applied together with the others?
> 
> No preference, just making sure I understand :-)

i was actually wondering how this was going to get applied. I guess that
if you are planning to take the rest, you can also apply this one.


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH v3 3/6] dt-bindings: rtc: microcrystal,rv3028: add #clock-cells property

[Heiko Stuebner]

Am Montag, 16. September 2024, 16:34:07 CEST schrieb Alexandre Belloni:
> On 16/09/2024 16:26:23+0200, Heiko Stuebner wrote:
> > Hi Alexandre,
> > 
> > Am Montag, 16. September 2024, 14:37:56 CEST schrieb Alexandre Belloni:
> > > On 12/09/2024 19:54:48+0530, Karthikeyan Krishnasamy wrote:
> > > > RV3028 RTC has a clock out features, the clk out can be
> > > > controlled using clkout register, to consume the clock out
> > > > from rv3028 '#clock-cells' property is added.
> > > > 
> > > > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > > Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> > 
> > just for my understanding, does this mean that you expect this change
> > to get applied together with the others?
> > 
> > No preference, just making sure I understand :-)
> 
> i was actually wondering how this was going to get applied. I guess that
> if you are planning to take the rest, you can also apply this one.

so we were both wondering the same thing :-) .

For some other watchdog binding Guenter suggested the binding patch
to go with the rest, so I wanted to make sure your Ack meant the same.

But of course I'm also fine/happy with you just picking up this rtc
binding patch for the rtc tree :-)

Heiko

Re: [PATCH v3 1/6] dt-bindings: watchdog: rockchip: Add rockchip,rv1126-wdt string

[Heiko Stuebner]

Hey,

Am Donnerstag, 12. September 2024, 16:24:46 CEST schrieb Karthikeyan Krishnasamy:
> Add rockchip,rv1126-wdt compatible string.
> 
> Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com>

I think this patch misses some recipients because neither
the watchdog maintainers nor the watchdog list is included.

We'll need for them to at least Ack this patch, so they'll
need to be included. Please check your scripts/get_maintainer.pl
call


Thanks
Heiko

> ---
> 
> Notes:
>     v3:
>     - add watchdog compatible string
> 
>  Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> index c7aab0418a32..bccd27a1e470 100644
> --- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> @@ -31,6 +31,7 @@ properties:
>                - rockchip,rk3568-wdt
>                - rockchip,rk3588-wdt
>                - rockchip,rv1108-wdt
> +              - rockchip,rv1126-wdt
>            - const: snps,dw-wdt
>  
>    reg:
> 

Re: [PATCH v3 1/6] dt-bindings: watchdog: rockchip: Add rockchip,rv1126-wdt string

[karthikeyan]

On 9/18/24 04:46, Heiko Stuebner wrote:
> Hey,
> 
> Am Donnerstag, 12. September 2024, 16:24:46 CEST schrieb Karthikeyan Krishnasamy:
>> Add rockchip,rv1126-wdt compatible string.
>>
>> Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com>
> 
> I think this patch misses some recipients because neither
> the watchdog maintainers nor the watchdog list is included.
> 
> We'll need for them to at least Ack this patch, so they'll
> need to be included. Please check your scripts/get_maintainer.pl
> call
> 
> 
> Thanks
> Heiko
> 
Apologies for missing them. Adding them in this reply mail.
>> ---
>>
>> Notes:
>>      v3:
>>      - add watchdog compatible string
>>
>>   Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>> index c7aab0418a32..bccd27a1e470 100644
>> --- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>> +++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>> @@ -31,6 +31,7 @@ properties:
>>                 - rockchip,rk3568-wdt
>>                 - rockchip,rk3588-wdt
>>                 - rockchip,rv1108-wdt
>> +              - rockchip,rv1126-wdt
>>             - const: snps,dw-wdt
>>   
>>     reg:
>>
> 
> 
> 
> 

Best Regards,
Karthikeyan

Re: (subset) [PATCH v3 3/6] dt-bindings: rtc: microcrystal,rv3028: add #clock-cells property

[Alexandre Belloni]

On Thu, 12 Sep 2024 19:54:48 +0530, Karthikeyan Krishnasamy wrote:
> RV3028 RTC has a clock out features, the clk out can be
> controlled using clkout register, to consume the clock out
> from rv3028 '#clock-cells' property is added.
> 
> 

Applied, thanks!

[3/6] dt-bindings: rtc: microcrystal,rv3028: add #clock-cells property
      https://git.kernel.org/abelloni/c/4015580e983d

Best regards,

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH v3 1/6] dt-bindings: watchdog: rockchip: Add rockchip,rv1126-wdt string

[karthikeyan]

On 9/18/24 12:59, karthikeyan wrote:
> 
> 
> On 9/18/24 04:46, Heiko Stuebner wrote:
>> Hey,
>>
>> Am Donnerstag, 12. September 2024, 16:24:46 CEST schrieb Karthikeyan 
>> Krishnasamy:
>>> Add rockchip,rv1126-wdt compatible string.
>>>
>>> Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com>
>>
>> I think this patch misses some recipients because neither
>> the watchdog maintainers nor the watchdog list is included.
>>
>> We'll need for them to at least Ack this patch, so they'll
>> need to be included. Please check your scripts/get_maintainer.pl
>> call
>>
>>
>> Thanks
>> Heiko
>>
> Apologies for missing them. Adding them in this reply mail.
>>> ---
>>>
>>> Notes:
>>>      v3:
>>>      - add watchdog compatible string
>>>
>>>   Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git 
>>> a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml 
>>> b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>>> index c7aab0418a32..bccd27a1e470 100644
>>> --- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>>> +++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>>> @@ -31,6 +31,7 @@ properties:
>>>                 - rockchip,rk3568-wdt
>>>                 - rockchip,rk3588-wdt
>>>                 - rockchip,rv1108-wdt
>>> +              - rockchip,rv1126-wdt
>>>             - const: snps,dw-wdt
>>>     reg:
>>>
>>
>>
>>
>>
> 
> Best Regards,
> Karthikeyan

Gentle remainder.

Best Regards,
Karthikeyan

Re: [PATCH v3 1/6] dt-bindings: watchdog: rockchip: Add rockchip,rv1126-wdt string

[Heiko Stübner]

Hi,

Am Montag, 7. Oktober 2024, 15:56:58 CEST schrieb karthikeyan:
> 
> On 9/18/24 12:59, karthikeyan wrote:
> > 
> > 
> > On 9/18/24 04:46, Heiko Stuebner wrote:
> >> Hey,
> >>
> >> Am Donnerstag, 12. September 2024, 16:24:46 CEST schrieb Karthikeyan 
> >> Krishnasamy:
> >>> Add rockchip,rv1126-wdt compatible string.
> >>>
> >>> Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com>
> >>
> >> I think this patch misses some recipients because neither
> >> the watchdog maintainers nor the watchdog list is included.
> >>
> >> We'll need for them to at least Ack this patch, so they'll
> >> need to be included. Please check your scripts/get_maintainer.pl
> >> call
> >>
> >>
> >> Thanks
> >> Heiko
> >>
> > Apologies for missing them. Adding them in this reply mail.

I don't think that will have worked.

Ideally can you include Conor's Ack and resend only the watchdog binding
patch to the watchdog maintainers (and lists and me too please) .

Because just adding more people to a reply probably won't tell them
that some action is expected.

Heiko

Re: [PATCH v3 1/6] dt-bindings: watchdog: rockchip: Add rockchip,rv1126-wdt string

[karthikeyan]

On 10/9/24 00:56, Heiko Stübner wrote:
> Hi,
> 
> Am Montag, 7. Oktober 2024, 15:56:58 CEST schrieb karthikeyan:
>>
>> On 9/18/24 12:59, karthikeyan wrote:
>>>
>>>
>>> On 9/18/24 04:46, Heiko Stuebner wrote:
>>>> Hey,
>>>>
>>>> Am Donnerstag, 12. September 2024, 16:24:46 CEST schrieb Karthikeyan
>>>> Krishnasamy:
>>>>> Add rockchip,rv1126-wdt compatible string.
>>>>>
>>>>> Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com>
>>>>
>>>> I think this patch misses some recipients because neither
>>>> the watchdog maintainers nor the watchdog list is included.
>>>>
>>>> We'll need for them to at least Ack this patch, so they'll
>>>> need to be included. Please check your scripts/get_maintainer.pl
>>>> call
>>>>
>>>>
>>>> Thanks
>>>> Heiko
>>>>
>>> Apologies for missing them. Adding them in this reply mail.
> 
> I don't think that will have worked.
> 
> Ideally can you include Conor's Ack and resend only the watchdog binding
> patch to the watchdog maintainers (and lists and me too please) .
> 
> Because just adding more people to a reply probably won't tell them
> that some action is expected.
> 
> Heiko
> 
> 

Thanks for your info. It's my mistake. I will resend the watchdog patch 
alone.

Best regards,
Karthikeyan

Re: (subset) [PATCH v3 0/6] Add support Relfor Saib board which is based on Rockchip RV1109 SoC

[Heiko Stuebner]

On Thu, 12 Sep 2024 19:54:45 +0530, Karthikeyan Krishnasamy wrote:
> Rockchip RV1109 is compatible with Rockchip RV1126.
> In this series, adding required missing peripheral in
> RV1126 and its pin mux.
> 
> Relfor Saib board is equipped with 1GB of RAM and 4GB of eMMC
> Pheripherals like Bluetooth 4.2, Wifi 5G, audio-codec,
> ir transmitter and receiver, etc
> 
> [...]

Applied, thanks!

[2/6] ARM: dts: rockchip: Add watchdog node for RV1126
      commit: cbad02491459d64522852da07736ddc1f04cbaef
[4/6] dt-bindings: vendor-prefixes: Add Relfor labs
      commit: d0c9f9b848d0ee57e785c393cd4d618b5753e68d
[5/6] dt-bindings: arm: rockchip: Add Relfor Saib
      commit: c1386c02d5d457a1713c8e866102c4418a1c736c
[6/6] ARM: dts: rockchip: Add Relfor Saib board
      commit: bdb2696ac5786ed3f43520e700347fe2152ea199

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>