From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Nik Bune <n2h9z4@gmail.com>, krzysztof.kozlowski+dt@linaro.org
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org,
afd@ti.com, linux-kernel@vger.kernel.org,
linux-watchdog@vger.kernel.org, linux@roeck-us.net,
skhan@linuxfoundation.org, wim@linux-watchdog.org
Subject: Re: [PATCH v3] dt-bindings: watchdog: davinci-wdt: convert txt to yaml
Date: Sun, 29 Oct 2023 16:20:10 +0100 [thread overview]
Message-ID: <842b5fb7-a43a-4273-88af-6f1571fdaa35@linaro.org> (raw)
In-Reply-To: <20231029150905.108531-1-n2h9z4@gmail.com>
On 29/10/2023 16:09, Nik Bune wrote:
> Hello!
>
>> On Sun, 29 Oct 2023 at 08:31, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
>> On 28/10/2023 19:51, Nik Bune wrote:
>>>>> + power-domains:
>>>>> + description:
>>>>> + A phandle and PM domain specifier as defined by bindings of
>>>>> + the power controller specified by phandle.
>>>>> + See Documentation/devicetree/bindings/power/power-domain.yaml for details.
>>>>
>>>> I think you missed Rob's comment in reply to Andrew, about constraining
>>>> and ordering the power-domains:
>>>> https://lore.kernel.org/all/20231026203037.GA327324-robh@kernel.org/
>>>>
>>>> Cheers,
>>>> Conor.
>>>
>>> I didn't get what should be done with respect to the comment above:
>>> Should we wait for the response from Andrew,
>>> or should we skip and remove the the power-domains definition for this binding,
>>> or add "maxItems: 1" to power-domains definition?
>>
>> None of the options above allow to send the same code without maxItems.
>> Sending new version without addressing feedback is basically ignoring
>> the feedback and next time you will have annoyed reviewers...
>>
>> Best regards,
>> Krzysztof
>>
>
> I didn't ignore. v3 patch was sent 37 minutes before the Rob's comment to v2.
Ah, sorry, it's good then :). Rob's comment still applies, though.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-10-29 15:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 19:53 [PATCH v3] dt-bindings: watchdog: davinci-wdt: convert txt to yaml Nik Bune
2023-10-27 14:14 ` Conor Dooley
2023-10-28 17:51 ` Nik Bune
2023-10-29 7:31 ` Krzysztof Kozlowski
2023-10-29 15:09 ` Nik Bune
2023-10-29 15:20 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=842b5fb7-a43a-4273-88af-6f1571fdaa35@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=afd@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=n2h9z4@gmail.com \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).