From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D07714AB9 for ; Fri, 10 Nov 2023 11:16:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JwfP/TyN" Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1827D9ED6 for ; Fri, 10 Nov 2023 03:16:35 -0800 (PST) Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-507bd64814fso2670477e87.1 for ; Fri, 10 Nov 2023 03:16:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699614993; x=1700219793; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yxkmO6IiYGO72UiX4UQ3V4i7IbbmznqMUd9OJsl5lng=; b=JwfP/TyNeSgQdlypAM+fHzwg8aFfvIPw8JDJszmWNtKt0J58mO0pekWEu8SBSZkcMm 52OoNyEuh4610urXjKf+CYpZKAXfKHJ2uBug+rqix8sw0ZGaVwuSXiGDq/HRtiC4Slmj Z+4pNmgQrlGAIhglGkse2eivYkmbp8hNWHE7D0nLza9Rc3dT5TR3PtSBRjRySt1Cw7KN qJwGNsoAEH/7MYymG+4k0LvEDUs7QGSyz9+cv5w4aww2Y5WP8SS56+K6hXxVbp8wxloo +Ov1NGjHwkx+YD1bPdGiasDkTA+rXeN+/hYaPOZj0mjC5oEYLfy0b9F3yvAfPHgBJu9E vI3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699614993; x=1700219793; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yxkmO6IiYGO72UiX4UQ3V4i7IbbmznqMUd9OJsl5lng=; b=lthyKFwpbV+jEV7F4DRSAi6FqKuJ056kwCBeUptQkngm+RS7NtR1cJbQeAitBPd1i4 L9POhqVvDifGXSr0a/iiRO6VL3uyKDmq5IpNYcvsZiLnPWsGeMm3Y05OSEqOTX68WsDV rFQPAwe5rD/ASU+rKQgBvliwHBkmSXcP/309KQZmoMCiYpPJ0wj0U3XkQp0ecvvLpG++ pLp5rNX3Z/UN+txnDmSF/DXO76T2dBAwWzPkcUQCJVR73Ltv4Gzd7XkN1qhJuSkqXtFE spSgCDYQLHLvpLjZQZfHnWLWQCLZzeXmP7YF1mrHzwfZqUbbmF+7Sphxa7iiPi2LYD3+ R0aA== X-Gm-Message-State: AOJu0YxpssSAh7r5K3CX1PJCDK46WTrSCtiVbkwQSTtgKzVx/JEWVW6J M4iFxIGjmQNk3GiSIC/0Zi+ulg== X-Google-Smtp-Source: AGHT+IHXTskzoQbtZ1PX/JfXAerX3f0kEvVd3Cs31EwwuZUMwgpO6YJA4nLPMZyYekHnMs37CNs3yQ== X-Received: by 2002:a2e:8793:0:b0:2c5:5926:de4c with SMTP id n19-20020a2e8793000000b002c55926de4cmr6089246lji.32.1699614993290; Fri, 10 Nov 2023 03:16:33 -0800 (PST) Received: from [192.168.100.102] ([37.228.218.3]) by smtp.gmail.com with ESMTPSA id gy15-20020a05600c880f00b004064741f855sm4759808wmb.47.2023.11.10.03.16.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Nov 2023 03:16:32 -0800 (PST) Message-ID: <8457b113-bef2-47e4-a138-0f92a4f5798a@linaro.org> Date: Fri, 10 Nov 2023 11:16:31 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] clk: qcom: videocc-sm8150: Update the video_pll0_config Content-Language: en-US To: Satya Priya Kakitapalli , Andy Gross , Konrad Dybcio , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20231110065029.2117212-1-quic_skakitap@quicinc.com> <20231110065029.2117212-4-quic_skakitap@quicinc.com> From: Bryan O'Donoghue In-Reply-To: <20231110065029.2117212-4-quic_skakitap@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/11/2023 06:50, Satya Priya Kakitapalli wrote: > Update the video_pll0_config to configure the test_ctl_hi and > test_ctl_hi1 values. > > Fixes: 5658e8cf1a8a ("clk: qcom: add video clock controller driver for SM8150") > Signed-off-by: Satya Priya Kakitapalli > --- > drivers/clk/qcom/videocc-sm8150.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/clk/qcom/videocc-sm8150.c b/drivers/clk/qcom/videocc-sm8150.c > index 6a5f89f53da8..ddfe784fb9e1 100644 > --- a/drivers/clk/qcom/videocc-sm8150.c > +++ b/drivers/clk/qcom/videocc-sm8150.c > @@ -33,6 +33,8 @@ static struct alpha_pll_config video_pll0_config = { > .config_ctl_val = 0x20485699, > .config_ctl_hi_val = 0x00002267, > .config_ctl_hi1_val = 0x00000024, > + .test_ctl_hi_val = 0x00000002, > + .test_ctl_hi1_val = 0x00000020, > .user_ctl_val = 0x00000000, > .user_ctl_hi_val = 0x00000805, > .user_ctl_hi1_val = 0x000000D0, It would be nice to get a better description of this change. Reading this - I can see it does an update but, the commit log should contain what it is updating and why plus what effect the update will have. Please update the commit log to capture that data and +cc me on the V2. --- bod