From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6557B33B6CE for ; Wed, 17 Dec 2025 12:01:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765972886; cv=none; b=n98oxgSZgYRRqswEmJsEvGiM7YnUknlhr8fpbTekvDwlEZSdOOZXStthaT3Nz/xtqe2G8X+RyB1NpqySNvW/Lh9EBQB7ZVdanGP6dB8erENTICPMBrTYPVu87Xr3GAHUzothoSJNxCEgbYTgdxyQJrFeSx+PY9p4b6NBykGRxmY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765972886; c=relaxed/simple; bh=arELwse4/E+vJh0yULIHRYY9RRdM57IUW0I2mzCyPbk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rJLlx8qLDpLXt7O9hginaE5upyrXQlNGQM257dvfe7nw/tyXiu8kQ3kxM9KsXbmxJR/u6GZ6aID0jilvL1tFrGqUnpVWOWA3N3NuBHami4VMFwnsS0pgIXyDElAeuLR9x/rzLbv70PJnD4ME10SzO+i907XFMBGljFv28d3fOzM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cfr4N9kU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gXfrvshJ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cfr4N9kU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gXfrvshJ" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BHAMGuL1215352 for ; Wed, 17 Dec 2025 12:01:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ByKvMd85JKuxAMXI7vI0KR1rzjykBx3KAV0QrFPYzlI=; b=cfr4N9kUoXGWLBkf hssiJGniAOS/Oi6EPgxjXJSDb+z6ZVcS3OlVP/JngB6PJMXoKUQFBvS+qrM5NHRV nxLzVCwjwt2djhKhbWln1vxkjGnyHObSHU4zJzAxGXtwGvJ2JsSywVDU95G3siCZ sgJ4rVAjjQkovQtc8DBq9eRwLeHYVaVYZbUoY62VOAxmDq9Ab8udKIBKdTnZ230h F4jushBigoWSauLaDmhSc+f2ytvbmaZFX3mDiF50rLsiQFpO2xLzjUKGrFiIwNuR MxXj2ZTzEiLvmhHpBjIW/dOEjlyJ9dSmoHfpLjxsnDpQFULSc7MgpdmTFwNWPA0H ky8WSg== Received: from mail-yx1-f72.google.com (mail-yx1-f72.google.com [74.125.224.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b3b7g34v7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 17 Dec 2025 12:01:19 +0000 (GMT) Received: by mail-yx1-f72.google.com with SMTP id 956f58d0204a3-63fb6a61e8eso1628194d50.3 for ; Wed, 17 Dec 2025 04:01:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765972879; x=1766577679; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ByKvMd85JKuxAMXI7vI0KR1rzjykBx3KAV0QrFPYzlI=; b=gXfrvshJcGpQxXI5qldSsToXqy9RPrlpa4UUPxaI0W2uDi44k2Kiu8EzklHBTsHMJR H38Fodd94PkJmsA8w/wu0vA2CwR8omIT0hQWYNNtqUVnR2+x2O6WVer50K3a2wNGz1yh LKABHfxfxtaxSqrEL3KAwwwbzS1GOBJgncvFFy+REnxR2uHpJRljlTtFf2Y6to3qwUUa sgfNSes+R6GrI5hqQuDZmer+9sVULyrzdmq1OIZgz4kGvvP7j9rzvqnDxa/F+Ous8p8j S68V/bSfRDqIU2FP71gFktv5DIJMuGy9M97/ya3UPoRO0tnarKuGybMbmNsz9d3zq/Le 1vKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765972879; x=1766577679; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ByKvMd85JKuxAMXI7vI0KR1rzjykBx3KAV0QrFPYzlI=; b=EOhdRckjroJx9x6KBe5+VyhZrZp8StmgsB55aduHdy+DIufSrdjjx/20b7s4nyLNBl W7XFMemHKVbbJ3cAHi90C+xNSRxmbAsaqspo0BmMLlrJWXIWPjh7mECmPzqcXwsTGT67 NaC4OHOeQrT3TxW1cXkz8uLcHUQo9O1io03KmW0bDSvSusoz/XD1hqjV18Sf1coxKVmu oeDoXxb7pxkQSPStKvjT2VGJVitVCfxKnd6Z7bDtY/UnpnlI2H2d9mjqQnYj04gjC+MZ uD7qKCpyCjNfNT6vz68Nv+tdOPeBSRJnc1bWz6eOCJisSyn1SSPbDXo7Bx9tMami0fSQ iDrw== X-Forwarded-Encrypted: i=1; AJvYcCWrFqmLFZxHJmawej0J7U4BJOWGGCLmntHJqNQC5MXdTHuo4hAsAcMQbwqgDSsAIIasAkwZedWXa4GA@vger.kernel.org X-Gm-Message-State: AOJu0YzG1yCXNG5qzGamFy5LS4x/fVMhCUwWmaPJo8Klye5EBUggWj71 1vDfzoNVpn9F55+CtRHRAdEUhm7XlSrDMsH9fpC4iGwWts5fEphXVhvFmmFdmo9a8RGvc1opjyK vLNVXoa+tv3I+HJHD0bPM7iiKQZdV0p5xIeoIqBDCB92lGbVTLCD3NN9MjqU1WRgq X-Gm-Gg: AY/fxX7JHR3teF7mhKriJT7TI0dJPuly1c8Cj9g+vyYR7WbsCpl3Y+UxJRp6lPYAnr4 56jrQHW0bZlqLmHqGnyUG6nmDQZ1ht1Iu9DdcsgNzr4GL9PMyaG5hKunENfQ4pYVt5Zv1OJDNwC KWwP5HotFhNQXz+d11Uu6y6n+qCskowLMiRQeaTt5lNGGgBjDb+VwGVsotCc7zmPXQSBEqAMwSg UoaOgV40MU+ed3m0V+1AxquGRmm1r1psiRENLgrnAApbDNBg2j5KrXbEiUB/gDrO7wIc6bQWh90 MDca9XsnVVqkr1c8ieoSwmivluJ+sX94Su0S/cDB5tBlk+LCP40HeYHvkmpjGQCgG7iZ+12UVaR BkQ1P1Jslupn4gPruDr9h8OjJnPN+XgonvazpzYGd0D6QJPdvO610nz8dwgCd9cxiQw== X-Received: by 2002:a05:690c:c4d2:b0:78f:8601:b3d0 with SMTP id 00721157ae682-78f8601bdcfmr41442947b3.6.1765972879089; Wed, 17 Dec 2025 04:01:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IEbvc56X54KPxAsJNlVZkM62pygYiA8KVDpGS6lIwc62j+NJ/6ozCrv1vLxOorBH2EkU5M7wQ== X-Received: by 2002:a05:690c:c4d2:b0:78f:8601:b3d0 with SMTP id 00721157ae682-78f8601bdcfmr41442747b3.6.1765972878505; Wed, 17 Dec 2025 04:01:18 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7ff90481edsm411917466b.34.2025.12.17.04.01.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Dec 2025 04:01:17 -0800 (PST) Message-ID: <846ef50b-e703-4aeb-88a9-3b86715335ea@oss.qualcomm.com> Date: Wed, 17 Dec 2025 13:01:15 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 5/5] arm64: dts: qcom: sdm670-google-sargo: add imx355 front camera To: David Heidelberg , Richard Acayan , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sakari Ailus , Tianshu Qiu , Mauro Carvalho Chehab , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-media@vger.kernel.org Cc: Robert Mader , Vladimir Zapolskiy References: <20251211014846.16602-1-mailingradian@gmail.com> <20251211014846.16602-6-mailingradian@gmail.com> <377c299a-2088-4fb5-befc-c8b1cea05848@ixit.cz> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <377c299a-2088-4fb5-befc-c8b1cea05848@ixit.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: 5sxlCW0GSy6bzl07cfzFRYR97g0yyNiA X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE3MDA5MyBTYWx0ZWRfX937F6IuLirdK ejnavU6ZfqnN8r7ItkaJKEmR9SZISWFdijlX3AbooZfXlYIASHVRBu8Ho/yG4LywjjzNLnqAzXn SImTWma6Q+wwqf2aEx0xQjgeeNnrq1D1tZiDWU8qgDq+GVkD5LuNQaNgrUa4rR37hpqZuuSYzfU ie+b5ZCDk3YTQBRWIsZKDzAPCNS/nRdoMb86tKsK/LAYpWfAEWu6hv9JcJH6VGd+sHFsCPs6rLf Q64Y9eOU9c7/8rHYj73uRZRpNvSYmvOVpGtSjpssENRID5SAPtyPnCxSjXMPxsxv1E3BBL9qSWD YzICCz/o6WUFLNthd2LR41M+jN6wqFsE1Sb6eBkwQNHyTEWatkkPB6YRDMug6+HyDhKsW2ys265 m2IzYk+clVwBmLflVD938hVYixyAew== X-Proofpoint-GUID: 5sxlCW0GSy6bzl07cfzFRYR97g0yyNiA X-Authority-Analysis: v=2.4 cv=PbLyRyhd c=1 sm=1 tr=0 ts=69429b8f cx=c_pps a=VEzVgl358Dq0xwHDEbsOzA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=QX4gbG5DAAAA:8 a=pGLkceISAAAA:8 a=-PvwipDTlZT7saZ3bE4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uujmmnXaIg8lM0-o0HFK:22 a=AbAUZ8qAyYyZVLSsDulk:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-17_01,2025-12-16_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 spamscore=0 suspectscore=0 bulkscore=0 malwarescore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512170093 On 12/12/25 11:41 PM, David Heidelberg wrote: > On 11/12/2025 02:48, Richard Acayan wrote: >> The Sony IMX355 is the front camera on the Pixel 3a, mounted in portrait >> mode. It is connected to CSIPHY1 and CCI I2C1, and uses MCLK2. Add >> support for it. >> >> Co-developed-by: Robert Mader >> Signed-off-by: Robert Mader >> Signed-off-by: Richard Acayan >> --- >>   .../boot/dts/qcom/sdm670-google-sargo.dts     | 107 ++++++++++++++++++ >>   1 file changed, 107 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts b/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts >> index d01422844fbf..ede0ad7ded23 100644 >> --- a/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts >> +++ b/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts >> @@ -172,6 +172,34 @@ vreg_s2b_1p05: vreg-s2b-regulator { >>           regulator-min-microvolt = <1050000>; >>           regulator-max-microvolt = <1050000>; >>       }; >> + >> +    cam_front_ldo: cam-front-ldo-regulator { >> +        compatible = "regulator-fixed"; >> +        regulator-name = "cam_front_ldo"; >> +        regulator-min-microvolt = <1352000>; >> +        regulator-max-microvolt = <1352000>; >> +        regulator-enable-ramp-delay = <135>; >> + >> +        gpios = <&pm660l_gpios 4 GPIO_ACTIVE_HIGH>; >> +        enable-active-high; >> + >> +        pinctrl-0 = <&cam_front_ldo_pin>; >> +        pinctrl-names = "default"; >> +    }; >> + >> +    cam_vio_ldo: cam-vio-ldo-regulator { >> +        compatible = "regulator-fixed"; >> +        regulator-name = "cam_vio_ldo"; >> +        regulator-min-microvolt = <1800000>; >> +        regulator-max-microvolt = <1800000>; >> +        regulator-enable-ramp-delay = <233>; >> + >> +        gpios = <&pm660_gpios 13 GPIO_ACTIVE_HIGH>; >> +        enable-active-high; >> + >> +        pinctrl-0 = <&cam_vio_pin>; >> +        pinctrl-names = "default"; >> +    }; >>   }; >>     &apps_rsc { >> @@ -392,6 +420,64 @@ vreg_bob: bob { >>       }; >>   }; >>   +&camss { >> +    vdda-phy-supply = <&vreg_l1a_1p225>; >> +    vdda-pll-supply = <&vreg_s6a_0p87>; > The vdda-pll-supply is already named wrongly, as 0p87 != 1.352 > > vreg_s6a_0p87: smps6 { >                        regulator-min-microvolt = <1224000>; >                        regulator-max-microvolt = <1352000>; > > > > vdda-phy-supply is on sdm845 (0.75 - 0.8 V) and sdm670 different. > sdm845: 0.8 V (should be 0.75 - 0.8 V) // OnePlus 6 > sc7280: 0.72 V - 1.05 V // Fairphone 5 > sdm670: 1.2 V > > This may be correct, thou, but still feels like pretty huge diff. > > Maybe someone from QCOM can confirm? I can't find SDM670 data, but there's both 1.2 V and 0.88 V inputs to the CSIPHYs on SDM845. On downstream, i see SDM670 uses L1A @ 1.2 V and enables the REFGEN. Maybe i can find something more concrete in a couple days. Konrad