devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH RESEND v2] arm64: dts: socfpga: agilex: Add dma channel id for spi
@ 2025-02-25 13:39 niravkumar.l.rabara
  2025-02-25 18:02 ` Krzysztof Kozlowski
  2025-03-04 12:54 ` Dinh Nguyen
  0 siblings, 2 replies; 4+ messages in thread
From: niravkumar.l.rabara @ 2025-02-25 13:39 UTC (permalink / raw)
  To: Dinh Nguyen, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	niravkumar.l.rabara, nirav.rabara, devicetree, linux-kernel
  Cc: stable, Krzysztof Kozlowski

From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>

Add DMA channel ids for spi0 and spi1 nodes in device tree.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
---
 arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
index 1235ba5a9865..616259447c6f 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
@@ -457,6 +457,8 @@ spi0: spi@ffda4000 {
 			reg-io-width = <4>;
 			num-cs = <4>;
 			clocks = <&clkmgr AGILEX_L4_MAIN_CLK>;
+			dmas = <&pdma 16>, <&pdma 17>;
+			dma-names = "tx", "rx";
 			status = "disabled";
 		};
 
@@ -471,6 +473,8 @@ spi1: spi@ffda5000 {
 			reg-io-width = <4>;
 			num-cs = <4>;
 			clocks = <&clkmgr AGILEX_L4_MAIN_CLK>;
+			dmas = <&pdma 20>, <&pdma 21>;
+			dma-names = "tx", "rx";
 			status = "disabled";
 		};
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH RESEND v2] arm64: dts: socfpga: agilex: Add dma channel id for spi
  2025-02-25 13:39 [PATCH RESEND v2] arm64: dts: socfpga: agilex: Add dma channel id for spi niravkumar.l.rabara
@ 2025-02-25 18:02 ` Krzysztof Kozlowski
  2025-02-26  0:45   ` Rabara, Niravkumar L
  2025-03-04 12:54 ` Dinh Nguyen
  1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-02-25 18:02 UTC (permalink / raw)
  To: niravkumar.l.rabara, Dinh Nguyen, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, nirav.rabara, devicetree,
	linux-kernel
  Cc: stable, Krzysztof Kozlowski

On 25/02/2025 14:39, niravkumar.l.rabara@intel.com wrote:
> From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
> 
> Add DMA channel ids for spi0 and spi1 nodes in device tree.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>

That's not a bugfix.

Why do you Cc stable?

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH RESEND v2] arm64: dts: socfpga: agilex: Add dma channel id for spi
  2025-02-25 18:02 ` Krzysztof Kozlowski
@ 2025-02-26  0:45   ` Rabara, Niravkumar L
  0 siblings, 0 replies; 4+ messages in thread
From: Rabara, Niravkumar L @ 2025-02-26  0:45 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Dinh Nguyen, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, nirav.rabara@altera.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
  Cc: Krzysztof Kozlowski

Hi Krysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Wednesday, 26 February, 2025 2:02 AM
> To: Rabara, Niravkumar L <niravkumar.l.rabara@intel.com>; Dinh Nguyen
> <dinguyen@kernel.org>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski
> <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>;
> nirav.rabara@altera.com; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: stable@vger.kernel.org; Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org>
> Subject: Re: [PATCH RESEND v2] arm64: dts: socfpga: agilex: Add dma channel
> id for spi
> 
> On 25/02/2025 14:39, niravkumar.l.rabara@intel.com wrote:
> > From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
> >
> > Add DMA channel ids for spi0 and spi1 nodes in device tree.
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
> 
> That's not a bugfix.
> 
> Why do you Cc stable?
> 
It was a mistake. Do I need to resend this patch without Cc Stable? 

Thanks,
Nirav

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH RESEND v2] arm64: dts: socfpga: agilex: Add dma channel id for spi
  2025-02-25 13:39 [PATCH RESEND v2] arm64: dts: socfpga: agilex: Add dma channel id for spi niravkumar.l.rabara
  2025-02-25 18:02 ` Krzysztof Kozlowski
@ 2025-03-04 12:54 ` Dinh Nguyen
  1 sibling, 0 replies; 4+ messages in thread
From: Dinh Nguyen @ 2025-03-04 12:54 UTC (permalink / raw)
  To: niravkumar.l.rabara, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, nirav.rabara, devicetree, linux-kernel
  Cc: stable, Krzysztof Kozlowski

On 2/25/25 07:39, niravkumar.l.rabara@intel.com wrote:
> From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
> 
> Add DMA channel ids for spi0 and spi1 nodes in device tree.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
> ---
>   arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> index 1235ba5a9865..616259447c6f 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> @@ -457,6 +457,8 @@ spi0: spi@ffda4000 {

Applied!

Thanks,
Dinh


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-03-04 12:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-25 13:39 [PATCH RESEND v2] arm64: dts: socfpga: agilex: Add dma channel id for spi niravkumar.l.rabara
2025-02-25 18:02 ` Krzysztof Kozlowski
2025-02-26  0:45   ` Rabara, Niravkumar L
2025-03-04 12:54 ` Dinh Nguyen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).