From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79FDAC761AF for ; Tue, 4 Apr 2023 10:06:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234336AbjDDKGU (ORCPT ); Tue, 4 Apr 2023 06:06:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234329AbjDDKGT (ORCPT ); Tue, 4 Apr 2023 06:06:19 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C8B31BD0 for ; Tue, 4 Apr 2023 03:06:17 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id h8so128361892ede.8 for ; Tue, 04 Apr 2023 03:06:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680602776; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DxM7pHYaYfeSkBdBDN7aQqaAsu+9Matzg8m3QMGN1rI=; b=j5SStedHpTECGFWywLmPC52GuOUIrn9O2z99EVD38fkoZOAoRYvW/87/ggpABjeiyT znLCnLu1/8W/pmgcORHwd6DhZ9HEBY/Omu3kXiUH4LRI6SdK/T+Y2OHvJ/85E/linAzZ IhdTscR4J+3LJVOHTvpT/Xw1j+ZtIpyu6eGaTi2+mNA5r1oxZOQGHRci8//pN2Mr57a6 62yxEKN6qDed6le3JEDw6x02QWkF45UBsMGnF7bp3K418ZajeCaCzUGeFjdYJIW5XUyG 8sklu9Mct4hFVWbQCV0aHnw5paSyZknwqZFrmnNmvlg9+i5OFCfB2RrC6FHa7dM+pNMO Ktqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680602776; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DxM7pHYaYfeSkBdBDN7aQqaAsu+9Matzg8m3QMGN1rI=; b=e5FGuUwE0bENF/pzWLlw97EIYrjFxN+3EviTlSM0lWHjYw586Tr9Dfq3jkgbBvgI4x cLMjE+6axanD+rsZlxj/4yveuSKXPZLJcRV2PWWQjK/eXdTa8JicwCM99DsMl8RiBJ9A EbsVR31LfEzRvmKsembY7Sw0wHESlbZJaXdf5ALVjxQajPT1LVguj6wNZwmni/5NiCwQ Ge3j1gZuq59k9StOI8/YprXUOJ9Wr6u9ZILzhxfmFf72xETOCuMreCbvP34T1X1bQz8N 0jZ96eWg7TFJAMeyoHC0djiOQK4DzNEQ0kPG++49v1Vnif00/2wnXGK2q2OXViVHoSP0 CyDQ== X-Gm-Message-State: AAQBX9dr0dnGLnNdihHjYnrYbfkbnI4uCHCygKiv2/cQXg8OQLTZJFuE gYME7tNK3cLlktGuxyq8dv52Ww== X-Google-Smtp-Source: AKy350Zh1SFhrfUf1rjLYpAofSLqfJ7X0dOlxbo2D8cQQ1H073suZ3iJ/Kfj/afUZBfGZEE+Se2YVg== X-Received: by 2002:a17:906:99c8:b0:8b1:2bde:5c70 with SMTP id s8-20020a17090699c800b008b12bde5c70mr1880750ejn.2.1680602775988; Tue, 04 Apr 2023 03:06:15 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:99ed:4575:6001:8bda? ([2a02:810d:15c0:828:99ed:4575:6001:8bda]) by smtp.gmail.com with ESMTPSA id sd19-20020a170906ce3300b00947499e0e4dsm5850768ejb.146.2023.04.04.03.06.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Apr 2023 03:06:15 -0700 (PDT) Message-ID: <847cc6c8-e097-aa3a-2cd7-a6929bec18e9@linaro.org> Date: Tue, 4 Apr 2023 12:06:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v5 2/2] dt-bindings: rtc: add max313xx RTCs Content-Language: en-US To: Alexandre Belloni Cc: Ibrahim Tilki , a.zummo@towertech.it, jdelvare@suse.com, linux@roeck-us.net, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, Zeynep Arslanbenzer References: <20230403154342.3108-1-Ibrahim.Tilki@analog.com> <20230403154342.3108-3-Ibrahim.Tilki@analog.com> <202304040710049c9cc01a@mail.local> <996b49ab-5e2e-76bc-efb1-38c6384871f6@linaro.org> <2023040407444619bf5596@mail.local> <0fd972bd-c5e7-65cc-6992-09c4c3e88f95@linaro.org> <202304040956056c59af98@mail.local> From: Krzysztof Kozlowski In-Reply-To: <202304040956056c59af98@mail.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 04/04/2023 11:56, Alexandre Belloni wrote: > On 04/04/2023 10:14:33+0200, Krzysztof Kozlowski wrote: >> On 04/04/2023 09:44, Alexandre Belloni wrote: >>>> >>>>> charging will always >>>>> enable a diode, select a resistor and then have or not an extra diode. >>>>> Figure2 of the MAX31329 datasheet is great. >>>> >>>> So the diode is in the max313xx? Then why enabling it is a property of >>>> DT? Either this should be inferred from compatible or is even a policy, >>>> not a DT property. Just because device has a register for something, is >>>> not an argument that "something" should be in DT. >>> >>> Well, it depends on the battery that is installed on the board so it >>> makes sense to have it in DT. >> >> OK, that would be a good reason, but I wonder why? Why choosing diode or >> not depends on the battery? Wouldn't you always want to have the diode? >> > > It limits the maximum current used to charge the battery or supercap to > not exceed what is allowed. and I still wonder why someone would like to allow exceeding what is allowed. IOW, what is the use case to disable the diode? Best regards, Krzysztof