From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B46F1C433F5 for ; Wed, 11 May 2022 16:50:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345148AbiEKQuK (ORCPT ); Wed, 11 May 2022 12:50:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345114AbiEKQuB (ORCPT ); Wed, 11 May 2022 12:50:01 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D4191E21BC for ; Wed, 11 May 2022 09:49:54 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id u23so4631156lfc.1 for ; Wed, 11 May 2022 09:49:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=IIyLanREwoFCx9oDtJP6l/B2GLW4c3uyyeB7WHPqlcY=; b=hQAzUQgpbX2JYdHBjVsDzoxLXtlUQwzlLE3xUX4lIk/B4hD8khNTplc3IrbJgpxjNK QMob6SR1yxKEOuV7y5z8PgOVpPfRH8z7+LBnlMJx5EgIIE/orkkqAGNF9AGJd32nS0ca y2a2REBFsZudkVlDBZkJHyvfxl5fVtzMywgJ61Clbq3BnRVIK8KUf49I04U5uR46HiZE O1ai6iDAYhJzAb/C1XF1UCAZb+e3Z9iFGpuhyKPKan4B6GgQa3g27oowOmJ+jzTzayhm ApbPbRxQHSQpJrRRKLw8e88d8FFJn7rr9az2pTiBwbJlW94voFQ3ojN/MbJz1ypdaSeJ zYTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=IIyLanREwoFCx9oDtJP6l/B2GLW4c3uyyeB7WHPqlcY=; b=yzRqaAHv/jtYA/UMA3uzBpUIcTr+LMhHwhOK8wdGvnSLxl4FFx3/Xvw9hK5dIyp/sz isuAW27PvSMZpyT5su+SqkL88C1c3lDp3mvuScG1fE9lW8RQmvLmjedtQpE34GDSoVsn +Z5deOzsgRB+cfwgE2sjF01UMCwoUK/d3bZzJFyfVfYXD9n/5j03ZOXxl62koe4aOOeb aCXuq50YZnZihwvs+XsExIiCCACQmnL9Bvr/SVcQOXJ6MWYox3pQwI852bMCqI7cZv81 pKsCP8QQUcS3SPqRlM2lEYRBU0NJU4absCuMeDrLAjbYYtUDJxkCc45OEP+Zs4s7IwaQ y3tw== X-Gm-Message-State: AOAM532npWn7/BuR3JRqRK4j6eZLhlPz/AHZJY4vn5RlorRfujSLLgfd voRrUYzK1ktDj9ZvtL3pp8hMzw== X-Google-Smtp-Source: ABdhPJxRxRD4JQYBVlHS8IbpgAaqLULxwcV4dQ97/QQyLbn3k+ah3uFu5iuDXB1dZuBPSADzZVyDAw== X-Received: by 2002:a05:6512:1694:b0:448:3fd4:c7a9 with SMTP id bu20-20020a056512169400b004483fd4c7a9mr21053901lfb.29.1652287792448; Wed, 11 May 2022 09:49:52 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id b28-20020a19645c000000b0047255d211c3sm351349lfj.242.2022.05.11.09.49.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 May 2022 09:49:52 -0700 (PDT) Message-ID: <8480eee1-42df-46b2-9ff5-2b09fdcc7dc6@linaro.org> Date: Wed, 11 May 2022 19:49:51 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 1/9] remoteproc: qcom: pas: Add MSM8953 ADSP PIL support Content-Language: en-GB To: Sireesh Kodali , linux-remoteproc@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, bjorn.andersson@linaro.org, devicetree@vger.kernel.org, phone-devel@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Gross , Mathieu Poirier References: <20220511161602.117772-1-sireeshkodali1@gmail.com> <20220511161602.117772-2-sireeshkodali1@gmail.com> From: Dmitry Baryshkov In-Reply-To: <20220511161602.117772-2-sireeshkodali1@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/05/2022 19:15, Sireesh Kodali wrote: > Add support for the Audio DSP PIL found on the Qualcomm MSM8953 > platform. The same configuration is used on all SoCs based on the > MSM8953 platform (SDM450, SDA450, SDM625, SDM632, APQ8053). > > Signed-off-by: Sireesh Kodali > --- > drivers/remoteproc/qcom_q6v5_pas.c | 31 ++++++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c > index 1ae47cc153e5..4dcb714a1468 100644 > --- a/drivers/remoteproc/qcom_q6v5_pas.c > +++ b/drivers/remoteproc/qcom_q6v5_pas.c > @@ -617,7 +617,37 @@ static const struct adsp_data sm8350_adsp_resource = { > .ssctl_id = 0x14, > }; > > +static const struct adsp_data msm8953_adsp_resource = { > + .crash_reason_smem = 423, > + .firmware_name = "adsp.mdt", > + .pas_id = 1, > + .has_aggre2_clk = false, > + .auto_boot = true, > + .proxy_pd_names = (char*[]){ > + "cx", > + NULL, > + }, > + .ssr_name = "lpass", > + .sysmon_name = "adsp", > + .ssctl_id = 0x14, > +}; > + > static const struct adsp_data msm8996_adsp_resource = { > + .crash_reason_smem = 423, > + .firmware_name = "adsp.mdt", > + .pas_id = 1, > + .has_aggre2_clk = false, > + .auto_boot = true, > + .proxy_pd_names = (char*[]){ > + "cx", > + NULL, > + }, > + .ssr_name = "lpass", > + .sysmon_name = "adsp", > + .ssctl_id = 0x14, > +}; > + > +static const struct adsp_data msm8998_adsp_resource = { This was dropped in 9ae45035ba2be4117edb8fd3952c3c5b84a0b820. Please take care when rebasing your patches. > .crash_reason_smem = 423, > .firmware_name = "adsp.mdt", > .pas_id = 1, > @@ -850,6 +880,7 @@ static const struct adsp_data sdx55_mpss_resource = { > static const struct of_device_id adsp_of_match[] = { > { .compatible = "qcom,msm8974-adsp-pil", .data = &adsp_resource_init}, > { .compatible = "qcom,msm8996-adsp-pil", .data = &msm8996_adsp_resource}, > + { .compatible = "qcom,msm8953-adsp-pil", .data = &msm8953_adsp_resource}, > { .compatible = "qcom,msm8996-slpi-pil", .data = &slpi_resource_init}, > { .compatible = "qcom,msm8998-adsp-pas", .data = &msm8996_adsp_resource}, > { .compatible = "qcom,msm8998-slpi-pas", .data = &slpi_resource_init}, -- With best wishes Dmitry