From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE66CC433EF for ; Thu, 21 Jul 2022 09:13:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231859AbiGUJNj (ORCPT ); Thu, 21 Jul 2022 05:13:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229661AbiGUJNg (ORCPT ); Thu, 21 Jul 2022 05:13:36 -0400 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 605B9357D7 for ; Thu, 21 Jul 2022 02:13:31 -0700 (PDT) Received: by mail-lj1-x236.google.com with SMTP id m9so1061042ljp.9 for ; Thu, 21 Jul 2022 02:13:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=TpS5izxbfaIi7KiXxTWz4goQ0xYb3Nec6QgQZFgkaFE=; b=Ne/Tamn9sbxHkFifvNCByhbqPuu7S59vYRhKjA+pAGtq/voVmRpIKPGl9l2Kjbc98w 5CKROxuqxUCEqexcCgU3SHklH4gCpLkkMPZ5fTqsEk1Q0mBkpckAnTqyH19AT7cWqqx1 GtuOTVsIHaeXnoC4oGX78S5T9pCG+PPPP/NfC/cu7xK69P8GkXvmY2Yoe7utySXmSHLB l3QomXa/Hw95FksUG9tfQW0bJ+lNDf0NtjzhudXzf2B6isggQukBIHvIZGLeSQl7OOxI oqCh+uWtxNvECLXZPtL8zCbd6CyhMkDXx2EuFxw7aizwyLDeGHefcD2w32KfH0X1pIw6 9qpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=TpS5izxbfaIi7KiXxTWz4goQ0xYb3Nec6QgQZFgkaFE=; b=E+FJKp+nOCWYki3ea/NlyBP0jo30eJAe432gD5Ei/qMkywlLDB0zgvwLXLiJ7pQm5c 8p8bS3he7X+INKaxPImTQzXWgNkH/Uhn/zXoxKtrTpArAIkupgKG34qDI+9hkX6HmPrl 7wgfOI/z8NrZZEo6jrud0rvgLf1diVxHdkZhG+MF0PsWzKdNhEKbNqLzSN9/oTNchxfV 6bCfE+VmBWnL6p4P26KFxdA6Ix84Bpxic/qniHmcHBKQ61gG9EYqQS/g89GgpqmwV4FL uWFYKOTwVEFJwqo+hZsJIIcJV94X2IXkuJ0w0s25oL/18SYF/U63CySNpEstcCXUTN3v GFwA== X-Gm-Message-State: AJIora+teoRJckcbMpaHdaW2hq1flpxODTKDSfnuMrIGMqt4SRhwDsjF AFrrENmXT36q+p/zI57LlnMyvw== X-Google-Smtp-Source: AGRyM1vl+UbQxsnzo9Wgux87cQYIJBlZXhKDpg0KV4cXsthLRh+gvdcdYWQ7aL/wMk5e1MmMIqymUg== X-Received: by 2002:a2e:504:0:b0:25d:529a:3852 with SMTP id 4-20020a2e0504000000b0025d529a3852mr17569239ljf.179.1658394809488; Thu, 21 Jul 2022 02:13:29 -0700 (PDT) Received: from [192.168.115.193] (89-162-31-138.fiber.signal.no. [89.162.31.138]) by smtp.gmail.com with ESMTPSA id y11-20020a05651c106b00b002554dce4048sm366771ljm.53.2022.07.21.02.13.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Jul 2022 02:13:28 -0700 (PDT) Message-ID: <84853ee4-94aa-585d-e13d-dca21a6ac37e@linaro.org> Date: Thu, 21 Jul 2022 11:13:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v4 2/5] dt-bindings: phy: Add ARTPEC-8 PCIe phy Content-Language: en-US To: wangseok.lee@samsung.com, "robh+dt@kernel.org" , "krzk+dt@kernel.org" , "kishon@ti.com" , "vkoul@kernel.org" , "linux-kernel@vger.kernel.org" , "jesper.nilsson@axis.com" , "lars.persson@axis.com" , "bhelgaas@google.com" , "linux-phy@lists.infradead.org" , "linux-pci@vger.kernel.org" , "devicetree@vger.kernel.org" , "lorenzo.pieralisi@arm.com" , "kw@linux.com" , "linux-arm-kernel@axis.com" , "kernel@axis.com" Cc: Moon-Ki Jun , Sang Min Kim , Dongjin Yang , Yeeun Kim References: <20220720055108epcms2p563c65b3de6333ccbc68386aa2471a800@epcms2p5> <20220720055716epcms2p60e80b1089dca0f83a894262bce676858@epcms2p6> From: Krzysztof Kozlowski In-Reply-To: <20220720055716epcms2p60e80b1089dca0f83a894262bce676858@epcms2p6> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 20/07/2022 07:57, Wangseok Lee wrote: > Add description to support Axis, ARTPEC-8 SoC. ARTPEC-8 is the SoC platform > of Axis Communications and PCIe PHY is designed based on Samsung PHY. > > Signed-off-by: Wangseok Lee > --- > v3->v4 : > -Add "fsys-sysreg" to properties > -Modify the "lcpll-ref-clk" and "clocks" in properties > "lcpll-ref-clk" is custom properties, so add 'vendor', type(enum), > description > Add the maxItem in clocks, add clock-names in properties > > v2->v3 : > -Modify version history to fit the linux commit rule > -Remove 'Device Tree Bindings' on title > -Remove clock-names entries > -Change node name to soc from artpec8 on excamples > > v1->v2 : > -'make dt_binding_check' result improvement > -Add the missing property list > -Align the indentation of continued lines/entries > --- > .../bindings/phy/axis,artpec8-pcie-phy.yaml | 85 ++++++++++++++++++++++ > 1 file changed, 85 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/axis,artpec8-pcie-phy.yaml > > diff --git a/Documentation/devicetree/bindings/phy/axis,artpec8-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/axis,artpec8-pcie-phy.yaml > new file mode 100644 > index 0000000..9db39ef > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/axis,artpec8-pcie-phy.yaml > @@ -0,0 +1,85 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/axis,artpec8-pcie-phy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ARTPEC-8 SoC PCIe PHY > + > +maintainers: > + - Jesper Nilsson > + > +properties: > + compatible: > + const: axis,artpec8-pcie-phy > + > + reg: > + items: > + - description: PHY registers. > + - description: PHY coding sublayer registers. > + > + reg-names: > + items: > + - const: phy > + - const: pcs > + > + "#phy-cells": > + const: 0 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + items: > + - const: ref > + > + samsung,fsys-sysreg: > + description: > + Phandle to system register of fsys block. > + $ref: /schemas/types.yaml#/definitions/phandle > + > + num-lanes: > + const: 2 > + > + axis,lcpll-ref-clk: > + description: > + select the reference clock of phy and initialization is performed > + with the reference clock according to the selected value. > + $ref: /schemas/types.yaml#/definitions/uint32 This looks like hardware register value... but after looking at driver you rather need string... although REF_CLK_RESERVED is confusing. You need to describe the feature, not some device programming model. Then looking deeper it seems you just made a workaround around common clock framework. At least for XO and SOC case - you just implemented a clock mux in your PHY driver! Implement a clock driver instead and handle only special case - clock coming from IO. Best regards, Krzysztof