devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: bcm4329-fmac: Add ingenic,iw8103-fmac compatible string
@ 2022-12-14 15:59 Paul Cercueil
  2022-12-14 16:53 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 3+ messages in thread
From: Paul Cercueil @ 2022-12-14 15:59 UTC (permalink / raw)
  To: Kalle Valo, David S . Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Arend van Spriel
  Cc: list, linux-wireless, netdev, devicetree, linux-kernel,
	Paul Cercueil

The MIPS CI20 board has a Ingenic IW8103 chip, which is supposedly just
a rebranded Broadcom BCM4330.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
 .../devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml      | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
index fec1cc9b9a08..d092c1e7f3ef 100644
--- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
@@ -40,6 +40,7 @@ properties:
               - brcm,bcm4359-fmac
               - cypress,cyw4373-fmac
               - cypress,cyw43012-fmac
+              - ingenic,iw8103-fmac
           - const: brcm,bcm4329-fmac
       - enum:
           - brcm,bcm4329-fmac
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: bcm4329-fmac: Add ingenic,iw8103-fmac compatible string
  2022-12-14 15:59 [PATCH] dt-bindings: bcm4329-fmac: Add ingenic,iw8103-fmac compatible string Paul Cercueil
@ 2022-12-14 16:53 ` Krzysztof Kozlowski
  2022-12-19 12:00   ` Arend van Spriel
  0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-14 16:53 UTC (permalink / raw)
  To: Paul Cercueil, Kalle Valo, David S . Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
	Arend van Spriel
  Cc: list, linux-wireless, netdev, devicetree, linux-kernel

On 14/12/2022 16:59, Paul Cercueil wrote:
> The MIPS CI20 board has a Ingenic IW8103 chip, which is supposedly just
> a rebranded Broadcom BCM4330.
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: bcm4329-fmac: Add ingenic,iw8103-fmac compatible string
  2022-12-14 16:53 ` Krzysztof Kozlowski
@ 2022-12-19 12:00   ` Arend van Spriel
  0 siblings, 0 replies; 3+ messages in thread
From: Arend van Spriel @ 2022-12-19 12:00 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Paul Cercueil, Kalle Valo, David S . Miller,
	Eric Dumazet, Jakub Kicinski, Paolo Abeni, Rob Herring,
	Krzysztof Kozlowski, Arend van Spriel
  Cc: list, linux-wireless, netdev, devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 600 bytes --]

On 12/14/2022 5:53 PM, Krzysztof Kozlowski wrote:
> On 14/12/2022 16:59, Paul Cercueil wrote:
>> The MIPS CI20 board has a Ingenic IW8103 chip, which is supposedly just
>> a rebranded Broadcom BCM4330.
>>
>> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> 
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

My guess is that Ingenic is not really a chip manufacturer, but this is 
actually a wifi module using BCM4330 as wifi chip. Personally, I would 
not add a compatible string for that and the commit message does not 
offer any arguments for having this.

Regards,
Arend

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4219 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-12-19 12:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-14 15:59 [PATCH] dt-bindings: bcm4329-fmac: Add ingenic,iw8103-fmac compatible string Paul Cercueil
2022-12-14 16:53 ` Krzysztof Kozlowski
2022-12-19 12:00   ` Arend van Spriel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).